From f4eef1b61be73aec4556b78bd28c54e30cc5fd30 Mon Sep 17 00:00:00 2001 From: Hardikkumar Nai <80053762+hardiknai-techm@users.noreply.github.com> Date: Fri, 9 Jul 2021 07:40:29 +0530 Subject: [PATCH] Resolve Eslint for Tables.Constants (#914) * resolve_eslint_Tables.Constants * correct spelling mistake --- .eslintignore | 36 ----------------------------- src/Explorer/Tables/Constants.ts | 30 ++++++++++++------------ src/GalleryViewer/GalleryViewer.tsx | 4 ++-- 3 files changed, 17 insertions(+), 53 deletions(-) diff --git a/.eslintignore b/.eslintignore index b4c56fa2d..f4064b9e5 100644 --- a/.eslintignore +++ b/.eslintignore @@ -105,17 +105,10 @@ src/Explorer/Notebook/NotebookContentClient.ts src/Explorer/Notebook/NotebookContentItem.ts src/Explorer/Notebook/NotebookUtil.ts src/Explorer/OpenActionsStubs.ts -src/Explorer/Panes/AddDatabasePane.ts -src/Explorer/Panes/AddDatabasePane.test.ts -src/Explorer/Panes/BrowseQueriesPane.ts -src/Explorer/Panes/RenewAdHocAccessPane.ts -src/Explorer/Panes/SetupNotebooksPane.ts -src/Explorer/Panes/SwitchDirectoryPane.ts src/Explorer/Panes/Tables/Validators/EntityPropertyNameValidator.ts src/Explorer/Panes/Tables/Validators/EntityPropertyValidationCommon.ts src/Explorer/Panes/Tables/Validators/EntityPropertyValueValidator.ts src/Explorer/SplashScreen/SplashScreen.test.ts -src/Explorer/Tables/Constants.ts src/Explorer/Tables/DataTable/CacheBase.ts src/Explorer/Tables/DataTable/DataTableBindingManager.ts src/Explorer/Tables/DataTable/DataTableBuilder.ts @@ -141,11 +134,8 @@ src/Explorer/Tabs/DocumentsTab.test.ts src/Explorer/Tabs/DocumentsTab.ts src/Explorer/Tabs/GraphTab.ts src/Explorer/Tabs/MongoDocumentsTab.ts -# src/Explorer/Tabs/MongoQueryTab.ts -# src/Explorer/Tabs/MongoShellTab.ts src/Explorer/Tabs/NotebookV2Tab.ts src/Explorer/Tabs/ScriptTabBase.ts -# src/Explorer/Tabs/StoredProcedureTab.ts src/Explorer/Tabs/TabComponents.ts src/Explorer/Tabs/TabsBase.ts src/Explorer/Tabs/TriggerTab.ts @@ -168,35 +158,12 @@ src/GitHub/GitHubConnector.ts src/GitHub/GitHubContentProvider.test.ts src/GitHub/GitHubContentProvider.ts src/GitHub/GitHubOAuthService.ts -src/HostedExplorer.ts src/Index.ts src/Juno/JunoClient.test.ts src/Juno/JunoClient.ts -src/Main.ts -src/NotebookWorkspaceManager/NotebookWorkspaceManager.ts -src/NotebookWorkspaceManager/NotebookWorkspaceResourceProviderMockClients.ts -src/Platform/Emulator/DataAccessUtility.ts -src/Platform/Emulator/ExplorerFactory.ts -src/Platform/Emulator/Main.ts -src/Platform/Emulator/NotificationsClient.ts -src/Platform/Hosted/ArmResourceUtils.ts src/Platform/Hosted/Authorization.ts -src/Platform/Hosted/DataAccessUtility.ts -src/Platform/Hosted/ExplorerFactory.ts src/Platform/Hosted/Helpers/ConnectionStringParser.test.ts -src/Platform/Hosted/Main.ts -src/Platform/Hosted/Maint.test.ts -src/Platform/Hosted/NotificationsClient.ts -src/Platform/Portal/DataAccessUtility.ts -src/Platform/Portal/ExplorerFactory.ts -src/Platform/Portal/Main.ts -src/Platform/Portal/NotificationsClient.ts -src/PlatformType.ts src/ReactDevTools.ts -src/ResourceProvider/IResourceProviderClient.test.ts -src/ResourceProvider/IResourceProviderClient.ts -src/ResourceProvider/ResourceProviderClient.ts -src/ResourceProvider/ResourceProviderClientFactory.ts src/Shared/Constants.ts src/Shared/DefaultExperienceUtility.test.ts src/Shared/DefaultExperienceUtility.ts @@ -287,8 +254,5 @@ src/Explorer/Tabs/NotebookViewerTab.tsx src/Explorer/Tabs/TerminalTab.tsx src/Explorer/Tree/ResourceTreeAdapter.tsx src/Explorer/Tree/ResourceTreeAdapterForResourceToken.tsx -src/GalleryViewer/Cards/GalleryCardComponent.tsx -src/GalleryViewer/GalleryViewer.tsx -src/GalleryViewer/GalleryViewerComponent.tsx __mocks__/monaco-editor.ts src/Explorer/Tree/ResourceTreeAdapterForResourceToken.test.tsx \ No newline at end of file diff --git a/src/Explorer/Tables/Constants.ts b/src/Explorer/Tables/Constants.ts index 5d5d60fee..9bb313b7a 100644 --- a/src/Explorer/Tables/Constants.ts +++ b/src/Explorer/Tables/Constants.ts @@ -1,4 +1,4 @@ -export var TableType = { +export const TableType = { String: "String", Boolean: "Boolean", Binary: "Binary", @@ -9,7 +9,7 @@ export var TableType = { Int64: "Int64", }; -export var CassandraType = { +export const CassandraType = { Ascii: "Ascii", Bigint: "Bigint", Blob: "Blob", @@ -27,12 +27,12 @@ export var CassandraType = { Tinyint: "Tinyint", }; -export var ClauseRule = { +export const ClauseRule = { And: "And", Or: "Or", }; -export var Operator = { +export const Operator = { EqualTo: "==", GreaterThan: ">", GreaterThanOrEqualTo: ">=", @@ -42,7 +42,7 @@ export var Operator = { Equal: "=", }; -export var ODataOperator = { +export const ODataOperator = { EqualTo: "eq", GreaterThan: "gt", GreaterThanOrEqualTo: "ge", @@ -51,7 +51,7 @@ export var ODataOperator = { NotEqualTo: "ne", }; -export var timeOptions = { +export const timeOptions = { lastHour: "Last hour", last24Hours: "Last 24 hours", last7Days: "Last 7 days", @@ -62,7 +62,7 @@ export var timeOptions = { custom: "Custom...", }; -export var htmlSelectors = { +export const htmlSelectors = { dataTableSelector: "#storageTable", dataTableAllRowsSelector: "#storageTable tbody tr", dataTableHeadRowSelector: ".dataTable thead tr", @@ -84,9 +84,9 @@ export var htmlSelectors = { selectAllDropdownSelector: "#select-all-dropdown", }; -export var defaultHeader = " "; +export const defaultHeader = " "; -export var EntityKeyNames = { +export const EntityKeyNames = { PartitionKey: "PartitionKey", RowKey: "RowKey", Timestamp: "Timestamp", @@ -94,7 +94,7 @@ export var EntityKeyNames = { Etag: "etag", }; -export var htmlAttributeNames = { +export const htmlAttributeNames = { dataTableNameAttr: "name_attr", dataTableContentTypeAttr: "contentType_attr", dataTableSnapshotAttr: "snapshot_attr", @@ -103,14 +103,14 @@ export var htmlAttributeNames = { dataTableHeaderIndex: "data-column-index", }; -export var cssColors = { +export const cssColors = { commonControlsButtonActive: "#B4C7DC" /* A darker shade of [{common-controls-button-hover-background}] */, }; -export var clauseGroupColors = ["#ffe1ff", "#fffacd", "#f0ffff", "#ffefd5", "#f0fff0"]; -export var transparentColor = "transparent"; +export const clauseGroupColors = ["#ffe1ff", "#fffacd", "#f0ffff", "#ffefd5", "#f0fff0"]; +export const transparentColor = "transparent"; -export var keyCodes = { +export const keyCodes = { RightClick: 3, Enter: 13, Esc: 27, @@ -163,7 +163,7 @@ export var keyCodes = { Dash: 189, }; -export var InputType = { +export const InputType = { Text: "text", // Chrome doesn't support datetime, instead, datetime-local is supported. DateTime: "datetime-local", diff --git a/src/GalleryViewer/GalleryViewer.tsx b/src/GalleryViewer/GalleryViewer.tsx index 07fcb733e..e630ee7b2 100644 --- a/src/GalleryViewer/GalleryViewer.tsx +++ b/src/GalleryViewer/GalleryViewer.tsx @@ -42,10 +42,10 @@ const onInit = async () => { practices, and how to get started with Azure Cosmos DB. - If you'd like to run or edit the notebook in your own Azure Cosmos DB account,{" "} + If {`you'd`} like to run or edit the notebook in your own Azure Cosmos DB account,{" "} sign in and select an account with{" "} notebooks enabled. From there, you can download the sample to your - account. If you don't have an account yet, you can{" "} + account. If you {`don't`} have an account yet, you can{" "} create one from the Azure portal.