The Data Explorer left-nav resource tree did not expose selection state to
assistive technology. Screen readers announced tree items (e.g. "Documents,
1 of 2, level 3") without conveying whether the item was selected, failing
MAS 4.1.2 (Name, Role, Value).
Selection in the tree is a custom app-state concept (node.isSelected /
shouldShowAsSelected) and does not use Fluent v9's built-in selectionMode.
Wire the existing selection state to the aria-selected prop on TreeItem so
selectable nodes announce "selected"/"not selected". Pure grouping nodes
(no isSelected) omit the attribute, matching the ARIA single-select tree
pattern.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 956998dd-4849-4f7d-a027-b7190018e089
Removes the GitHub notebook-repo integration that only existed to pin/browse notebook repositories. Deletes src/GitHub/, the GitHub controls/panes, GitHubUtils, JunoUtils, and the connectToGitHub webpack entry. Decouples NotebookManager, useNotebook, the resource tree, and Explorer from GitHub wiring. Trims JunoClient's GitHub-only methods while keeping the Schema and gallery methods. Removes GitHub config fields from ConfigContext and strips the dead github:// branches from NotebookUtil.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix query tab view: respect default setting and add toggle behavior
- Use getDefaultQueryResultsView() when splitterDirection prop is not
provided, so the user's configured default from Settings is respected
- Add onCommandClick to the View split button that toggles between
Vertical and Horizontal layout when the main button is clicked
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add Playwright E2E tests for query tab View toggle and dropdown
- Add View to CommandBarButton enum in test fixtures
- Add test: clicking main View button toggles between vertical/horizontal
- Add test: selecting options from View dropdown changes layout
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add Playwright E2E tests for query tab View toggle and dropdown
- Add View to CommandBarButton enum in test fixtures
- Add test: clicking main View button toggles between vertical/horizontal
- Add test: selecting options from View dropdown changes layout
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix issue that was failing tests when using account keys for access.
* Remove commented code.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add implementation plan for removing Phoenix and notebooks
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Phase 1: Decouple database shells from Phoenix to CloudShell-only
Migrate all shell terminals to the CloudShell path and remove the legacy Phoenix notebook-server terminal code so shells no longer depend on notebook provisioning.
- TerminalTab now always uses CloudShellTerminalComponentAdapter; removed the notebook-server adapter branch, getNotebookServerInfo, and the dead VCoreMongo firewall check
- Migrate Postgres and VCore Mongo quickstart tabs to CloudShellTerminalComponent (drop allocateContainer/useNotebook dependencies)
- Refactor useTerminal to send input via the CloudShell WebSocket instead of postRobot/iframe; register the socket from CloudShellTerminalComponent
- Simplify Explorer.openNotebookTerminal to always open a CloudShell terminal
- Delete NotebookTerminalComponent(+test/less/snapshot), NotebookTerminalComponentAdapter, and the src/Terminal/ entry point
- Remove the terminal.html webpack entry/HTML plugin and src/Terminal from tsconfig.strict.json
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Adding further console logging but also fixed lines with JSON.stringify(error)
* Added retry mechanism for GETs for armRequest workflow
* Moved stringifyError into its own file as it was causing strict compile issues in ErrorHandlingUtils
* Removing temporary debug logging
* Undoing eslint change as well
* Adding further console logging but also fixed lines with JSON.stringify(error)
* Added retry mechanism for GETs for armRequest workflow
* Moved stringifyError into its own file as it was causing strict compile issues in ErrorHandlingUtils
* Initial change for online partition key change
* Refactoring container copy strings so they can be locallized
* Missed a file
* Fixing some issues found by lint
* Fixing errors
* Fixing unit tests
* Fixing error caused by merging from master
* Fixing minor error from merge
* Fixing merge error
* Addressing comments
* Addressing some PR comments
* Minor issues
* Refixing a formatting issue
* Fixed localization error
* Scale the number of test accounts used for SQL tests to one per shard.
* Set PLAYWRIGHT_SHARD_INDEX environment variable in CI workflow.
* Add log statement for the shared index and selected account.
* Remove console log.
* Fix order of accounts so that shard index maps to same account index.
* Try to fix the SQL account scope in ci.yml
* Get tokens for all accounts and use the shard index to pick which one.
* Set tokens without loop.
* Handcode the token use in tests.
* Fix database creation.
* Add debug for rbac token issues.
* Common function for retrieving NoSQL token.
* Disable eslint rule for noconsole temporarily.
* Move getNoSqlRbacToken to separate file.
* Fix ref to new function.
* mock Resource Graph API — fires on auto-subscription selection to populate account dropdown
* Code tidy-up.
* Fix build errors.
* Remove deprecated getDbAccountAllowedStatus from PhoenixClient
The getDbAccountAllowedStatus endpoint is no longer available. All callers
now assume a Forbidden result, meaning isPhoenixNotebooks and
isPhoenixFeatures are always false.
- Remove getDbAccountAllowedStatus() from PhoenixClient
- Simplify getPhoenixStatus() in useNotebook to set both flags to false
- Remove IDbAccountAllow interface from DataModels
- Remove PhoenixDBAccountAllowed and CheckPhoenixStatus telemetry actions
- Clean up unused imports
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Revert removal of enum values, to be safe.
---------
Co-authored-by: Bikram Choudhury <bchoudhury@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: add copyable ID to delete confirmation dialogs
When deleting databases or containers, the confirmation dialog now displays
the resource ID in a read-only text field with a copy button, allowing users
to copy-paste the ID into the confirmation input instead of typing it manually.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fixed formatting.
* revert non-en locale changes; add localization instruction
Revert changes to non-English locale files — translations are managed
by a separate localization process. Add a note to copilot instructions
clarifying that only en/Resources.json should be modified.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: capitalize 'Id' in copyable resource ID labels
Changed 'id:' to 'Id:' in the copyable ID labels for delete confirmation
dialogs (both database and collection).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* fix: capitalize collection name in copyable ID label
Use getCollectionName() directly (returns 'Container', 'Collection', etc.)
instead of the lowercased collectionName variable for the copyable ID label.
The database panel already used getDatabaseName() which returns capitalized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* feat: add warning message to delete container confirmation dialog
Added the same warning banner that exists in the delete database dialog
to the delete container dialog, informing users that the action cannot
be undone and will permanently delete the resource and its children.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Copilot assisted changes to remove shared throughput options in add database/container.
* Add E2E tests verifying shared throughput option is removed from creation dialogs
Add three new E2E tests to sharedThroughput.spec.ts:
- New Database panel should not show shared throughput checkbox
- New Container panel should not show shared throughput checkbox when creating new database
- Dedicated throughput checkbox still appears for existing shared database (regression guard)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* default throughput bucket
* nit
* show inactive buckets
* add e2e tests for default throughput bucket
* for test sql containers, use throughput of 4000
* remove container throughput on creation
* added offer throughput
* add default throughput bucket info link
* add text localization
* upgrade playwright
* Fix flaky permissionsScreen test by using unrouteAll with ignoreErrors
* fix: move container creation to beforeAll to reduce CI shard timeout
* remove comment
---------
Co-authored-by: Asier Isayas <aisayas@microsoft.com>
* Reapply "MSAL browser migration changes"
This reverts commit 60a65efb7b.
* Fix redirect URI for localhost
* Fix URI for logout and other minor fix
* Remove unnecessary files
* Fix tests
* Fix tests
* Run npm format
* Address comments
* Address comment
* implemented search bar
* formatting corrected
* added pin(fav) and sorting in local in sidebar tree of DE
* reverted changes
* fixed lint and formatting issues
* fixed lint and formatting issues
* theme toggle button is disabled if in portal
* fixed lint error
* added link on disabled theme toggle button
* updated the variable for pin icon
* removed en-us from url
---------
Co-authored-by: nishthaAhujaa <nishtha17354@iiittd.ac.in>
Co-authored-by: sakshigupta12feb <sakshigupta12feb1@gmail.com>
Co-authored-by: Sakshi Gupta <sakshig@microsoft.com>
* DDM login issue fixed while logging in via connection string
* Removed isPolicyEnabled. The includePaths field should be mandatory and, if present, must be an array
* updated the included value validation and excluded to be optional
---------
Co-authored-by: Sakshi Gupta <sakshig@microsoft.com>
* Fix: Disable Complete action when any job update is in progress
- Updated CopyJobActionMenu to disable Complete button when any action is being performed
- Added comprehensive tests to verify Complete button is disabled during updates
- Improved user experience by preventing concurrent actions on copy jobs
This PR was generated by GitHub Copilot CLI
* Fix lint error: Remove unused variable in CopyJobActionMenu (#2336)
* Initial plan
* Fix lint error: Remove unused variable 'updatingAction' in CopyJobActionMenu.tsx
Co-authored-by: BChoudhury-ms <201893606+BChoudhury-ms@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BChoudhury-ms <201893606+BChoudhury-ms@users.noreply.github.com>
---------
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: BChoudhury-ms <201893606+BChoudhury-ms@users.noreply.github.com>
* added a dark theme toggle button on Copyjobs next to refresh button and covered full feature
* Fix formatting in Utils.test.ts
* updated infor icon , error icon and text on jobs details page
* rebased from master
* updated the conflicts
* updated the conflicts
* fixed the test suit
* fixed review comments
* test fix
---------
Co-authored-by: Sakshi Gupta <sakshig@microsoft.com>
Jade Welton
asier-isayas
sakshigupta12feb
Nishtha Ahuja
jawelton74
vchske
BChoudhury-ms
sunghyunkang1111
sindhuba
Laurent Nguyen
Dmitry Shilov