Compare commits

..

9 Commits

Author SHA1 Message Date
Asier Isayas
fd9cb0026c verify document text was set 2026-01-22 14:28:54 -08:00
Asier Isayas
4a5ed80c6c increase wait time to 5s 2026-01-22 13:54:10 -08:00
Asier Isayas
544ac890c6 DEBUG: wait for editor to process changes 2026-01-22 13:34:17 -08:00
Asier Isayas
094fd4d6f4 find first execute button for stored procedure 2026-01-22 12:33:17 -08:00
Asier Isayas
7665f60fdd DEBUG: expand console for mongo testing 2026-01-22 12:32:58 -08:00
Asier Isayas
561eb6d1fa delete db after each test 2026-01-22 08:30:15 -08:00
Asier Isayas
d24400198d Merge branch 'master' of https://github.com/Azure/cosmos-explorer into users/aisayas/delete-after-each-test 2026-01-22 08:26:59 -08:00
Asier Isayas
d32ccfef13 disable offline/online migration tests 2026-01-21 09:13:46 -08:00
Asier Isayas
3f01ce5ff0 dont refresh tree when opening scale & settings 2026-01-21 08:06:18 -08:00
16 changed files with 410 additions and 647 deletions

View File

@@ -7,27 +7,16 @@ import { HttpStatusCodes } from "./Constants";
import { logError } from "./Logger"; import { logError } from "./Logger";
import { sendMessage } from "./MessageHandler"; import { sendMessage } from "./MessageHandler";
export interface HandleErrorOptions { export const handleError = (error: string | ARMError | Error, area: string, consoleErrorPrefix?: string): void => {
/** Optional redacted error to use for telemetry logging instead of the original error */
redactedError?: string | ARMError | Error;
}
export const handleError = (
error: string | ARMError | Error,
area: string,
consoleErrorPrefix?: string,
options?: HandleErrorOptions,
): void => {
const errorMessage = getErrorMessage(error); const errorMessage = getErrorMessage(error);
const errorCode = error instanceof ARMError ? error.code : undefined; const errorCode = error instanceof ARMError ? error.code : undefined;
// logs error to data explorer console (always shows original, non-redacted message) // logs error to data explorer console
const consoleErrorMessage = consoleErrorPrefix ? `${consoleErrorPrefix}:\n ${errorMessage}` : errorMessage; const consoleErrorMessage = consoleErrorPrefix ? `${consoleErrorPrefix}:\n ${errorMessage}` : errorMessage;
logConsoleError(consoleErrorMessage); logConsoleError(consoleErrorMessage);
// logs error to both app insight and kusto (use redacted message if provided) // logs error to both app insight and kusto
const telemetryErrorMessage = options?.redactedError ? getErrorMessage(options.redactedError) : errorMessage; logError(errorMessage, area, errorCode);
logError(telemetryErrorMessage, area, errorCode);
// checks for errors caused by firewall and sends them to portal to handle // checks for errors caused by firewall and sends them to portal to handle
sendNotificationForError(errorMessage, errorCode); sendNotificationForError(errorMessage, errorCode);

View File

@@ -44,8 +44,7 @@ export const deleteDocuments = async (
documentIds: DocumentId[], documentIds: DocumentId[],
abortSignal: AbortSignal, abortSignal: AbortSignal,
): Promise<IBulkDeleteResult[]> => { ): Promise<IBulkDeleteResult[]> => {
const totalCount = documentIds.length; const clearMessage = logConsoleProgress(`Deleting ${documentIds.length} ${getEntityName(true)}`);
const clearMessage = logConsoleProgress(`Deleting ${totalCount} ${getEntityName(true)}`);
try { try {
const v2Container = await client().database(collection.databaseId).container(collection.id()); const v2Container = await client().database(collection.databaseId).container(collection.id());
@@ -84,7 +83,11 @@ export const deleteDocuments = async (
const flatAllResult = Array.prototype.concat.apply([], allResult); const flatAllResult = Array.prototype.concat.apply([], allResult);
return flatAllResult; return flatAllResult;
} catch (error) { } catch (error) {
handleError(error, "DeleteDocuments", `Error while deleting ${totalCount} ${getEntityName(totalCount > 1)}`); handleError(
error,
"DeleteDocuments",
`Error while deleting ${documentIds.length} ${getEntityName(documentIds.length > 1)}`,
);
throw error; throw error;
} finally { } finally {
clearMessage(); clearMessage();

View File

@@ -1,171 +0,0 @@
import { redactSyntaxErrorMessage } from "./queryDocumentsPage";
/* Typical error to redact looks like this (the message property contains a JSON string with nested structure):
{
"message": "{\"code\":\"BadRequest\",\"message\":\"{\\\"errors\\\":[{\\\"severity\\\":\\\"Error\\\",\\\"location\\\":{\\\"start\\\":0,\\\"end\\\":5},\\\"code\\\":\\\"SC1001\\\",\\\"message\\\":\\\"Syntax error, incorrect syntax near 'Crazy'.\\\"}]}\\r\\nActivityId: d5424e10-51bd-46f7-9aec-7b40bed36f17, Windows/10.0.20348 cosmos-netstandard-sdk/3.18.0\"}"
}
*/
// Helper to create the nested error structure that matches what the SDK returns
const createNestedError = (
errors: Array<{ severity?: string; location?: { start: number; end: number }; code: string; message: string }>,
activityId: string = "test-activity-id",
): { message: string } => {
const innerErrorsJson = JSON.stringify({ errors });
const innerMessage = `${innerErrorsJson}\r\n${activityId}`;
const outerJson = JSON.stringify({ code: "BadRequest", message: innerMessage });
return { message: outerJson };
};
// Helper to parse the redacted result
const parseRedactedResult = (result: { message: string }) => {
const outerParsed = JSON.parse(result.message);
const [innerErrorsJson, activityIdPart] = outerParsed.message.split("\r\n");
const innerErrors = JSON.parse(innerErrorsJson);
return { outerParsed, innerErrors, activityIdPart };
};
describe("redactSyntaxErrorMessage", () => {
it("should redact SC1001 error message", () => {
const error = createNestedError(
[
{
severity: "Error",
location: { start: 0, end: 5 },
code: "SC1001",
message: "Syntax error, incorrect syntax near 'Crazy'.",
},
],
"ActivityId: d5424e10-51bd-46f7-9aec-7b40bed36f17",
);
const result = redactSyntaxErrorMessage(error) as { message: string };
const { outerParsed, innerErrors, activityIdPart } = parseRedactedResult(result);
expect(outerParsed.code).toBe("BadRequest");
expect(innerErrors.errors[0].message).toBe("__REDACTED__");
expect(activityIdPart).toContain("ActivityId: d5424e10-51bd-46f7-9aec-7b40bed36f17");
});
it("should redact SC2001 error message", () => {
const error = createNestedError(
[
{
severity: "Error",
location: { start: 0, end: 10 },
code: "SC2001",
message: "Some sensitive syntax error message.",
},
],
"ActivityId: abc123",
);
const result = redactSyntaxErrorMessage(error) as { message: string };
const { outerParsed, innerErrors, activityIdPart } = parseRedactedResult(result);
expect(outerParsed.code).toBe("BadRequest");
expect(innerErrors.errors[0].message).toBe("__REDACTED__");
expect(activityIdPart).toContain("ActivityId: abc123");
});
it("should redact multiple errors with SC1001 and SC2001 codes", () => {
const error = createNestedError(
[
{ severity: "Error", code: "SC1001", message: "First error" },
{ severity: "Error", code: "SC2001", message: "Second error" },
],
"ActivityId: xyz",
);
const result = redactSyntaxErrorMessage(error) as { message: string };
const { innerErrors } = parseRedactedResult(result);
expect(innerErrors.errors[0].message).toBe("__REDACTED__");
expect(innerErrors.errors[1].message).toBe("__REDACTED__");
});
it("should not redact errors with other codes", () => {
const error = createNestedError(
[{ severity: "Error", code: "SC9999", message: "This should not be redacted." }],
"ActivityId: test123",
);
const result = redactSyntaxErrorMessage(error);
expect(result).toBe(error); // Should return original error unchanged
});
it("should not modify non-BadRequest errors", () => {
const innerMessage = JSON.stringify({ errors: [{ code: "SC1001", message: "Should not be redacted" }] });
const error = {
message: JSON.stringify({ code: "NotFound", message: innerMessage }),
};
const result = redactSyntaxErrorMessage(error);
expect(result).toBe(error);
});
it("should handle errors without message property", () => {
const error = { code: "BadRequest" };
const result = redactSyntaxErrorMessage(error);
expect(result).toBe(error);
});
it("should handle non-object errors", () => {
const stringError = "Simple string error";
const nullError: null = null;
const undefinedError: undefined = undefined;
expect(redactSyntaxErrorMessage(stringError)).toBe(stringError);
expect(redactSyntaxErrorMessage(nullError)).toBe(nullError);
expect(redactSyntaxErrorMessage(undefinedError)).toBe(undefinedError);
});
it("should handle malformed JSON in message", () => {
const error = {
message: "not valid json",
};
const result = redactSyntaxErrorMessage(error);
expect(result).toBe(error);
});
it("should handle message without ActivityId suffix", () => {
const innerErrorsJson = JSON.stringify({
errors: [{ severity: "Error", code: "SC1001", message: "Syntax error near something." }],
});
const error = {
message: JSON.stringify({ code: "BadRequest", message: innerErrorsJson + "\r\n" }),
};
const result = redactSyntaxErrorMessage(error) as { message: string };
const { innerErrors } = parseRedactedResult(result);
expect(innerErrors.errors[0].message).toBe("__REDACTED__");
});
it("should preserve other error properties", () => {
const baseError = createNestedError([{ code: "SC1001", message: "Error" }], "ActivityId: test");
const error = {
...baseError,
statusCode: 400,
additionalInfo: "extra data",
};
const result = redactSyntaxErrorMessage(error) as {
message: string;
statusCode: number;
additionalInfo: string;
};
expect(result.statusCode).toBe(400);
expect(result.additionalInfo).toBe("extra data");
const { innerErrors } = parseRedactedResult(result);
expect(innerErrors.errors[0].message).toBe("__REDACTED__");
});
});

View File

@@ -4,51 +4,6 @@ import { getEntityName } from "../DocumentUtility";
import { handleError } from "../ErrorHandlingUtils"; import { handleError } from "../ErrorHandlingUtils";
import { MinimalQueryIterator, nextPage } from "../IteratorUtilities"; import { MinimalQueryIterator, nextPage } from "../IteratorUtilities";
// Redact sensitive information from BadRequest errors with specific codes
export const redactSyntaxErrorMessage = (error: unknown): unknown => {
const codesToRedact = ["SC1001", "SC2001"];
try {
// Handle error objects with a message property
if (error && typeof error === "object" && "message" in error) {
const errorObj = error as { code?: string; message?: string };
if (typeof errorObj.message === "string") {
// Parse the inner JSON from the message
const innerJson = JSON.parse(errorObj.message);
if (innerJson.code === "BadRequest" && typeof innerJson.message === "string") {
const [innerErrorsJson, activityIdPart] = innerJson.message.split("\r\n");
const innerErrorsObj = JSON.parse(innerErrorsJson);
if (Array.isArray(innerErrorsObj.errors)) {
let modified = false;
innerErrorsObj.errors = innerErrorsObj.errors.map((err: { code?: string; message?: string }) => {
if (err.code && codesToRedact.includes(err.code)) {
modified = true;
return { ...err, message: "__REDACTED__" };
}
return err;
});
if (modified) {
// Reconstruct the message with the redacted content
const redactedMessage = JSON.stringify(innerErrorsObj) + `\r\n${activityIdPart}`;
const redactedError = {
...error,
message: JSON.stringify({ ...innerJson, message: redactedMessage }),
body: undefined as unknown, // Clear body to avoid sensitive data
};
return redactedError;
}
}
}
}
}
} catch {
// If parsing fails, return the original error
}
return error;
};
export const queryDocumentsPage = async ( export const queryDocumentsPage = async (
resourceName: string, resourceName: string,
documentsIterator: MinimalQueryIterator, documentsIterator: MinimalQueryIterator,
@@ -63,12 +18,7 @@ export const queryDocumentsPage = async (
logConsoleInfo(`Successfully fetched ${itemCount} ${entityName} for container ${resourceName}`); logConsoleInfo(`Successfully fetched ${itemCount} ${entityName} for container ${resourceName}`);
return result; return result;
} catch (error) { } catch (error) {
// Redact sensitive information for telemetry while showing original in console handleError(error, "QueryDocumentsPage", `Failed to query ${entityName} for container ${resourceName}`);
const redactedError = redactSyntaxErrorMessage(error);
handleError(error, "QueryDocumentsPage", `Failed to query ${entityName} for container ${resourceName}`, {
redactedError: redactedError as Error,
});
throw error; throw error;
} finally { } finally {
clearMessage(); clearMessage();

View File

@@ -378,9 +378,11 @@ type PanelOpenOptions = {
export enum CommandBarButton { export enum CommandBarButton {
Save = "Save", Save = "Save",
Delete = "Delete",
Execute = "Execute", Execute = "Execute",
ExecuteQuery = "Execute Query", ExecuteQuery = "Execute Query",
UploadItem = "Upload Item", UploadItem = "Upload Item",
NewDocument = "New Document",
} }
/** Helper class that provides locator methods for DataExplorer components, on top of a Frame */ /** Helper class that provides locator methods for DataExplorer components, on top of a Frame */
@@ -478,7 +480,7 @@ export class DataExplorer {
return await this.waitForNode(`${databaseId}/${containerId}/Documents`); return await this.waitForNode(`${databaseId}/${containerId}/Documents`);
} }
async waitForCommandBarButton(label: string, timeout?: number): Promise<Locator> { async waitForCommandBarButton(label: CommandBarButton, timeout?: number): Promise<Locator> {
const commandBar = this.commandBarButton(label); const commandBar = this.commandBarButton(label);
await commandBar.waitFor({ state: "visible", timeout }); await commandBar.waitFor({ state: "visible", timeout });
return commandBar; return commandBar;
@@ -515,14 +517,14 @@ export class DataExplorer {
const containerNode = await this.waitForContainerNode(context.database.id, context.container.id); const containerNode = await this.waitForContainerNode(context.database.id, context.container.id);
await containerNode.expand(); await containerNode.expand();
// refresh tree to remove deleted database // // refresh tree to remove deleted database
const consoleMessages = await this.getNotificationConsoleMessages(); // const consoleMessages = await this.getNotificationConsoleMessages();
const refreshButton = this.frame.getByTestId("Sidebar/RefreshButton"); // const refreshButton = this.frame.getByTestId("Sidebar/RefreshButton");
await refreshButton.click(); // await refreshButton.click();
await expect(consoleMessages).toContainText("Successfully refreshed databases", { // await expect(consoleMessages).toContainText("Successfully refreshed databases", {
timeout: ONE_MINUTE_MS, // timeout: ONE_MINUTE_MS,
}); // });
await this.collapseNotificationConsole(); // await this.collapseNotificationConsole();
const scaleAndSettingsButton = this.frame.getByTestId( const scaleAndSettingsButton = this.frame.getByTestId(
`TreeNode:${context.database.id}/${context.container.id}/Scale & Settings`, `TreeNode:${context.database.id}/${context.container.id}/Scale & Settings`,

View File

@@ -1,7 +1,7 @@
import { expect, test } from "@playwright/test"; import { expect, test } from "@playwright/test";
import { setupCORSBypass } from "../CORSBypass"; import { setupCORSBypass } from "../CORSBypass";
import { DataExplorer, DocumentsTab, TestAccount } from "../fx"; import { CommandBarButton, DataExplorer, DocumentsTab, TestAccount } from "../fx";
import { retry, serializeMongoToJson, setPartitionKeys } from "../testData"; import { retry, serializeMongoToJson, setPartitionKeys } from "../testData";
import { documentTestCases } from "./testCases"; import { documentTestCases } from "./testCases";
@@ -26,6 +26,8 @@ for (const { name, databaseId, containerId, documents } of documentTestCases) {
await documentsTab.documentsFilter.waitFor(); await documentsTab.documentsFilter.waitFor();
await documentsTab.documentsListPane.waitFor(); await documentsTab.documentsListPane.waitFor();
await expect(documentsTab.resultsEditor.locator).toBeAttached({ timeout: 60 * 1000 }); await expect(documentsTab.resultsEditor.locator).toBeAttached({ timeout: 60 * 1000 });
await explorer.expandNotificationConsole();
}); });
test.afterEach(async ({ page }) => { test.afterEach(async ({ page }) => {
await page.unrouteAll({ behavior: "ignoreErrors" }); await page.unrouteAll({ behavior: "ignoreErrors" });
@@ -48,7 +50,7 @@ for (const { name, databaseId, containerId, documents } of documentTestCases) {
expect(resultData?._id).not.toBeNull(); expect(resultData?._id).not.toBeNull();
expect(resultData?._id).toEqual(docId); expect(resultData?._id).toEqual(docId);
}); });
test(`should be able to create and delete new document from ${docId}`, async () => { test(`should be able to create and delete new document from ${docId}`, async ({ page }) => {
const span = documentsTab.documentsListPane.getByText(docId, { exact: true }).nth(0); const span = documentsTab.documentsListPane.getByText(docId, { exact: true }).nth(0);
await span.waitFor(); await span.waitFor();
await expect(span).toBeVisible(); await expect(span).toBeVisible();
@@ -56,7 +58,7 @@ for (const { name, databaseId, containerId, documents } of documentTestCases) {
await span.click(); await span.click();
let newDocumentId; let newDocumentId;
await retry(async () => { await retry(async () => {
const newDocumentButton = await explorer.waitForCommandBarButton("New Document", 5000); const newDocumentButton = await explorer.waitForCommandBarButton(CommandBarButton.NewDocument, 5000);
await expect(newDocumentButton).toBeVisible(); await expect(newDocumentButton).toBeVisible();
await expect(newDocumentButton).toBeEnabled(); await expect(newDocumentButton).toBeEnabled();
await newDocumentButton.click(); await newDocumentButton.click();
@@ -71,7 +73,12 @@ for (const { name, databaseId, containerId, documents } of documentTestCases) {
}; };
await documentsTab.resultsEditor.setText(JSON.stringify(newDocument)); await documentsTab.resultsEditor.setText(JSON.stringify(newDocument));
const saveButton = await explorer.waitForCommandBarButton("Save", 5000); // Verify that the document text was set correctly
await expect
.poll(async () => await documentsTab.resultsEditor.text(), { timeout: 5000 })
.toEqual(JSON.stringify(newDocument));
const saveButton = await explorer.waitForCommandBarButton(CommandBarButton.Save, 5000);
await saveButton.click({ timeout: 5000 }); await saveButton.click({ timeout: 5000 });
await expect(saveButton).toBeHidden({ timeout: 5000 }); await expect(saveButton).toBeHidden({ timeout: 5000 });
}, 3); }, 3);
@@ -84,7 +91,7 @@ for (const { name, databaseId, containerId, documents } of documentTestCases) {
await newSpan.click(); await newSpan.click();
await expect(documentsTab.resultsEditor.locator).toBeAttached({ timeout: 60 * 1000 }); await expect(documentsTab.resultsEditor.locator).toBeAttached({ timeout: 60 * 1000 });
const deleteButton = await explorer.waitForCommandBarButton("Delete", 5000); const deleteButton = await explorer.waitForCommandBarButton(CommandBarButton.Delete, 5000);
await deleteButton.click(); await deleteButton.click();
const deleteDialogButton = await explorer.waitForDialogButton("Delete", 5000); const deleteDialogButton = await explorer.waitForDialogButton("Delete", 5000);

View File

@@ -1,258 +1,258 @@
/* eslint-disable @typescript-eslint/no-explicit-any */ // /* eslint-disable @typescript-eslint/no-explicit-any */
import { expect, Frame, Locator, Page, test } from "@playwright/test"; // import { expect, Frame, Locator, Page, test } from "@playwright/test";
import { truncateName } from "../../../src/Explorer/ContainerCopy/CopyJobUtils"; // import { truncateName } from "../../../src/Explorer/ContainerCopy/CopyJobUtils";
import { // import {
ContainerCopy, // ContainerCopy,
getAccountName, // getAccountName,
getDropdownItemByNameOrPosition, // getDropdownItemByNameOrPosition,
interceptAndInspectApiRequest, // interceptAndInspectApiRequest,
TestAccount, // TestAccount,
waitForApiResponse, // waitForApiResponse,
} from "../../fx"; // } from "../../fx";
import { createMultipleTestContainers } from "../../testData"; // import { createMultipleTestContainers } from "../../testData";
test.describe("Container Copy - Offline Migration", () => { // test.describe("Container Copy - Offline Migration", () => {
let page: Page; // let page: Page;
let wrapper: Locator; // let wrapper: Locator;
let panel: Locator; // let panel: Locator;
let frame: Frame; // let frame: Frame;
let expectedJobName: string; // let expectedJobName: string;
let targetAccountName: string; // let targetAccountName: string;
let expectedSubscriptionName: string; // let expectedSubscriptionName: string;
let expectedCopyJobNameInitial: string; // let expectedCopyJobNameInitial: string;
test.beforeEach("Setup for offline migration test", async ({ browser }) => { // test.beforeEach("Setup for offline migration test", async ({ browser }) => {
await createMultipleTestContainers({ accountType: TestAccount.SQLContainerCopyOnly, containerCount: 2 }); // await createMultipleTestContainers({ accountType: TestAccount.SQLContainerCopyOnly, containerCount: 2 });
page = await browser.newPage(); // page = await browser.newPage();
({ wrapper, frame } = await ContainerCopy.open(page, TestAccount.SQLContainerCopyOnly)); // ({ wrapper, frame } = await ContainerCopy.open(page, TestAccount.SQLContainerCopyOnly));
expectedJobName = `offline_test_job_${Date.now()}`; // expectedJobName = `offline_test_job_${Date.now()}`;
targetAccountName = getAccountName(TestAccount.SQLContainerCopyOnly); // targetAccountName = getAccountName(TestAccount.SQLContainerCopyOnly);
}); // });
test.afterEach("Cleanup after offline migration test", async () => { // test.afterEach("Cleanup after offline migration test", async () => {
await page.unroute(/.*/, (route) => route.continue()); // await page.unroute(/.*/, (route) => route.continue());
await page.close(); // await page.close();
}); // });
test("Successfully create and manage offline migration copy job", async () => { // test("Successfully create and manage offline migration copy job", async () => {
expect(wrapper).not.toBeNull(); // expect(wrapper).not.toBeNull();
await wrapper.locator(".commandBarContainer").waitFor({ state: "visible" }); // await wrapper.locator(".commandBarContainer").waitFor({ state: "visible" });
// Open Create Copy Job panel // // Open Create Copy Job panel
const createCopyJobButton = wrapper.getByTestId("CommandBar/Button:Create Copy Job"); // const createCopyJobButton = wrapper.getByTestId("CommandBar/Button:Create Copy Job");
await expect(createCopyJobButton).toBeVisible(); // await expect(createCopyJobButton).toBeVisible();
await createCopyJobButton.click(); // await createCopyJobButton.click();
panel = frame.getByTestId("Panel:Create copy job"); // panel = frame.getByTestId("Panel:Create copy job");
await expect(panel).toBeVisible(); // await expect(panel).toBeVisible();
// Reduced wait time for better performance // // Reduced wait time for better performance
await page.waitForTimeout(2000); // await page.waitForTimeout(2000);
// Setup subscription and account // // Setup subscription and account
const subscriptionDropdown = panel.getByTestId("subscription-dropdown"); // const subscriptionDropdown = panel.getByTestId("subscription-dropdown");
const expectedAccountName = targetAccountName; // const expectedAccountName = targetAccountName;
expectedSubscriptionName = await subscriptionDropdown.locator("span.ms-Dropdown-title").innerText(); // expectedSubscriptionName = await subscriptionDropdown.locator("span.ms-Dropdown-title").innerText();
await subscriptionDropdown.click(); // await subscriptionDropdown.click();
const subscriptionItem = await getDropdownItemByNameOrPosition( // const subscriptionItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ name: expectedSubscriptionName }, // { name: expectedSubscriptionName },
{ ariaLabel: "Subscription" }, // { ariaLabel: "Subscription" },
); // );
await subscriptionItem.click(); // await subscriptionItem.click();
// Select account // // Select account
const accountDropdown = panel.getByTestId("account-dropdown"); // const accountDropdown = panel.getByTestId("account-dropdown");
await expect(accountDropdown).toHaveText(new RegExp(expectedAccountName)); // await expect(accountDropdown).toHaveText(new RegExp(expectedAccountName));
await accountDropdown.click(); // await accountDropdown.click();
const accountItem = await getDropdownItemByNameOrPosition( // const accountItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ name: expectedAccountName }, // { name: expectedAccountName },
{ ariaLabel: "Account" }, // { ariaLabel: "Account" },
); // );
await accountItem.click(); // await accountItem.click();
// Test offline migration mode toggle functionality // // Test offline migration mode toggle functionality
const migrationTypeContainer = panel.getByTestId("migration-type"); // const migrationTypeContainer = panel.getByTestId("migration-type");
// First test online mode (should show permissions screen) // // First test online mode (should show permissions screen)
const onlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Online mode/i }); // const onlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Online mode/i });
await onlineCopyRadioButton.click({ force: true }); // await onlineCopyRadioButton.click({ force: true });
await expect(migrationTypeContainer.getByTestId("migration-type-description-online")).toBeVisible(); // await expect(migrationTypeContainer.getByTestId("migration-type-description-online")).toBeVisible();
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
await expect(panel.getByTestId("Panel:AssignPermissionsContainer")).toBeVisible(); // await expect(panel.getByTestId("Panel:AssignPermissionsContainer")).toBeVisible();
await expect(panel.getByText("Online container copy", { exact: true })).toBeVisible(); // await expect(panel.getByText("Online container copy", { exact: true })).toBeVisible();
// Go back and switch to offline mode // // Go back and switch to offline mode
await panel.getByRole("button", { name: "Previous" }).click(); // await panel.getByRole("button", { name: "Previous" }).click();
const offlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Offline mode/i }); // const offlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Offline mode/i });
await offlineCopyRadioButton.click({ force: true }); // await offlineCopyRadioButton.click({ force: true });
await expect(migrationTypeContainer.getByTestId("migration-type-description-offline")).toBeVisible(); // await expect(migrationTypeContainer.getByTestId("migration-type-description-offline")).toBeVisible();
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Verify we skip permissions screen in offline mode // // Verify we skip permissions screen in offline mode
await expect(panel.getByTestId("Panel:SelectSourceAndTargetContainers")).toBeVisible(); // await expect(panel.getByTestId("Panel:SelectSourceAndTargetContainers")).toBeVisible();
await expect(panel.getByTestId("Panel:AssignPermissionsContainer")).not.toBeVisible(); // await expect(panel.getByTestId("Panel:AssignPermissionsContainer")).not.toBeVisible();
// Test source and target container selection with validation // // Test source and target container selection with validation
const sourceContainerDropdown = panel.getByTestId("source-containerDropdown"); // const sourceContainerDropdown = panel.getByTestId("source-containerDropdown");
expect(sourceContainerDropdown).toBeVisible(); // expect(sourceContainerDropdown).toBeVisible();
await expect(sourceContainerDropdown).toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(sourceContainerDropdown).toHaveClass(/(^|\s)is-disabled(\s|$)/);
// Select source database first (containers are disabled until database is selected) // // Select source database first (containers are disabled until database is selected)
const sourceDatabaseDropdown = panel.getByTestId("source-databaseDropdown"); // const sourceDatabaseDropdown = panel.getByTestId("source-databaseDropdown");
await sourceDatabaseDropdown.click(); // await sourceDatabaseDropdown.click();
const sourceDbDropdownItem = await getDropdownItemByNameOrPosition( // const sourceDbDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Database" }, // { ariaLabel: "Database" },
); // );
await sourceDbDropdownItem.click(); // await sourceDbDropdownItem.click();
// Now container dropdown should be enabled // // Now container dropdown should be enabled
await expect(sourceContainerDropdown).not.toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(sourceContainerDropdown).not.toHaveClass(/(^|\s)is-disabled(\s|$)/);
await sourceContainerDropdown.click(); // await sourceContainerDropdown.click();
const sourceContainerDropdownItem = await getDropdownItemByNameOrPosition( // const sourceContainerDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Container" }, // { ariaLabel: "Container" },
); // );
await sourceContainerDropdownItem.click(); // await sourceContainerDropdownItem.click();
// Test target container selection // // Test target container selection
const targetContainerDropdown = panel.getByTestId("target-containerDropdown"); // const targetContainerDropdown = panel.getByTestId("target-containerDropdown");
expect(targetContainerDropdown).toBeVisible(); // expect(targetContainerDropdown).toBeVisible();
await expect(targetContainerDropdown).toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(targetContainerDropdown).toHaveClass(/(^|\s)is-disabled(\s|$)/);
const targetDatabaseDropdown = panel.getByTestId("target-databaseDropdown"); // const targetDatabaseDropdown = panel.getByTestId("target-databaseDropdown");
await targetDatabaseDropdown.click(); // await targetDatabaseDropdown.click();
const targetDbDropdownItem = await getDropdownItemByNameOrPosition( // const targetDbDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Database" }, // { ariaLabel: "Database" },
); // );
await targetDbDropdownItem.click(); // await targetDbDropdownItem.click();
await expect(targetContainerDropdown).not.toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(targetContainerDropdown).not.toHaveClass(/(^|\s)is-disabled(\s|$)/);
await targetContainerDropdown.click(); // await targetContainerDropdown.click();
// First try selecting the same container (should show error) // // First try selecting the same container (should show error)
const targetContainerDropdownItem1 = await getDropdownItemByNameOrPosition( // const targetContainerDropdownItem1 = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Container" }, // { ariaLabel: "Container" },
); // );
await targetContainerDropdownItem1.click(); // await targetContainerDropdownItem1.click();
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Verify validation error for same source and target containers // // Verify validation error for same source and target containers
const errorContainer = panel.getByTestId("Panel:ErrorContainer"); // const errorContainer = panel.getByTestId("Panel:ErrorContainer");
await expect(errorContainer).toBeVisible(); // await expect(errorContainer).toBeVisible();
await expect(errorContainer).toHaveText(/Source and destination containers cannot be the same/i); // await expect(errorContainer).toHaveText(/Source and destination containers cannot be the same/i);
// Select different target container // // Select different target container
await targetContainerDropdown.click(); // await targetContainerDropdown.click();
const targetContainerDropdownItem2 = await getDropdownItemByNameOrPosition( // const targetContainerDropdownItem2 = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 1 }, // { position: 1 },
{ ariaLabel: "Container" }, // { ariaLabel: "Container" },
); // );
await targetContainerDropdownItem2.click(); // await targetContainerDropdownItem2.click();
// Generate expected job name based on selections // // Generate expected job name based on selections
const selectedSourceDatabase = await sourceDatabaseDropdown.innerText(); // const selectedSourceDatabase = await sourceDatabaseDropdown.innerText();
const selectedSourceContainer = await sourceContainerDropdown.innerText(); // const selectedSourceContainer = await sourceContainerDropdown.innerText();
const selectedTargetDatabase = await targetDatabaseDropdown.innerText(); // const selectedTargetDatabase = await targetDatabaseDropdown.innerText();
const selectedTargetContainer = await targetContainerDropdown.innerText(); // const selectedTargetContainer = await targetContainerDropdown.innerText();
expectedCopyJobNameInitial = `${truncateName(selectedSourceDatabase)}.${truncateName( // expectedCopyJobNameInitial = `${truncateName(selectedSourceDatabase)}.${truncateName(
selectedSourceContainer, // selectedSourceContainer,
)}_${truncateName(selectedTargetDatabase)}.${truncateName(selectedTargetContainer)}`; // )}_${truncateName(selectedTargetDatabase)}.${truncateName(selectedTargetContainer)}`;
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Error should disappear and preview should be visible // // Error should disappear and preview should be visible
await expect(errorContainer).not.toBeVisible(); // await expect(errorContainer).not.toBeVisible();
await expect(panel.getByTestId("Panel:PreviewCopyJob")).toBeVisible(); // await expect(panel.getByTestId("Panel:PreviewCopyJob")).toBeVisible();
// Verify job preview details // // Verify job preview details
const previewContainer = panel.getByTestId("Panel:PreviewCopyJob"); // const previewContainer = panel.getByTestId("Panel:PreviewCopyJob");
await expect(previewContainer).toBeVisible(); // await expect(previewContainer).toBeVisible();
await expect(previewContainer.getByTestId("source-subscription-name")).toHaveText(expectedSubscriptionName); // await expect(previewContainer.getByTestId("source-subscription-name")).toHaveText(expectedSubscriptionName);
await expect(previewContainer.getByTestId("source-account-name")).toHaveText(expectedAccountName); // await expect(previewContainer.getByTestId("source-account-name")).toHaveText(expectedAccountName);
const jobNameInput = previewContainer.getByTestId("job-name-textfield"); // const jobNameInput = previewContainer.getByTestId("job-name-textfield");
await expect(jobNameInput).toHaveValue(new RegExp(expectedCopyJobNameInitial)); // await expect(jobNameInput).toHaveValue(new RegExp(expectedCopyJobNameInitial));
const primaryBtn = panel.getByRole("button", { name: "Copy", exact: true }); // const primaryBtn = panel.getByRole("button", { name: "Copy", exact: true });
await expect(primaryBtn).not.toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(primaryBtn).not.toHaveClass(/(^|\s)is-disabled(\s|$)/);
// Test invalid job name validation (spaces not allowed) // // Test invalid job name validation (spaces not allowed)
await jobNameInput.fill("test job name"); // await jobNameInput.fill("test job name");
await expect(primaryBtn).toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(primaryBtn).toHaveClass(/(^|\s)is-disabled(\s|$)/);
// Test duplicate job name error handling // // Test duplicate job name error handling
const duplicateJobName = "test-job-name-1"; // const duplicateJobName = "test-job-name-1";
await jobNameInput.fill(duplicateJobName); // await jobNameInput.fill(duplicateJobName);
const copyButton = panel.getByRole("button", { name: "Copy", exact: true }); // const copyButton = panel.getByRole("button", { name: "Copy", exact: true });
const expectedErrorMessage = `Duplicate job name '${duplicateJobName}'`; // const expectedErrorMessage = `Duplicate job name '${duplicateJobName}'`;
await interceptAndInspectApiRequest( // await interceptAndInspectApiRequest(
page, // page,
`${expectedAccountName}/dataTransferJobs/${duplicateJobName}`, // `${expectedAccountName}/dataTransferJobs/${duplicateJobName}`,
"PUT", // "PUT",
new Error(expectedErrorMessage), // new Error(expectedErrorMessage),
(url?: string) => url?.includes(duplicateJobName) ?? false, // (url?: string) => url?.includes(duplicateJobName) ?? false,
); // );
let errorThrown = false; // let errorThrown = false;
try { // try {
await copyButton.click(); // await copyButton.click();
await page.waitForTimeout(2000); // await page.waitForTimeout(2000);
} catch (error: any) { // } catch (error: any) {
errorThrown = true; // errorThrown = true;
expect(error.message).toContain("not allowed"); // expect(error.message).toContain("not allowed");
} // }
if (!errorThrown) { // if (!errorThrown) {
const errorContainer = panel.getByTestId("Panel:ErrorContainer"); // const errorContainer = panel.getByTestId("Panel:ErrorContainer");
await expect(errorContainer).toBeVisible(); // await expect(errorContainer).toBeVisible();
await expect(errorContainer).toHaveText(new RegExp(expectedErrorMessage, "i")); // await expect(errorContainer).toHaveText(new RegExp(expectedErrorMessage, "i"));
} // }
await expect(panel).toBeVisible(); // await expect(panel).toBeVisible();
// Test successful job creation with valid job name // // Test successful job creation with valid job name
const validJobName = expectedJobName; // const validJobName = expectedJobName;
const copyJobCreationPromise = waitForApiResponse( // const copyJobCreationPromise = waitForApiResponse(
page, // page,
`${expectedAccountName}/dataTransferJobs/${validJobName}`, // `${expectedAccountName}/dataTransferJobs/${validJobName}`,
"PUT", // "PUT",
); // );
await jobNameInput.fill(validJobName); // await jobNameInput.fill(validJobName);
await expect(copyButton).not.toHaveClass(/(^|\s)is-disabled(\s|$)/); // await expect(copyButton).not.toHaveClass(/(^|\s)is-disabled(\s|$)/);
await copyButton.click(); // await copyButton.click();
const response = await copyJobCreationPromise; // const response = await copyJobCreationPromise;
expect(response.ok()).toBe(true); // expect(response.ok()).toBe(true);
// Verify panel closes and job appears in the list // // Verify panel closes and job appears in the list
await expect(panel).not.toBeVisible({ timeout: 5000 }); // await expect(panel).not.toBeVisible({ timeout: 5000 });
const jobsListContainer = wrapper.locator(".CopyJobListContainer .ms-DetailsList-contentWrapper .ms-List-page"); // const jobsListContainer = wrapper.locator(".CopyJobListContainer .ms-DetailsList-contentWrapper .ms-List-page");
await jobsListContainer.waitFor({ state: "visible", timeout: 5000 }); // await jobsListContainer.waitFor({ state: "visible", timeout: 5000 });
const jobItem = jobsListContainer.getByText(validJobName); // const jobItem = jobsListContainer.getByText(validJobName);
await jobItem.waitFor({ state: "visible", timeout: 5000 }); // await jobItem.waitFor({ state: "visible", timeout: 5000 });
await expect(jobItem).toBeVisible(); // await expect(jobItem).toBeVisible();
}); // });
}); // });

View File

@@ -1,185 +1,185 @@
/* eslint-disable @typescript-eslint/no-explicit-any */ // /* eslint-disable @typescript-eslint/no-explicit-any */
import { expect, Frame, Locator, Page, test } from "@playwright/test"; // import { expect, Frame, Locator, Page, test } from "@playwright/test";
import { // import {
ContainerCopy, // ContainerCopy,
getAccountName, // getAccountName,
getDropdownItemByNameOrPosition, // getDropdownItemByNameOrPosition,
TestAccount, // TestAccount,
waitForApiResponse, // waitForApiResponse,
} from "../../fx"; // } from "../../fx";
import { createMultipleTestContainers } from "../../testData"; // import { createMultipleTestContainers } from "../../testData";
test.describe("Container Copy - Online Migration", () => { // test.describe("Container Copy - Online Migration", () => {
let page: Page; // let page: Page;
let wrapper: Locator; // let wrapper: Locator;
let panel: Locator; // let panel: Locator;
let frame: Frame; // let frame: Frame;
let targetAccountName: string; // let targetAccountName: string;
test.beforeEach("Setup for online migration test", async ({ browser }) => { // test.beforeEach("Setup for online migration test", async ({ browser }) => {
await createMultipleTestContainers({ accountType: TestAccount.SQLContainerCopyOnly, containerCount: 2 }); // await createMultipleTestContainers({ accountType: TestAccount.SQLContainerCopyOnly, containerCount: 2 });
page = await browser.newPage(); // page = await browser.newPage();
({ wrapper, frame } = await ContainerCopy.open(page, TestAccount.SQLContainerCopyOnly)); // ({ wrapper, frame } = await ContainerCopy.open(page, TestAccount.SQLContainerCopyOnly));
targetAccountName = getAccountName(TestAccount.SQLContainerCopyOnly); // targetAccountName = getAccountName(TestAccount.SQLContainerCopyOnly);
}); // });
test.afterEach("Cleanup after online migration test", async () => { // test.afterEach("Cleanup after online migration test", async () => {
await page.unroute(/.*/, (route) => route.continue()); // await page.unroute(/.*/, (route) => route.continue());
await page.close(); // await page.close();
}); // });
test("Successfully create and manage online migration copy job", async () => { // test("Successfully create and manage online migration copy job", async () => {
expect(wrapper).not.toBeNull(); // expect(wrapper).not.toBeNull();
await wrapper.locator(".commandBarContainer").waitFor({ state: "visible" }); // await wrapper.locator(".commandBarContainer").waitFor({ state: "visible" });
// Open Create Copy Job panel // // Open Create Copy Job panel
const createCopyJobButton = wrapper.getByTestId("CommandBar/Button:Create Copy Job"); // const createCopyJobButton = wrapper.getByTestId("CommandBar/Button:Create Copy Job");
await expect(createCopyJobButton).toBeVisible(); // await expect(createCopyJobButton).toBeVisible();
await createCopyJobButton.click(); // await createCopyJobButton.click();
panel = frame.getByTestId("Panel:Create copy job"); // panel = frame.getByTestId("Panel:Create copy job");
await expect(panel).toBeVisible(); // await expect(panel).toBeVisible();
// Reduced wait time for better performance // // Reduced wait time for better performance
await page.waitForTimeout(1000); // await page.waitForTimeout(1000);
// Enable online migration mode // // Enable online migration mode
const migrationTypeContainer = panel.getByTestId("migration-type"); // const migrationTypeContainer = panel.getByTestId("migration-type");
const onlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Online mode/i }); // const onlineCopyRadioButton = migrationTypeContainer.getByRole("radio", { name: /Online mode/i });
await onlineCopyRadioButton.click({ force: true }); // await onlineCopyRadioButton.click({ force: true });
await expect(migrationTypeContainer.getByTestId("migration-type-description-online")).toBeVisible(); // await expect(migrationTypeContainer.getByTestId("migration-type-description-online")).toBeVisible();
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Verify permissions screen is shown for online migration // // Verify permissions screen is shown for online migration
const permissionScreen = panel.getByTestId("Panel:AssignPermissionsContainer"); // const permissionScreen = panel.getByTestId("Panel:AssignPermissionsContainer");
await expect(permissionScreen).toBeVisible(); // await expect(permissionScreen).toBeVisible();
await expect(permissionScreen.getByText("Online container copy", { exact: true })).toBeVisible(); // await expect(permissionScreen.getByText("Online container copy", { exact: true })).toBeVisible();
// Skip permissions setup and proceed to container selection // // Skip permissions setup and proceed to container selection
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Configure source and target containers for online migration // // Configure source and target containers for online migration
const sourceDatabaseDropdown = panel.getByTestId("source-databaseDropdown"); // const sourceDatabaseDropdown = panel.getByTestId("source-databaseDropdown");
await sourceDatabaseDropdown.click(); // await sourceDatabaseDropdown.click();
const sourceDbDropdownItem = await getDropdownItemByNameOrPosition( // const sourceDbDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Database" }, // { ariaLabel: "Database" },
); // );
await sourceDbDropdownItem.click(); // await sourceDbDropdownItem.click();
const sourceContainerDropdown = panel.getByTestId("source-containerDropdown"); // const sourceContainerDropdown = panel.getByTestId("source-containerDropdown");
await sourceContainerDropdown.click(); // await sourceContainerDropdown.click();
const sourceContainerDropdownItem = await getDropdownItemByNameOrPosition( // const sourceContainerDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Container" }, // { ariaLabel: "Container" },
); // );
await sourceContainerDropdownItem.click(); // await sourceContainerDropdownItem.click();
const targetDatabaseDropdown = panel.getByTestId("target-databaseDropdown"); // const targetDatabaseDropdown = panel.getByTestId("target-databaseDropdown");
await targetDatabaseDropdown.click(); // await targetDatabaseDropdown.click();
const targetDbDropdownItem = await getDropdownItemByNameOrPosition( // const targetDbDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 0 }, // { position: 0 },
{ ariaLabel: "Database" }, // { ariaLabel: "Database" },
); // );
await targetDbDropdownItem.click(); // await targetDbDropdownItem.click();
const targetContainerDropdown = panel.getByTestId("target-containerDropdown"); // const targetContainerDropdown = panel.getByTestId("target-containerDropdown");
await targetContainerDropdown.click(); // await targetContainerDropdown.click();
const targetContainerDropdownItem = await getDropdownItemByNameOrPosition( // const targetContainerDropdownItem = await getDropdownItemByNameOrPosition(
frame, // frame,
{ position: 1 }, // { position: 1 },
{ ariaLabel: "Container" }, // { ariaLabel: "Container" },
); // );
await targetContainerDropdownItem.click(); // await targetContainerDropdownItem.click();
await panel.getByRole("button", { name: "Next" }).click(); // await panel.getByRole("button", { name: "Next" }).click();
// Verify job preview and create the online migration job // // Verify job preview and create the online migration job
const previewContainer = panel.getByTestId("Panel:PreviewCopyJob"); // const previewContainer = panel.getByTestId("Panel:PreviewCopyJob");
await expect(previewContainer.getByTestId("source-account-name")).toHaveText(targetAccountName); // await expect(previewContainer.getByTestId("source-account-name")).toHaveText(targetAccountName);
const jobNameInput = previewContainer.getByTestId("job-name-textfield"); // const jobNameInput = previewContainer.getByTestId("job-name-textfield");
const onlineMigrationJobName = await jobNameInput.inputValue(); // const onlineMigrationJobName = await jobNameInput.inputValue();
const copyButton = panel.getByRole("button", { name: "Copy", exact: true }); // const copyButton = panel.getByRole("button", { name: "Copy", exact: true });
const copyJobCreationPromise = waitForApiResponse( // const copyJobCreationPromise = waitForApiResponse(
page, // page,
`${targetAccountName}/dataTransferJobs/${onlineMigrationJobName}`, // `${targetAccountName}/dataTransferJobs/${onlineMigrationJobName}`,
"PUT", // "PUT",
); // );
await copyButton.click(); // await copyButton.click();
await page.waitForTimeout(1000); // Reduced wait time // await page.waitForTimeout(1000); // Reduced wait time
const response = await copyJobCreationPromise; // const response = await copyJobCreationPromise;
expect(response.ok()).toBe(true); // expect(response.ok()).toBe(true);
// Verify panel closes and job appears in the list // // Verify panel closes and job appears in the list
await expect(panel).not.toBeVisible({ timeout: 5000 }); // await expect(panel).not.toBeVisible({ timeout: 5000 });
const jobsListContainer = wrapper.locator(".CopyJobListContainer .ms-DetailsList-contentWrapper .ms-List-page"); // const jobsListContainer = wrapper.locator(".CopyJobListContainer .ms-DetailsList-contentWrapper .ms-List-page");
await jobsListContainer.waitFor({ state: "visible", timeout: 5000 }); // await jobsListContainer.waitFor({ state: "visible", timeout: 5000 });
let jobRow, statusCell, actionMenuButton; // let jobRow, statusCell, actionMenuButton;
jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName }); // jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName });
statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']"); // statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']");
await jobRow.waitFor({ state: "visible", timeout: 5000 }); // await jobRow.waitFor({ state: "visible", timeout: 5000 });
// Verify job status changes to queued state // // Verify job status changes to queued state
await expect(statusCell).toContainText(/running|queued|pending/i, { timeout: 5000 }); // await expect(statusCell).toContainText(/running|queued|pending/i, { timeout: 5000 });
// Test job lifecycle management through action menu // // Test job lifecycle management through action menu
actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`); // actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`);
await actionMenuButton.click(); // await actionMenuButton.click();
// Test pause functionality // // Test pause functionality
const pauseAction = frame.locator(".ms-ContextualMenu-list button:has-text('Pause')"); // const pauseAction = frame.locator(".ms-ContextualMenu-list button:has-text('Pause')");
await pauseAction.click(); // await pauseAction.click();
const pauseResponse = await waitForApiResponse( // const pauseResponse = await waitForApiResponse(
page, // page,
`${targetAccountName}/dataTransferJobs/${onlineMigrationJobName}/pause`, // `${targetAccountName}/dataTransferJobs/${onlineMigrationJobName}/pause`,
"POST", // "POST",
); // );
expect(pauseResponse.ok()).toBe(true); // expect(pauseResponse.ok()).toBe(true);
// Verify job status changes to paused // // Verify job status changes to paused
jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName }); // jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName });
await jobRow.waitFor({ state: "visible", timeout: 5000 }); // await jobRow.waitFor({ state: "visible", timeout: 5000 });
statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']"); // statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']");
await expect(statusCell).toContainText(/paused/i, { timeout: 5000 }); // await expect(statusCell).toContainText(/paused/i, { timeout: 5000 });
await page.waitForTimeout(1000); // await page.waitForTimeout(1000);
// Test cancel job functionality // // Test cancel job functionality
actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`); // actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`);
await actionMenuButton.click(); // await actionMenuButton.click();
await frame.locator(".ms-ContextualMenu-list button:has-text('Cancel')").click(); // await frame.locator(".ms-ContextualMenu-list button:has-text('Cancel')").click();
// Verify cancellation confirmation dialog // // Verify cancellation confirmation dialog
await expect(frame.locator(".ms-Dialog-main")).toBeVisible({ timeout: 2000 }); // await expect(frame.locator(".ms-Dialog-main")).toBeVisible({ timeout: 2000 });
await expect(frame.locator(".ms-Dialog-main")).toContainText(onlineMigrationJobName); // await expect(frame.locator(".ms-Dialog-main")).toContainText(onlineMigrationJobName);
const cancelDialogButton = frame.locator(".ms-Dialog-main").getByTestId("DialogButton:Cancel"); // const cancelDialogButton = frame.locator(".ms-Dialog-main").getByTestId("DialogButton:Cancel");
await expect(cancelDialogButton).toBeVisible(); // await expect(cancelDialogButton).toBeVisible();
await cancelDialogButton.click(); // await cancelDialogButton.click();
await expect(frame.locator(".ms-Dialog-main")).not.toBeVisible(); // await expect(frame.locator(".ms-Dialog-main")).not.toBeVisible();
actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`); // actionMenuButton = wrapper.getByTestId(`CopyJobActionMenu/Button:${onlineMigrationJobName}`);
await actionMenuButton.click(); // await actionMenuButton.click();
await frame.locator(".ms-ContextualMenu-list button:has-text('Cancel')").click(); // await frame.locator(".ms-ContextualMenu-list button:has-text('Cancel')").click();
const confirmDialogButton = frame.locator(".ms-Dialog-main").getByTestId("DialogButton:Confirm"); // const confirmDialogButton = frame.locator(".ms-Dialog-main").getByTestId("DialogButton:Confirm");
await expect(confirmDialogButton).toBeVisible(); // await expect(confirmDialogButton).toBeVisible();
await confirmDialogButton.click(); // await confirmDialogButton.click();
// Verify final job status is cancelled // // Verify final job status is cancelled
jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName }); // jobRow = jobsListContainer.locator(".ms-DetailsRow", { hasText: onlineMigrationJobName });
statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']"); // statusCell = jobRow.locator("[data-automationid='DetailsRowCell'][data-automation-key='CopyJobStatus']");
await expect(statusCell).toContainText(/cancelled/i, { timeout: 5000 }); // await expect(statusCell).toContainText(/cancelled/i, { timeout: 5000 });
}); // });
}); // });

View File

@@ -136,9 +136,7 @@ test.describe.serial("Upload Item", () => {
if (existsSync(uploadDocumentDirPath)) { if (existsSync(uploadDocumentDirPath)) {
rmdirSync(uploadDocumentDirPath); rmdirSync(uploadDocumentDirPath);
} }
if (!process.env.CI) { await context?.dispose();
await context?.dispose();
}
}); });
test.afterEach("Close Upload Items panel if still open", async () => { test.afterEach("Close Upload Items panel if still open", async () => {

View File

@@ -30,12 +30,9 @@ test.beforeEach("Open new query tab", async ({ page }) => {
await explorer.frame.getByTestId("NotificationConsole/Contents").waitFor(); await explorer.frame.getByTestId("NotificationConsole/Contents").waitFor();
}); });
// Delete database only if not running in CI test.afterAll("Delete Test Database", async () => {
if (!process.env.CI) { await context?.dispose();
test.afterAll("Delete Test Database", async () => { });
await context?.dispose();
});
}
test("Query results", async () => { test("Query results", async () => {
// Run the query and verify the results // Run the query and verify the results

View File

@@ -23,12 +23,9 @@ test.describe("Change Partition Key", () => {
await PartitionKeyTab.click(); await PartitionKeyTab.click();
}); });
// Delete database only if not running in CI test.afterEach("Delete Test Database", async () => {
if (!process.env.CI) { await context?.dispose();
test.afterEach("Delete Test Database", async () => { });
await context?.dispose();
});
}
test("Change partition key path", async ({ page }) => { test("Change partition key path", async ({ page }) => {
await expect(explorer.frame.getByText("/partitionKey")).toBeVisible(); await expect(explorer.frame.getByText("/partitionKey")).toBeVisible();

View File

@@ -118,7 +118,5 @@ async function openScaleTab(browser: Browser): Promise<SetupResult> {
} }
async function cleanup({ context }: Partial<SetupResult>) { async function cleanup({ context }: Partial<SetupResult>) {
if (!process.env.CI) { await context?.dispose();
await context?.dispose();
}
} }

View File

@@ -17,12 +17,9 @@ test.describe("Settings under Scale & Settings", () => {
await settingsTab.click(); await settingsTab.click();
}); });
// Delete database only if not running in CI test.afterAll("Delete Test Database", async () => {
if (!process.env.CI) { await context?.dispose();
test.afterAll("Delete Test Database", async () => { });
await context?.dispose();
});
}
test("Update TTL to On (no default)", async () => { test("Update TTL to On (no default)", async () => {
const ttlOnNoDefaultRadioButton = explorer.frame.getByRole("radio", { name: "ttl-on-no-default-option" }); const ttlOnNoDefaultRadioButton = explorer.frame.getByRole("radio", { name: "ttl-on-no-default-option" });

View File

@@ -43,7 +43,7 @@ test.describe("Stored Procedures", () => {
); );
// Execute stored procedure // Execute stored procedure
const executeButton = explorer.commandBarButton(CommandBarButton.Execute); const executeButton = explorer.commandBarButton(CommandBarButton.Execute).first();
await executeButton.click(); await executeButton.click();
const executeSidePanelButton = explorer.frame.getByTestId("Panel/OkButton"); const executeSidePanelButton = explorer.frame.getByTestId("Panel/OkButton");
await executeSidePanelButton.click(); await executeSidePanelButton.click();

View File

@@ -26,11 +26,9 @@ test.describe("Triggers", () => {
explorer = await DataExplorer.open(page, TestAccount.SQL); explorer = await DataExplorer.open(page, TestAccount.SQL);
}); });
if (!process.env.CI) { test.afterAll("Delete Test Database", async () => {
test.afterAll("Delete Test Database", async () => { await context?.dispose();
await context?.dispose(); });
});
}
test("Add and delete trigger", async ({ page }, testInfo) => { test("Add and delete trigger", async ({ page }, testInfo) => {
// Open container context menu and click New Trigger // Open container context menu and click New Trigger

View File

@@ -19,11 +19,9 @@ test.describe("User Defined Functions", () => {
explorer = await DataExplorer.open(page, TestAccount.SQL); explorer = await DataExplorer.open(page, TestAccount.SQL);
}); });
if (!process.env.CI) { test.afterAll("Delete Test Database", async () => {
test.afterAll("Delete Test Database", async () => { await context?.dispose();
await context?.dispose(); });
});
}
test("Add, execute, and delete user defined function", async ({ page }, testInfo) => { test("Add, execute, and delete user defined function", async ({ page }, testInfo) => {
// Open container context menu and click New UDF // Open container context menu and click New UDF