resolve_eslint_ReadOnlyNodePropertiesComponent

.eslintignore

@@ -2,8 +2,6 @@
 src/**/__mocks__/**/*
 dist/
 Contracts/
-src/Api/Apis.ts
-src/AuthType.ts
 src/Bindings/BindingHandlersRegisterer.ts
 src/Bindings/ReactBindingHandler.ts
 src/Common/Constants.ts
@@ -37,7 +35,6 @@ src/Definitions/svg.d.ts
 src/Explorer/ComponentRegisterer.test.ts
 src/Explorer/ComponentRegisterer.ts
 src/Explorer/Controls/DiffEditor/DiffEditorComponent.ts
-
 src/Explorer/Controls/Editor/EditorComponent.ts
 src/Explorer/Controls/JsonEditor/JsonEditorComponent.ts
 src/Explorer/DataSamples/ContainerSampleGenerator.test.ts
@@ -116,12 +113,8 @@ src/ReactDevTools.ts
 src/Shared/Constants.ts
 src/Shared/DefaultExperienceUtility.test.ts
 src/Shared/DefaultExperienceUtility.ts
-src/Shared/appInsights.ts
-src/SparkClusterManager/ArcadiaResourceManager.ts
-src/SparkClusterManager/SparkClusterManager.ts
 src/Terminal/JupyterLabAppFactory.ts
 src/Terminal/NotebookAppContracts.d.ts
-src/applyExplorerBindings.ts
 src/global.d.ts
 src/setupTests.ts
 src/Explorer/Controls/InputTypeahead/InputTypeaheadComponent.tsx
@@ -131,8 +124,6 @@ src/Explorer/Controls/NotebookViewer/NotebookViewerComponent.tsx
 src/Explorer/Controls/TreeComponent/TreeComponent.tsx
 src/Explorer/Graph/GraphExplorerComponent/GraphExplorer.test.tsx
 src/Explorer/Graph/GraphExplorerComponent/NodePropertiesComponent.tsx
-src/Explorer/Graph/GraphExplorerComponent/ReadOnlyNodePropertiesComponent.test.tsx
-src/Explorer/Graph/GraphExplorerComponent/ReadOnlyNodePropertiesComponent.tsx
 src/Explorer/Menus/CommandBar/CommandBarUtil.tsx
 src/Explorer/Notebook/NotebookComponent/NotebookComponentAdapter.tsx
 src/Explorer/Notebook/NotebookComponent/VirtualCommandBarComponent.tsx
@@ -141,7 +132,6 @@ src/Explorer/Notebook/NotebookRenderer/NotebookRenderer.tsx
 src/Explorer/Notebook/NotebookRenderer/decorators/draggable/index.tsx
 src/Explorer/Notebook/NotebookRenderer/decorators/hijack-scroll/index.tsx
 src/Explorer/Notebook/NotebookRenderer/decorators/kbd-shortcuts/index.tsx
-src/Explorer/Notebook/temp/inputs/connected-editors/codemirror.tsx
 src/Explorer/Tree/ResourceTreeAdapter.tsx
 __mocks__/monaco-editor.ts
 src/Explorer/Tree/ResourceTree.tsx

src/Contracts/Versions.ts

@@ -1,4 +1,4 @@
 /**
  * Data Explorer version {major.minor.patch}
  */
-export const DataExplorer: string = "1.0.1";
+export const DataExplorer = "1.0.1";

src/Explorer/Graph/GraphExplorerComponent/ReadOnlyNodePropertiesComponent.test.tsx

@@ -1,7 +1,6 @@
-import React from "react";
 import { shallow } from "enzyme";
+import React from "react";
 import { GraphHighlightedNodeData } from "./GraphExplorer";
-
 import {
   ReadOnlyNodePropertiesComponent,
   ReadOnlyNodePropertiesComponentProps,
@@ -44,7 +43,7 @@ describe("<ReadOnlyNodePropertiesComponent />", () => {
     const mockNode2 = {
       ...mockNode,
       properties: {
-        key3: ["abcd", 1234, true, false, undefined, null],
+        key3: ["abcd", 1234, true, false, undefined],
       },
     };
     const props: ReadOnlyNodePropertiesComponentProps = { node: mockNode2 };

src/Explorer/Graph/GraphExplorerComponent/ReadOnlyNodePropertiesComponent.tsx

@@ -60,9 +60,7 @@ export class ReadOnlyNodePropertiesComponent extends React.Component<ReadOnlyNod
   }
 
   public static singlePropertyValueToString(value: ViewModels.GremlinPropertyValueType): string {
-    if (value === null) {
+    if (typeof value === "undefined") {
-      return "null";
-    } else if (typeof value === "undefined") {
       return "undefined";
     } else {
       return value.toString();
@@ -71,11 +69,8 @@ export class ReadOnlyNodePropertiesComponent extends React.Component<ReadOnlyNod
 
   public static renderSinglePropertyValue(value: ViewModels.GremlinPropertyValueType): JSX.Element {
     let singlePropValue = value;
-    let className = "propertyValue";
+    const className = "propertyValue";
-    if (singlePropValue === null) {
+    if (typeof singlePropValue === "undefined") {
-      singlePropValue = "null";
-      className += " isNull";
-    } else if (typeof singlePropValue === "undefined") {
       singlePropValue = "undefined";
     } else {
       singlePropValue = value.toString();

src/Explorer/Graph/GraphExplorerComponent/__snapshots__/ReadOnlyNodePropertiesComponent.test.tsx.snap

@@ -123,7 +123,7 @@ exports[`<ReadOnlyNodePropertiesComponent /> renders properties (with multiple v
       </td>
       <td
         className="valueCol"
-        title="abcd, 1234, true, false, undefined, null"
+        title="abcd, 1234, true, false, undefined"
       >
         <div
           className="propertyValue"
@@ -155,12 +155,6 @@ exports[`<ReadOnlyNodePropertiesComponent /> renders properties (with multiple v
         >
           undefined
         </div>
-        <div
-          className="propertyValue isNull"
-          key="null"
-        >
-          null
-        </div>
       </td>
     </tr>
   </tbody>

src/applyExplorerBindings.ts

@@ -3,7 +3,7 @@ import { BindingHandlersRegisterer } from "./Bindings/BindingHandlersRegisterer"
 import Explorer from "./Explorer/Explorer";
 
 export const applyExplorerBindings = (explorer: Explorer) => {
-  if (!!explorer) {
+  if (explorer) {
     window.dataExplorer = explorer;
     BindingHandlersRegisterer.registerBindingHandlers();
     ko.applyBindings(explorer);