From 84eabc07fb0dc455b19d118e7ddc8bc9d9197b54 Mon Sep 17 00:00:00 2001 From: Kroese Date: Fri, 7 Aug 2026 07:26:08 +0200 Subject: [PATCH] fix: Fail on answer file generation errors (#2100) --- src/install.sh | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/install.sh b/src/install.sh index ea33f397..41e7e6ac 100644 --- a/src/install.sh +++ b/src/install.sh @@ -49,9 +49,7 @@ selectWindowsImage() { if resolveImage "$VERSION"; then if ! setImage; then - skipUnattended "$dir" "$iso" "$boot" || return 70 - handled=1 - return 0 + return 70 fi if ! needsExtraction "$DETECTED" "$iso"; then @@ -689,8 +687,11 @@ setImage() { setXML "" && return 0 enabled "$MANUAL" && return 0 - # A missing answer file is a supported manual-install path, not a hard media - # failure. + # If a usable source template exists, setXML failed while preparing it. + # That is an installation error and must not fall back to manual setup. + hasAnswerFile "$DETECTED" && return 1 + + # A genuinely missing answer file is a supported manual-install path. MANUAL="Y" local desc