Updated sorting in groups controllers

• Updated:
- sorting in groups controllers
This commit is contained in:
mgabdev
2020-08-07 17:26:14 -05:00
parent 90dc47a61b
commit a4c6b5639d
2 changed files with 150 additions and 34 deletions

View File

@@ -28,6 +28,8 @@ class Api::V1::Timelines::GroupCollectionController < Api::BaseController
return @collection_type
end
private
def set_sort_type
@sort_type = 'newest'
@sort_type = params[:sort_by] if [
@@ -39,12 +41,14 @@ class Api::V1::Timelines::GroupCollectionController < Api::BaseController
'top_yearly',
'top_all_time',
].include? params[:sort_by]
if @collection_type === 'featured' && (@sort_type == 'newest' || @sort_type == 'recent')
@sort_type = 'top_today'
end
return @sort_type
end
private
def set_statuses
@statuses = cached_group_collection_statuses
end
@@ -59,8 +63,10 @@ class Api::V1::Timelines::GroupCollectionController < Api::BaseController
@groupIds = []
if @collection_type == 'featured'
@groupIds = Group.where(is_featured: true, is_archived: false).limit(100).all.pluck(:id)
elsif @collection_type == 'member'
elsif @collection_type == 'member' && !current_user.nil?
@groupIds = current_user.account.groups.pluck(:id)
else
return []
end
date_limit = 30.days.ago
@@ -80,8 +86,10 @@ class Api::V1::Timelines::GroupCollectionController < Api::BaseController
if @sort_type == 'newest'
statuses = Status.where(
group: @groupIds, reply: false
).paginate_by_id(limit_param(DEFAULT_STATUSES_LIMIT), params_slice(:max_id, :since_id, :min_id))
.reject { |status| FeedManager.instance.filter?(:home, status, current_account.id) }
).paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id)
).reject { |status| FeedManager.instance.filter?(:home, status, current_account.id) }
elsif @sort_type == 'recent'
statuses = Status.where(
group: @groupIds, reply: false
@@ -112,21 +120,42 @@ class Api::V1::Timelines::GroupCollectionController < Api::BaseController
end
end
else
statuses = Status.as_group_collection_timeline(@groupIds).paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id)
)
if @sort_type == 'newest'
statuses = Status.where(
group: @groupIds, reply: false
).paginate_by_id(limit_param(DEFAULT_STATUSES_LIMIT), params_slice(:max_id, :since_id, :min_id))
elsif @sort_type == 'recent'
statuses = Status.where(
group: @groupIds, reply: false
).joins(:status_stat).where(
'status_stats.replies_count > 0 OR status_stats.reblogs_count > 0 OR status_stats.favourites_count > 0'
).order('status_stats.updated_at DESC').paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id)
)
elsif ['top_today', 'top_weekly', 'top_monthly', 'top_yearly', 'top_all_time'].include? @sort_type
if @sort_type == 'top_all_time'
statuses = Status.unscoped.where(
group: @groupIds, reply: false
).joins(:status_stat).order(top_order)
.paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id)
)
else
statuses = Status.unscoped.where(
group: @groupIds, reply: false
).where(
'statuses.created_at > ?', date_limit
).joins(:status_stat).order(top_order).paginate_by_id(
limit_param(DEFAULT_STATUSES_LIMIT),
params_slice(:max_id, :since_id, :min_id)
)
end
end
end
# statuses = query
# if truthy_param?(:only_media) && current_account
# # `SELECT DISTINCT id, updated_at` is too slow, so pluck ids at first, and then select id, updated_at with ids.
# status_ids = statuses.joins(:media_attachments).distinct(:id).pluck(:id)
# statuses.where(id: status_ids)
# else
statuses
# end
statuses
end
def insert_pagination_headers