From f849321b076589667c76decad926a68a9f89fb44 Mon Sep 17 00:00:00 2001 From: mgabdev <> Date: Thu, 4 Jul 2019 00:10:24 -0400 Subject: [PATCH] Updated favourited_by_accounts_controller to return empty object Removed ability to view accounts that favorited a status --- .../favourited_by_accounts_controller.rb | 44 +++++-------------- 1 file changed, 11 insertions(+), 33 deletions(-) diff --git a/app/controllers/api/v1/statuses/favourited_by_accounts_controller.rb b/app/controllers/api/v1/statuses/favourited_by_accounts_controller.rb index 10c1b86d..c8a20bae 100644 --- a/app/controllers/api/v1/statuses/favourited_by_accounts_controller.rb +++ b/app/controllers/api/v1/statuses/favourited_by_accounts_controller.rb @@ -4,74 +4,52 @@ class Api::V1::Statuses::FavouritedByAccountsController < Api::BaseController include Authorization before_action -> { authorize_if_got_token! :read, :'read:accounts' } - before_action :set_status - after_action :insert_pagination_headers respond_to :json def index - @accounts = load_accounts - render json: @accounts, each_serializer: REST::AccountSerializer + render json: {}, status: :ok end private def load_accounts - default_accounts.merge(paginated_favourites).to_a + # end def default_accounts - Account - .includes(:favourites, :account_stat) - .references(:favourites) - .where(favourites: { status_id: @status.id }) + # end def paginated_favourites - Favourite.paginate_by_max_id( - limit_param(DEFAULT_ACCOUNTS_LIMIT), - params[:max_id], - params[:since_id] - ) - end - - def insert_pagination_headers - set_pagination_headers(next_path, prev_path) + # end def next_path - if records_continue? - api_v1_status_favourited_by_index_url pagination_params(max_id: pagination_max_id) - end + # end def prev_path - unless @accounts.empty? - api_v1_status_favourited_by_index_url pagination_params(since_id: pagination_since_id) - end + # end def pagination_max_id - @accounts.last.favourites.last.id + # end def pagination_since_id - @accounts.first.favourites.first.id + # end def records_continue? - @accounts.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) + # end def set_status - @status = Status.find(params[:status_id]) - authorize @status, :show? - rescue GabSocial::NotPermittedError - # Reraise in order to get a 404 instead of a 403 error code - raise ActiveRecord::RecordNotFound + # end def pagination_params(core_params) - params.slice(:limit).permit(:limit).merge(core_params) + # end end