From 94f0f8465622e121d65f70d2cce6101d8d716a80 Mon Sep 17 00:00:00 2001 From: Nick Hu Date: Mon, 20 Oct 2025 14:34:10 +0800 Subject: [PATCH] lib: sbi: Extends sbi_ipi_raw_send() to use all available IPI devices A platform may contain multiple IPI devices. In certain use cases, such as power management, it may be necessary to send an IPI through a specific device to wake up a CPU. For example, if an IMSIC is powered down and reset, the core cannot receive IPIs from it, so the wake-up must instead be triggered through the CLINT. Suggested-by: Anup Patel Signed-off-by: Nick Hu Reviewed-by: Anup Patel Link: https://lore.kernel.org/r/20251020-cache-upstream-v7-8-69a132447d8a@sifive.com Signed-off-by: Anup Patel --- include/sbi/sbi_ipi.h | 2 +- lib/sbi/sbi_hsm.c | 2 +- lib/sbi/sbi_ipi.c | 16 +++++++++++++--- platform/generic/andes/ae350.c | 2 +- 4 files changed, 16 insertions(+), 6 deletions(-) diff --git a/include/sbi/sbi_ipi.h b/include/sbi/sbi_ipi.h index 26d1b66b..2c231041 100644 --- a/include/sbi/sbi_ipi.h +++ b/include/sbi/sbi_ipi.h @@ -88,7 +88,7 @@ int sbi_ipi_send_halt(ulong hmask, ulong hbase); void sbi_ipi_process(void); -int sbi_ipi_raw_send(u32 hartindex); +int sbi_ipi_raw_send(u32 hartindex, bool all_devices); void sbi_ipi_raw_clear(bool all_devices); diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index bb274b33..0d97b43e 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -364,7 +364,7 @@ int sbi_hsm_hart_start(struct sbi_scratch *scratch, (hsm_device_has_hart_secondary_boot() && !init_count)) { rc = hsm_device_hart_start(hartid, scratch->warmboot_addr); } else { - rc = sbi_ipi_raw_send(hartindex); + rc = sbi_ipi_raw_send(hartindex, true); } if (!rc) diff --git a/lib/sbi/sbi_ipi.c b/lib/sbi/sbi_ipi.c index ed9ccffb..5b2d2f72 100644 --- a/lib/sbi/sbi_ipi.c +++ b/lib/sbi/sbi_ipi.c @@ -88,7 +88,7 @@ static int sbi_ipi_send(struct sbi_scratch *scratch, u32 remote_hartindex, */ if (!__atomic_fetch_or(&ipi_data->ipi_type, BIT(event), __ATOMIC_RELAXED)) - ret = sbi_ipi_raw_send(remote_hartindex); + ret = sbi_ipi_raw_send(remote_hartindex, false); sbi_pmu_ctr_incr_fw(SBI_PMU_FW_IPI_SENT); @@ -271,8 +271,10 @@ void sbi_ipi_process(void) } } -int sbi_ipi_raw_send(u32 hartindex) +int sbi_ipi_raw_send(u32 hartindex, bool all_devices) { + struct sbi_ipi_device_node *entry; + if (!ipi_dev || !ipi_dev->ipi_send) return SBI_EINVAL; @@ -287,7 +289,15 @@ int sbi_ipi_raw_send(u32 hartindex) */ wmb(); - ipi_dev->ipi_send(hartindex); + if (all_devices) { + sbi_list_for_each_entry(entry, &ipi_dev_node_list, head) { + if (entry->dev->ipi_send) + entry->dev->ipi_send(hartindex); + } + } else { + ipi_dev->ipi_send(hartindex); + } + return 0; } diff --git a/platform/generic/andes/ae350.c b/platform/generic/andes/ae350.c index f06e207d..08080657 100644 --- a/platform/generic/andes/ae350.c +++ b/platform/generic/andes/ae350.c @@ -35,7 +35,7 @@ static int ae350_hart_start(u32 hartid, ulong saddr) * 2) the target hart is non-sleepable 25-series hart0 */ if (!sbi_init_count(hartindex) || (is_andes(25) && hartid == 0)) - return sbi_ipi_raw_send(hartindex); + return sbi_ipi_raw_send(hartindex, false); /* Write wakeup command to the sleep hart */ smu_set_command(&smu, WAKEUP_CMD, hartid);