[Bug][Move] Refactor moves that call a random move (#3380)
* Combine moveset from allies and uses it to get a move
* Clearer implementation of combining user and teammates' moves
* Refactor assist and sleep talk to use metronome's attribute for calling a move
* Refactor move filtering in RandomMovesetMoveAttr, creates arrays with invalid moves for assist/sleep talk
* Refactor RandomMoveAttr to set moveId in condition, places reused code in callMove in RandomMoveAttr
* Correct invalid move lists, adds Max/Z moves to metronome's list
* Remove ignoresVirtual from beta merge
* Remove Max/Z moves per frutescens' comment
* Fix bug with metronome/copycat/assist/sleep talk targeting ally
* Experimental async/await to be tested
* Refactor other attributes to extend CallMoveAttr
* Replace QueuedMove with TurnMove, refactor to attempt two-turn move fix for metronome
* Fix Swallow test due to TurnMove refactor
* Further fixes for TurnMove refactor
* Fix metronome two turn moves for enemy pokemon
* Replace nested ternary with if-else block per DayKev's comment
* Minor fixes
* Adjust command phase args handling
* Create metronome test, refactor RandomMoveAttr for easier testing
* Add unit test for recharge moves
* Refactor Copycat and Mirror Move, adjust move targeting
* Add unit test for ally targeting with Aromatic Mist
* Add tests for secondary effects and recharge moves for metronome
* Add test for Roar, remove test for Acupressure
* Create test for Assist
* Add test for assist failing
* Add sleep talk unit test coverage
* Adjust move-phase to better track last move for copycat, write and update unit tests for assist/copycat
* Create moveHistory in Battle to track all moves used, adjust mirror move to use this, writes unit tests
* Correct mirror move implementation, rewrite unit test to adjust
* Add docs to attrs, update assist to only grab allies sets
* Update assist unit test to match expected functionality
* Update metronome unit test to use getMoveOverride
* Update copycat unit test to use metronome getMoveOverride mock
* Fix phase interception
* Add docs from missed conversations
* Update assist tests to use manual moveset overrides
Minor fixes to other tests
* Remove `export` from `CallMoveAttr`
* Add missing `.unimplemented()` to some Max- and Z-Moves
---------
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-14 18:26:35 -05:00
|
|
|
import { RechargingTag, SemiInvulnerableTag } from "#app/data/battler-tags";
|
|
|
|
import { allMoves, RandomMoveAttr } from "#app/data/move";
|
|
|
|
import { Abilities } from "#app/enums/abilities";
|
|
|
|
import { Stat } from "#app/enums/stat";
|
|
|
|
import { CommandPhase } from "#app/phases/command-phase";
|
|
|
|
import { Moves } from "#enums/moves";
|
|
|
|
import { Species } from "#enums/species";
|
2025-02-22 22:52:07 -06:00
|
|
|
import GameManager from "#test/testUtils/gameManager";
|
[Bug][Move] Refactor moves that call a random move (#3380)
* Combine moveset from allies and uses it to get a move
* Clearer implementation of combining user and teammates' moves
* Refactor assist and sleep talk to use metronome's attribute for calling a move
* Refactor move filtering in RandomMovesetMoveAttr, creates arrays with invalid moves for assist/sleep talk
* Refactor RandomMoveAttr to set moveId in condition, places reused code in callMove in RandomMoveAttr
* Correct invalid move lists, adds Max/Z moves to metronome's list
* Remove ignoresVirtual from beta merge
* Remove Max/Z moves per frutescens' comment
* Fix bug with metronome/copycat/assist/sleep talk targeting ally
* Experimental async/await to be tested
* Refactor other attributes to extend CallMoveAttr
* Replace QueuedMove with TurnMove, refactor to attempt two-turn move fix for metronome
* Fix Swallow test due to TurnMove refactor
* Further fixes for TurnMove refactor
* Fix metronome two turn moves for enemy pokemon
* Replace nested ternary with if-else block per DayKev's comment
* Minor fixes
* Adjust command phase args handling
* Create metronome test, refactor RandomMoveAttr for easier testing
* Add unit test for recharge moves
* Refactor Copycat and Mirror Move, adjust move targeting
* Add unit test for ally targeting with Aromatic Mist
* Add tests for secondary effects and recharge moves for metronome
* Add test for Roar, remove test for Acupressure
* Create test for Assist
* Add test for assist failing
* Add sleep talk unit test coverage
* Adjust move-phase to better track last move for copycat, write and update unit tests for assist/copycat
* Create moveHistory in Battle to track all moves used, adjust mirror move to use this, writes unit tests
* Correct mirror move implementation, rewrite unit test to adjust
* Add docs to attrs, update assist to only grab allies sets
* Update assist unit test to match expected functionality
* Update metronome unit test to use getMoveOverride
* Update copycat unit test to use metronome getMoveOverride mock
* Fix phase interception
* Add docs from missed conversations
* Update assist tests to use manual moveset overrides
Minor fixes to other tests
* Remove `export` from `CallMoveAttr`
* Add missing `.unimplemented()` to some Max- and Z-Moves
---------
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2025-01-14 18:26:35 -05:00
|
|
|
import Phaser from "phaser";
|
|
|
|
import { afterEach, beforeAll, beforeEach, describe, it, expect, vi } from "vitest";
|
|
|
|
|
|
|
|
describe("Moves - Metronome", () => {
|
|
|
|
let phaserGame: Phaser.Game;
|
|
|
|
let game: GameManager;
|
|
|
|
|
|
|
|
const randomMoveAttr = allMoves[Moves.METRONOME].getAttrs(RandomMoveAttr)[0];
|
|
|
|
|
|
|
|
beforeAll(() => {
|
|
|
|
phaserGame = new Phaser.Game({
|
|
|
|
type: Phaser.HEADLESS,
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
|
|
|
afterEach(() => {
|
|
|
|
game.phaseInterceptor.restoreOg();
|
|
|
|
});
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
game = new GameManager(phaserGame);
|
|
|
|
game.override
|
|
|
|
.moveset([ Moves.METRONOME, Moves.SPLASH ])
|
|
|
|
.battleType("single")
|
|
|
|
.startingLevel(100)
|
|
|
|
.starterSpecies(Species.REGIELEKI)
|
|
|
|
.enemyLevel(100)
|
|
|
|
.enemySpecies(Species.SHUCKLE)
|
|
|
|
.enemyMoveset(Moves.SPLASH)
|
|
|
|
.enemyAbility(Abilities.BALL_FETCH);
|
|
|
|
});
|
|
|
|
|
|
|
|
it("should have one semi-invulnerable turn and deal damage on the second turn when a semi-invulnerable move is called", async () => {
|
|
|
|
await game.classicMode.startBattle();
|
|
|
|
const player = game.scene.getPlayerPokemon()!;
|
|
|
|
const enemy = game.scene.getEnemyPokemon()!;
|
|
|
|
vi.spyOn(randomMoveAttr, "getMoveOverride").mockReturnValue(Moves.DIVE);
|
|
|
|
|
|
|
|
game.move.select(Moves.METRONOME);
|
|
|
|
await game.toNextTurn();
|
|
|
|
|
|
|
|
expect(player.getTag(SemiInvulnerableTag)).toBeTruthy();
|
|
|
|
|
|
|
|
await game.toNextTurn();
|
|
|
|
expect(player.getTag(SemiInvulnerableTag)).toBeFalsy();
|
|
|
|
expect(enemy.isFullHp()).toBeFalsy();
|
|
|
|
});
|
|
|
|
|
|
|
|
it("should apply secondary effects of a move", async () => {
|
|
|
|
await game.classicMode.startBattle();
|
|
|
|
const player = game.scene.getPlayerPokemon()!;
|
|
|
|
vi.spyOn(randomMoveAttr, "getMoveOverride").mockReturnValue(Moves.WOOD_HAMMER);
|
|
|
|
|
|
|
|
game.move.select(Moves.METRONOME);
|
|
|
|
await game.toNextTurn();
|
|
|
|
|
|
|
|
expect(player.isFullHp()).toBeFalsy();
|
|
|
|
});
|
|
|
|
|
|
|
|
it("should recharge after using recharge move", async () => {
|
|
|
|
await game.classicMode.startBattle();
|
|
|
|
const player = game.scene.getPlayerPokemon()!;
|
|
|
|
vi.spyOn(randomMoveAttr, "getMoveOverride").mockReturnValue(Moves.HYPER_BEAM);
|
|
|
|
vi.spyOn(allMoves[Moves.HYPER_BEAM], "accuracy", "get").mockReturnValue(100);
|
|
|
|
|
|
|
|
game.move.select(Moves.METRONOME);
|
|
|
|
await game.toNextTurn();
|
|
|
|
|
|
|
|
expect(player.getTag(RechargingTag)).toBeTruthy();
|
|
|
|
});
|
|
|
|
|
|
|
|
it("should only target ally for Aromatic Mist", async () => {
|
|
|
|
game.override.battleType("double");
|
|
|
|
await game.classicMode.startBattle([ Species.REGIELEKI, Species.RATTATA ]);
|
|
|
|
const [ leftPlayer, rightPlayer ] = game.scene.getPlayerField();
|
|
|
|
const [ leftOpp, rightOpp ] = game.scene.getEnemyField();
|
|
|
|
vi.spyOn(randomMoveAttr, "getMoveOverride").mockReturnValue(Moves.AROMATIC_MIST);
|
|
|
|
|
|
|
|
game.move.select(Moves.METRONOME, 0);
|
|
|
|
await game.phaseInterceptor.to(CommandPhase);
|
|
|
|
game.move.select(Moves.SPLASH, 1);
|
|
|
|
await game.toNextTurn();
|
|
|
|
|
|
|
|
expect(rightPlayer.getStatStage(Stat.SPDEF)).toBe(1);
|
|
|
|
expect(leftPlayer.getStatStage(Stat.SPDEF)).toBe(0);
|
|
|
|
expect(leftOpp.getStatStage(Stat.SPDEF)).toBe(0);
|
|
|
|
expect(rightOpp.getStatStage(Stat.SPDEF)).toBe(0);
|
|
|
|
});
|
|
|
|
|
|
|
|
it("should cause opponent to flee, and not crash for Roar", async () => {
|
|
|
|
await game.classicMode.startBattle();
|
|
|
|
vi.spyOn(randomMoveAttr, "getMoveOverride").mockReturnValue(Moves.ROAR);
|
|
|
|
|
|
|
|
const enemyPokemon = game.scene.getEnemyPokemon()!;
|
|
|
|
|
|
|
|
game.move.select(Moves.METRONOME);
|
|
|
|
await game.phaseInterceptor.to("BerryPhase");
|
|
|
|
|
|
|
|
const isVisible = enemyPokemon.visible;
|
|
|
|
const hasFled = enemyPokemon.switchOutStatus;
|
|
|
|
expect(!isVisible && hasFled).toBe(true);
|
|
|
|
|
|
|
|
await game.phaseInterceptor.to("CommandPhase");
|
|
|
|
});
|
|
|
|
});
|