attach github issues to all encounter jsdocs

This commit is contained in:
ImperialSympathizer 2024-07-18 11:19:39 -04:00
parent 2697a738ba
commit 1ffefe744d
15 changed files with 63 additions and 13 deletions

View File

@ -15,7 +15,7 @@ import { getRandomPlayerPokemon, getRandomSpeciesByStarterTier } from "#app/data
/** i18n namespace for encounter */ /** i18n namespace for encounter */
const namespace = "mysteryEncounter:dark_deal"; const namespace = "mysteryEncounter:dark_deal";
// Exclude Ultra Beasts, Paradox, Necrozma, Eternatus, and egg-locked mythicals /** Exclude Ultra Beasts (inludes Cosmog/Solgaleo/Lunala/Necrozma), Paradox (includes Miraidon/Koraidon), Eternatus, and egg-locked mythicals */
const excludedBosses = [ const excludedBosses = [
Species.NECROZMA, Species.NECROZMA,
Species.COSMOG, Species.COSMOG,
@ -68,6 +68,11 @@ const excludedBosses = [
Species.PECHARUNT, Species.PECHARUNT,
]; ];
/**
* Dark Deal encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/61 | GitHub Issue #61}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const DarkDealEncounter: IMysteryEncounter = export const DarkDealEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.DARK_DEAL) MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.DARK_DEAL)
.withEncounterTier(MysteryEncounterTier.ROGUE) .withEncounterTier(MysteryEncounterTier.ROGUE)

View File

@ -15,6 +15,11 @@ import IMysteryEncounter, {
/** i18n namespace for encounter */ /** i18n namespace for encounter */
const namespace = "mysteryEncounter:department_store_sale"; const namespace = "mysteryEncounter:department_store_sale";
/**
* Department Store Sale encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/33 | GitHub Issue #33}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const DepartmentStoreSaleEncounter: IMysteryEncounter = export const DepartmentStoreSaleEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.DEPARTMENT_STORE_SALE) MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.DEPARTMENT_STORE_SALE)
.withEncounterTier(MysteryEncounterTier.COMMON) .withEncounterTier(MysteryEncounterTier.COMMON)

View File

@ -21,6 +21,11 @@ import IMysteryEncounter, {
/** i18n namespace for the encounter */ /** i18n namespace for the encounter */
const namespace = "mysteryEncounter:field_trip"; const namespace = "mysteryEncounter:field_trip";
/**
* Field Trip encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/17 | GitHub Issue #17}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const FieldTripEncounter: IMysteryEncounter = export const FieldTripEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.FIELD_TRIP) MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.FIELD_TRIP)
.withEncounterTier(MysteryEncounterTier.COMMON) .withEncounterTier(MysteryEncounterTier.COMMON)

View File

@ -19,6 +19,11 @@ import { randSeedInt } from "#app/utils";
/** the i18n namespace for the encounter */ /** the i18n namespace for the encounter */
const namespace = "mysteryEncounter:fiery_fallout"; const namespace = "mysteryEncounter:fiery_fallout";
/**
* Fiery Fallout encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/88 | GitHub Issue #88}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const FieryFalloutEncounter: IMysteryEncounter = export const FieryFalloutEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.FIERY_FALLOUT MysteryEncounterType.FIERY_FALLOUT

View File

@ -31,6 +31,11 @@ import { queueEncounterMessage, showEncounterText } from "#app/data/mystery-enco
/** the i18n namespace for the encounter */ /** the i18n namespace for the encounter */
const namespace = "mysteryEncounter:fight_or_flight"; const namespace = "mysteryEncounter:fight_or_flight";
/**
* Fight or Flight encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/24 | GitHub Issue #24}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const FightOrFlightEncounter: IMysteryEncounter = export const FightOrFlightEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.FIGHT_OR_FLIGHT MysteryEncounterType.FIGHT_OR_FLIGHT

View File

@ -16,7 +16,7 @@ const OPTION_2_REQUIRED_MOVE = Moves.FLY;
*/ */
const DAMAGE_PERCENTAGE: number = 25; const DAMAGE_PERCENTAGE: number = 25;
/** The i18n namespace for the encounter */ /** The i18n namespace for the encounter */
const namepsace = "mysteryEncounter:lostAtSea"; const namepsace = "mysteryEncounter:lostAtSeaDialogue";
/** /**
* Lost at sea encounter. * Lost at sea encounter.

View File

@ -23,6 +23,11 @@ import IMysteryEncounter, {
/** the i18n namespace for the encounter */ /** the i18n namespace for the encounter */
const namespace = "mysteryEncounter:mysterious_challengers"; const namespace = "mysteryEncounter:mysterious_challengers";
/**
* Mysterious Challengers encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/41 | GitHub Issue #41}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const MysteriousChallengersEncounter: IMysteryEncounter = export const MysteriousChallengersEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.MYSTERIOUS_CHALLENGERS MysteryEncounterType.MYSTERIOUS_CHALLENGERS

View File

@ -14,6 +14,11 @@ import IMysteryEncounter, {
} from "../mystery-encounter"; } from "../mystery-encounter";
import { EncounterOptionMode, MysteryEncounterOptionBuilder } from "../mystery-encounter-option"; import { EncounterOptionMode, MysteryEncounterOptionBuilder } from "../mystery-encounter-option";
/**
* Mysterious Chest encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/32 | GitHub Issue #32}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const MysteriousChestEncounter: IMysteryEncounter = export const MysteriousChestEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.MYSTERIOUS_CHEST MysteryEncounterType.MYSTERIOUS_CHEST

View File

@ -19,6 +19,11 @@ import { showEncounterText } from "#app/data/mystery-encounters/utils/encounter-
/** the i18n namespace for the encounter */ /** the i18n namespace for the encounter */
const namespace = "mysteryEncounter:safari_zone"; const namespace = "mysteryEncounter:safari_zone";
/**
* Safari Zone encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/39 | GitHub Issue #39}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const SafariZoneEncounter: IMysteryEncounter = export const SafariZoneEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.SAFARI_ZONE) MysteryEncounterBuilder.withEncounterType(MysteryEncounterType.SAFARI_ZONE)
.withEncounterTier(MysteryEncounterTier.GREAT) .withEncounterTier(MysteryEncounterTier.GREAT)

View File

@ -15,6 +15,11 @@ import { queueEncounterMessage } from "#app/data/mystery-encounters/utils/encoun
/** the i18n namespace for this encounter */ /** the i18n namespace for this encounter */
const namespace = "mysteryEncounter:shady_vitamin_dealer"; const namespace = "mysteryEncounter:shady_vitamin_dealer";
/**
* Shady Vitamin Dealer encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/34 | GitHub Issue #34}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const ShadyVitaminDealerEncounter: IMysteryEncounter = export const ShadyVitaminDealerEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.SHADY_VITAMIN_DEALER MysteryEncounterType.SHADY_VITAMIN_DEALER

View File

@ -16,11 +16,16 @@ import { queueEncounterMessage } from "#app/data/mystery-encounters/utils/encoun
/** i18n namespace for the encounter */ /** i18n namespace for the encounter */
const namespace = "mysteryEncounter:sleeping_snorlax"; const namespace = "mysteryEncounter:sleeping_snorlax";
/**
* Sleeping Snorlax encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/103 | GitHub Issue #103}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const SleepingSnorlaxEncounter: IMysteryEncounter = export const SleepingSnorlaxEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.SLEEPING_SNORLAX MysteryEncounterType.SLEEPING_SNORLAX
) )
.withEncounterTier(MysteryEncounterTier.ULTRA) .withEncounterTier(MysteryEncounterTier.GREAT)
.withSceneWaveRangeRequirement(10, 180) // waves 10 to 180 .withSceneWaveRangeRequirement(10, 180) // waves 10 to 180
.withCatchAllowed(true) .withCatchAllowed(true)
.withHideWildIntroMessage(true) .withHideWildIntroMessage(true)
@ -110,12 +115,7 @@ export const SleepingSnorlaxEncounter: IMysteryEncounter =
const p = instance.primaryPokemon; const p = instance.primaryPokemon;
p.status = new Status(StatusEffect.SLEEP, 0, 3); p.status = new Status(StatusEffect.SLEEP, 0, 3);
p.updateInfo(true); p.updateInfo(true);
// const sitrus = (modifierTypes.BERRY?.() as ModifierTypeGenerator).generateType(scene.getParty(), [BerryType.SITRUS]); const sitrus = generateModifierTypeOption(scene, modifierTypes.BERRY, [BerryType.SITRUS]);
const sitrus = generateModifierTypeOption(
scene,
modifierTypes.BERRY,
[BerryType.SITRUS]
);
setEncounterRewards(scene, { setEncounterRewards(scene, {
guaranteedModifierTypeOptions: [sitrus], guaranteedModifierTypeOptions: [sitrus],

View File

@ -21,6 +21,11 @@ import { queueEncounterMessage } from "#app/data/mystery-encounters/utils/encoun
/** The i18n namespace for the encounter */ /** The i18n namespace for the encounter */
const namespace = "mysteryEncounter:training_session"; const namespace = "mysteryEncounter:training_session";
/**
* Training Session encounter.
* @see {@link https://github.com/AsdarDevelops/PokeRogue-Events/issues/43 | GitHub Issue #43}
* @see For biome requirements check [mysteryEncountersByBiome](../mystery-encounters.ts)
*/
export const TrainingSessionEncounter: IMysteryEncounter = export const TrainingSessionEncounter: IMysteryEncounter =
MysteryEncounterBuilder.withEncounterType( MysteryEncounterBuilder.withEncounterType(
MysteryEncounterType.TRAINING_SESSION MysteryEncounterType.TRAINING_SESSION

View File

@ -1,4 +1,4 @@
import { lostAtSea } from "./mystery-encounters/lost-at-sea"; import { lostAtSeaDialogue } from "./mystery-encounters/lost-at-sea-dialogue";
/** /**
* Patterns that can be used: * Patterns that can be used:
@ -260,5 +260,5 @@ export const mysteryEncounter = {
$@s{item_fanfare}You gained a Berry!`, $@s{item_fanfare}You gained a Berry!`,
"sleeping_snorlax_option_3_good_result": "Your {{option3PrimaryName}} uses {{option3PrimaryMove}}! @s{item_fanfare}It steals Leftovers off the sleeping Snorlax and you make out like bandits!", "sleeping_snorlax_option_3_good_result": "Your {{option3PrimaryName}} uses {{option3PrimaryMove}}! @s{item_fanfare}It steals Leftovers off the sleeping Snorlax and you make out like bandits!",
lostAtSea, lostAtSea: lostAtSeaDialogue,
} as const; } as const;

View File

@ -1,4 +1,4 @@
export const lostAtSea = { export const lostAtSeaDialogue = {
intro: "Wandering aimlessly, you effectively get nowhere.", intro: "Wandering aimlessly, you effectively get nowhere.",
title: "Lost at sea", title: "Lost at sea",
description: "The sea is turbulent in this area, and you seem to be running out of fuel.\nThis is bad. Is there a way out of the situation?", description: "The sea is turbulent in this area, and you seem to be running out of fuel.\nThis is bad. Is there a way out of the situation?",

View File

@ -12,7 +12,7 @@ import GameManager from "#app/test/utils/gameManager";
import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest"; import { afterEach, beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import { runSelectMysteryEncounterOption } from "../encounterTestUtils"; import { runSelectMysteryEncounterOption } from "../encounterTestUtils";
const namepsace = "mysteryEncounter:lostAtSea"; const namepsace = "mysteryEncounter:lostAtSeaDialogue";
/** Blastoise for surf. Pidgeot for fly. Abra for none. */ /** Blastoise for surf. Pidgeot for fly. Abra for none. */
const defaultParty = [Species.BLASTOISE, Species.PIDGEOT, Species.ABRA]; const defaultParty = [Species.BLASTOISE, Species.PIDGEOT, Species.ABRA];
const defaultBiome = Biome.SEA; const defaultBiome = Biome.SEA;