From 40328d5712272bf055ae223953e76c5a03369802 Mon Sep 17 00:00:00 2001 From: Frede Date: Thu, 6 Jun 2024 15:22:37 +0200 Subject: [PATCH] [BUG] Fix Move Info Overlay Scroll Bug (#1856) * Added "Skip Dialogues" option (if at least 1 classic win) * Removed error sound and hide option instead when classic wins = 0 * Add skip dialogues option to Unlockables and show unlocked message on first classic win * Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage * oops * dont show charSprite when skipping a dialogue, small fixes * correctly reset move description scrolling when changing move * override fix --------- Co-authored-by: Frederik Hobein --- src/ui/move-info-overlay.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/ui/move-info-overlay.ts b/src/ui/move-info-overlay.ts index cba2a2a16dc..3b947cb842d 100644 --- a/src/ui/move-info-overlay.ts +++ b/src/ui/move-info-overlay.ts @@ -142,10 +142,11 @@ export default class MoveInfoOverlay extends Phaser.GameObjects.Container implem this.desc.setText(move?.effect || ""); - // stop previous scrolling effects + // stop previous scrolling effects and reset y position if (this.descScroll) { this.descScroll.remove(); this.descScroll = null; + this.desc.y = (this.options?.top ? EFF_HEIGHT : 0) + BORDER - 2; } // determine if we need to add new scrolling effects