From 0c454c95ed743c7099b708b62fd9386f4b6755f8 Mon Sep 17 00:00:00 2001 From: ImperialSympathizer Date: Wed, 11 Sep 2024 18:29:51 -0400 Subject: [PATCH] PR feedback --- src/phases/party-exp-phase.ts | 4 ++++ src/phases/summon-phase.ts | 8 ++++++++ 2 files changed, 12 insertions(+) diff --git a/src/phases/party-exp-phase.ts b/src/phases/party-exp-phase.ts index 8165d3e2b95..4cfa57fa3f3 100644 --- a/src/phases/party-exp-phase.ts +++ b/src/phases/party-exp-phase.ts @@ -1,6 +1,10 @@ import BattleScene from "#app/battle-scene"; import { Phase } from "#app/phase"; +/** + * Provides EXP to the player's party *without* doing any Pokemon defeated checks or queueing extraneous post-battle phases + * Intended to be used as a more 1-off phase to provide exp to the party (such as during MEs), rather than cleanup a battle entirely + */ export class PartyExpPhase extends Phase { expValue: number; useWaveIndexMultiplier?: boolean; diff --git a/src/phases/summon-phase.ts b/src/phases/summon-phase.ts index 332ba81d195..d909c5c3501 100644 --- a/src/phases/summon-phase.ts +++ b/src/phases/summon-phase.ts @@ -93,6 +93,9 @@ export class SummonPhase extends PartyMemberPokemonPhase { } } + /** + * Enemy trainer or player trainer will do animations to throw Pokeball and summon a Pokemon to the field. + */ summon(): void { const pokemon = this.getPokemon(); @@ -171,6 +174,11 @@ export class SummonPhase extends PartyMemberPokemonPhase { }); } + /** + * Handles tweening and battle setup for a wild Pokemon that appears outside of the normal screen transition. + * Wild Pokemon will ease and fade in onto the field, then perform standard summon behavior. + * Currently only used by Mystery Encounters, as all other battle types pre-summon wild pokemon before screen transitions. + */ summonWild(): void { const pokemon = this.getPokemon();