From aae4d6933c22990e70511e31cd9ef61bf6595175 Mon Sep 17 00:00:00 2001
From: timchi94 <110631289+timchi94@users.noreply.github.com>
Date: Mon, 2 Sep 2024 15:43:44 -0400
Subject: [PATCH] =?UTF-8?q?=20[QoL]=20Enable=20female=20gender=20for=20all?=
 =?UTF-8?q?=20default=20starters=20and=20all=20existing=20s=E2=80=A6=20(#2?=
 =?UTF-8?q?194)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* fix: Enable female gender for all default starters and all existing saves

* Fixed Fresh Start so it doesn't restrict gender

---------

Co-authored-by: Mumble <171087428+frutescens@users.noreply.github.com>
Co-authored-by: frutescens <info@laptop>
---
 src/data/challenge.ts   | 2 --
 src/system/game-data.ts | 3 ++-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/data/challenge.ts b/src/data/challenge.ts
index 36f696e63c1..62751b92f9c 100644
--- a/src/data/challenge.ts
+++ b/src/data/challenge.ts
@@ -13,7 +13,6 @@ import { TrainerType } from "#enums/trainer-type";
 import { Nature } from "./nature";
 import { Moves } from "#app/enums/moves.js";
 import { TypeColor, TypeShadow } from "#app/enums/color.js";
-import { Gender } from "./gender";
 import { pokemonEvolutions } from "./pokemon-evolutions";
 import { pokemonFormChanges } from "./pokemon-forms";
 
@@ -659,7 +658,6 @@ export class FreshStartChallenge extends Challenge {
     pokemon.luck = 0; // No luck
     pokemon.shiny = false; // Not shiny
     pokemon.variant = 0; // Not shiny
-    pokemon.gender = Gender.MALE; // Starters default to male
     pokemon.formIndex = 0; // Froakie should be base form
     pokemon.ivs = [10, 10, 10, 10, 10, 10]; // Default IVs of 10 for all stats
     return true;
diff --git a/src/system/game-data.ts b/src/system/game-data.ts
index a4c276fa770..29bb6057722 100644
--- a/src/system/game-data.ts
+++ b/src/system/game-data.ts
@@ -1488,7 +1488,7 @@ export class GameData {
       };
     }
 
-    const defaultStarterAttr = DexAttr.NON_SHINY | DexAttr.MALE | DexAttr.DEFAULT_VARIANT | DexAttr.DEFAULT_FORM;
+    const defaultStarterAttr = DexAttr.NON_SHINY | DexAttr.MALE | DexAttr.FEMALE | DexAttr.DEFAULT_VARIANT | DexAttr.DEFAULT_FORM;
 
     const defaultStarterNatures: Nature[] = [];
 
@@ -1919,6 +1919,7 @@ export class GameData {
   fixStarterData(systemData: SystemSaveData): void {
     for (const starterId of defaultStarterSpecies) {
       systemData.starterData[starterId].abilityAttr |= AbilityAttr.ABILITY_1;
+      systemData.dexData[starterId].caughtAttr |= DexAttr.FEMALE;
     }
   }