[Balance] Implement more trainer types & add to biomes (#5520)

* Add more trainer types to biomes

This makes the Hooligans, Musician, Pilot, Poké Fan, Rich, and Rich Kid trainer types able to be battled.

* Adjusted Rich and Rich Kid $$$ multipliers

* Add basic dialogue for trainer types

Also added the Clerk's dialogue entries, as that trainer type has localized text, but no entry in the code.

* Fix Musician to Pokefan encounter music

* Add dialogue entries for new dialogue

---------

Co-authored-by: damocleas <damocleas25@gmail.com>

src/data/balance/biomes.ts

@@ -1659,7 +1659,7 @@ export const biomeTrainerPools: BiomeTrainerPools = {
   },
   [Biome.GRASS]: {
     [BiomePoolTier.COMMON]: [ TrainerType.BREEDER, TrainerType.SCHOOL_KID ],
-    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER ],
+    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER, TrainerType.POKEFAN ],
     [BiomePoolTier.RARE]: [ TrainerType.BLACK_BELT ],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
@@ -1680,9 +1680,9 @@ export const biomeTrainerPools: BiomeTrainerPools = {
     [BiomePoolTier.BOSS_ULTRA_RARE]: []
   },
   [Biome.METROPOLIS]: {
-    [BiomePoolTier.COMMON]: [ TrainerType.CLERK, TrainerType.CYCLIST, TrainerType.OFFICER, TrainerType.WAITER, TrainerType.BEAUTY ],
+    [BiomePoolTier.COMMON]: [ TrainerType.BEAUTY, TrainerType.CLERK, TrainerType.CYCLIST, TrainerType.OFFICER, TrainerType.WAITER ],
     [BiomePoolTier.UNCOMMON]: [ TrainerType.BREEDER, TrainerType.DEPOT_AGENT, TrainerType.GUITARIST ],
-    [BiomePoolTier.RARE]: [ TrainerType.ARTIST ],
+    [BiomePoolTier.RARE]: [ TrainerType.ARTIST, TrainerType.RICH_KID ],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
     [BiomePoolTier.BOSS]: [ TrainerType.WHITNEY, TrainerType.NORMAN, TrainerType.IONO, TrainerType.LARRY ],
@@ -1702,7 +1702,7 @@ export const biomeTrainerPools: BiomeTrainerPools = {
     [BiomePoolTier.BOSS_ULTRA_RARE]: []
   },
   [Biome.SEA]: {
-    [BiomePoolTier.COMMON]: [ TrainerType.SWIMMER, TrainerType.SAILOR ],
+    [BiomePoolTier.COMMON]: [ TrainerType.SAILOR, TrainerType.SWIMMER ],
     [BiomePoolTier.UNCOMMON]: [],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
@@ -1758,7 +1758,7 @@ export const biomeTrainerPools: BiomeTrainerPools = {
   },
   [Biome.MOUNTAIN]: {
     [BiomePoolTier.COMMON]: [ TrainerType.BACKPACKER, TrainerType.BLACK_BELT, TrainerType.HIKER ],
-    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER ],
+    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER, TrainerType.PILOT ],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
@@ -1790,7 +1790,7 @@ export const biomeTrainerPools: BiomeTrainerPools = {
     [BiomePoolTier.BOSS_ULTRA_RARE]: []
   },
   [Biome.DESERT]: {
-    [BiomePoolTier.COMMON]: [ TrainerType.SCIENTIST, TrainerType.BACKPACKER ],
+    [BiomePoolTier.COMMON]: [ TrainerType.BACKPACKER, TrainerType.SCIENTIST ],
     [BiomePoolTier.UNCOMMON]: [],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
@@ -1812,8 +1812,8 @@ export const biomeTrainerPools: BiomeTrainerPools = {
     [BiomePoolTier.BOSS_ULTRA_RARE]: []
   },
   [Biome.MEADOW]: {
-    [BiomePoolTier.COMMON]: [ TrainerType.PARASOL_LADY, TrainerType.BEAUTY ],
+    [BiomePoolTier.COMMON]: [ TrainerType.BEAUTY, TrainerType.MUSICIAN, TrainerType.PARASOL_LADY ],
-    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER, TrainerType.BREEDER, TrainerType.BAKER ],
+    [BiomePoolTier.UNCOMMON]: [ TrainerType.ACE_TRAINER, TrainerType.BAKER, TrainerType.BREEDER, TrainerType.POKEFAN ],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
@@ -1967,7 +1967,7 @@ export const biomeTrainerPools: BiomeTrainerPools = {
   },
   [Biome.SLUM]: {
     [BiomePoolTier.COMMON]: [ TrainerType.BIKER, TrainerType.OFFICER, TrainerType.ROUGHNECK ],
-    [BiomePoolTier.UNCOMMON]: [ TrainerType.BAKER ],
+    [BiomePoolTier.UNCOMMON]: [ TrainerType.BAKER, TrainerType.HOOLIGANS ],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
@@ -1988,8 +1988,8 @@ export const biomeTrainerPools: BiomeTrainerPools = {
     [BiomePoolTier.BOSS_ULTRA_RARE]: []
   },
   [Biome.ISLAND]: {
-    [BiomePoolTier.COMMON]: [],
+    [BiomePoolTier.COMMON]: [ TrainerType.RICH_KID ],
-    [BiomePoolTier.UNCOMMON]: [],
+    [BiomePoolTier.UNCOMMON]: [ TrainerType.RICH ],
     [BiomePoolTier.RARE]: [],
     [BiomePoolTier.SUPER_RARE]: [],
     [BiomePoolTier.ULTRA_RARE]: [],
@@ -7178,7 +7178,8 @@ export function initBiomes() {
       [ Biome.METROPOLIS, BiomePoolTier.COMMON ],
       [ Biome.MEADOW, BiomePoolTier.COMMON ],
       [ Biome.FAIRY_CAVE, BiomePoolTier.COMMON ]
-    ]],
+    ]
+    ],
     [ TrainerType.BIKER, [
       [ Biome.SLUM, BiomePoolTier.COMMON ]
     ]
@@ -7208,7 +7209,8 @@ export function initBiomes() {
     ],
     [ TrainerType.CLERK, [
       [ Biome.METROPOLIS, BiomePoolTier.COMMON ]
-    ]],
+    ]
+    ],
     [ TrainerType.CYCLIST, [
       [ Biome.PLAINS, BiomePoolTier.UNCOMMON ],
       [ Biome.METROPOLIS, BiomePoolTier.COMMON ]
@@ -7217,18 +7219,23 @@ export function initBiomes() {
     [ TrainerType.DANCER, []],
     [ TrainerType.DEPOT_AGENT, [
       [ Biome.METROPOLIS, BiomePoolTier.UNCOMMON ]
-    ]],
+    ]
+    ],
     [ TrainerType.DOCTOR, []],
+    [ TrainerType.FIREBREATHER, [
+      [ Biome.VOLCANO, BiomePoolTier.COMMON ]
+    ]
+    ],
     [ TrainerType.FISHERMAN, [
       [ Biome.LAKE, BiomePoolTier.COMMON ],
       [ Biome.BEACH, BiomePoolTier.COMMON ]
     ]
     ],
-    [ TrainerType.RICH, []],
     [ TrainerType.GUITARIST, [
       [ Biome.METROPOLIS, BiomePoolTier.UNCOMMON ],
       [ Biome.POWER_PLANT, BiomePoolTier.COMMON ]
-    ]],
+    ]
+    ],
     [ TrainerType.HARLEQUIN, []],
     [ TrainerType.HIKER, [
       [ Biome.MOUNTAIN, BiomePoolTier.COMMON ],
@@ -7236,13 +7243,24 @@ export function initBiomes() {
       [ Biome.BADLANDS, BiomePoolTier.COMMON ]
     ]
     ],
-    [ TrainerType.HOOLIGANS, []],
+    [ TrainerType.HOOLIGANS, [
+      [ Biome.SLUM, BiomePoolTier.UNCOMMON ]
+    ]
+    ],
     [ TrainerType.HOOPSTER, []],
     [ TrainerType.INFIELDER, []],
     [ TrainerType.JANITOR, []],
     [ TrainerType.LINEBACKER, []],
     [ TrainerType.MAID, []],
-    [ TrainerType.MUSICIAN, []],
+    [ TrainerType.MUSICIAN, [
+      [ Biome.MEADOW, BiomePoolTier.COMMON ]
+    ]
+    ],
+    [ TrainerType.HEX_MANIAC, [
+      [ Biome.RUINS, BiomePoolTier.UNCOMMON ],
+      [ Biome.GRAVEYARD, BiomePoolTier.UNCOMMON ]
+    ]
+    ],
     [ TrainerType.NURSERY_AIDE, []],
     [ TrainerType.OFFICER, [
       [ Biome.METROPOLIS, BiomePoolTier.COMMON ],
@@ -7256,8 +7274,15 @@ export function initBiomes() {
       [ Biome.MEADOW, BiomePoolTier.COMMON ]
     ]
     ],
-    [ TrainerType.PILOT, []],
+    [ TrainerType.PILOT, [
-    [ TrainerType.POKEFAN, []],
+      [ Biome.MOUNTAIN, BiomePoolTier.UNCOMMON ]
+    ]
+    ],
+    [ TrainerType.POKEFAN, [
+      [ Biome.GRASS, BiomePoolTier.UNCOMMON ],
+      [ Biome.MEADOW, BiomePoolTier.UNCOMMON ]
+    ]
+    ],
     [ TrainerType.PRESCHOOLER, []],
     [ TrainerType.PSYCHIC, [
       [ Biome.GRAVEYARD, BiomePoolTier.COMMON ],
@@ -7270,11 +7295,24 @@ export function initBiomes() {
       [ Biome.JUNGLE, BiomePoolTier.COMMON ]
     ]
     ],
-    [ TrainerType.RICH_KID, []],
+    [ TrainerType.RICH, [
+      [ Biome.ISLAND, BiomePoolTier.UNCOMMON ]
+    ]
+    ],
+    [ TrainerType.RICH_KID, [
+      [ Biome.METROPOLIS, BiomePoolTier.RARE ],
+      [ Biome.ISLAND, BiomePoolTier.COMMON ]
+    ]
+    ],
     [ TrainerType.ROUGHNECK, [
       [ Biome.SLUM, BiomePoolTier.COMMON ]
     ]
     ],
+    [ TrainerType.SAILOR, [
+      [ Biome.SEA, BiomePoolTier.COMMON ],
+      [ Biome.BEACH, BiomePoolTier.COMMON ]
+    ]
+    ],
     [ TrainerType.SCIENTIST, [
       [ Biome.DESERT, BiomePoolTier.COMMON ],
       [ Biome.RUINS, BiomePoolTier.COMMON ]
@@ -7317,20 +7355,6 @@ export function initBiomes() {
       [ Biome.TOWN, BiomePoolTier.COMMON ]
     ]
     ],
-    [ TrainerType.HEX_MANIAC, [
-      [ Biome.RUINS, BiomePoolTier.UNCOMMON ],
-      [ Biome.GRAVEYARD, BiomePoolTier.UNCOMMON ]
-    ]
-    ],
-    [ TrainerType.FIREBREATHER, [
-      [ Biome.VOLCANO, BiomePoolTier.COMMON ]
-    ]
-    ],
-    [ TrainerType.SAILOR, [
-      [ Biome.SEA, BiomePoolTier.COMMON ],
-      [ Biome.BEACH, BiomePoolTier.COMMON ]
-    ]
-    ],
     [ TrainerType.BROCK, [
       [ Biome.CAVE, BiomePoolTier.BOSS ]
     ]

src/data/dialogue.ts

@@ -312,6 +312,113 @@ export const trainerTypeDialogue: TrainerTypeDialogue = {
       victory: ["dialogue:sailor.victory.1", "dialogue:sailor.victory.2", "dialogue:sailor.victory.3"],
     },
   ],
+  [TrainerType.CLERK]: [
+    {
+      encounter: ["dialogue:clerk.encounter.1", "dialogue:clerk.encounter.2", "dialogue:clerk.encounter.3"],
+      victory: ["dialogue:clerk.victory.1", "dialogue:clerk.victory.2", "dialogue:clerk.victory.3"],
+    },
+    {
+      encounter: [
+        "dialogue:clerk_female.encounter.1",
+        "dialogue:clerk_female.encounter.2",
+        "dialogue:clerk_female.encounter.3",
+      ],
+      victory: [
+        "dialogue:clerk_female.victory.1",
+        "dialogue:clerk_female.victory.2",
+        "dialogue:clerk_female.victory.3",
+      ],
+    },
+  ],
+  [TrainerType.HOOLIGANS]: [
+    {
+      encounter: ["dialogue:hooligans.encounter.1", "dialogue:hooligans.encounter.2"],
+      victory: ["dialogue:hooligans.victory.1", "dialogue:hooligans.victory.2"],
+    },
+  ],
+  [TrainerType.MUSICIAN]: [
+    {
+      encounter: [
+        "dialogue:musician.encounter.1",
+        "dialogue:musician.encounter.2",
+        "dialogue:musician.encounter.3",
+        "dialogue:musician.encounter.4",
+      ],
+      victory: ["dialogue:musician.victory.1", "dialogue:musician.victory.2", "dialogue:musician.victory.3"],
+    },
+  ],
+  [TrainerType.PILOT]: [
+    {
+      encounter: [
+        "dialogue:pilot.encounter.1",
+        "dialogue:pilot.encounter.2",
+        "dialogue:pilot.encounter.3",
+        "dialogue:pilot.encounter.4",
+      ],
+      victory: [
+        "dialogue:pilot.victory.1",
+        "dialogue:pilot.victory.2",
+        "dialogue:pilot.victory.3",
+        "dialogue:pilot.victory.4",
+      ],
+    },
+  ],
+  [TrainerType.POKEFAN]: [
+    {
+      encounter: ["dialogue:pokefan.encounter.1", "dialogue:pokefan.encounter.2", "dialogue:pokefan.encounter.3"],
+      victory: ["dialogue:pokefan.victory.1", "dialogue:pokefan.victory.2", "dialogue:pokefan.victory.3"],
+    },
+    {
+      encounter: [
+        "dialogue:pokefan_female.encounter.1",
+        "dialogue:pokefan_female.encounter.2",
+        "dialogue:pokefan_female.encounter.3",
+      ],
+      victory: [
+        "dialogue:pokefan_female.victory.1",
+        "dialogue:pokefan_female.victory.2",
+        "dialogue:pokefan_female.victory.3",
+      ],
+    },
+  ],
+  [TrainerType.RICH]: [
+    {
+      encounter: ["dialogue:rich.encounter.1", "dialogue:rich.encounter.2", "dialogue:rich.encounter.3"],
+      victory: ["dialogue:rich.victory.1", "dialogue:rich.victory.2", "dialogue:rich.victory.3"],
+    },
+    {
+      encounter: [
+        "dialogue:rich_female.encounter.1",
+        "dialogue:rich_female.encounter.2",
+        "dialogue:rich_female.encounter.3",
+      ],
+      victory: ["dialogue:rich_female.victory.1", "dialogue:rich_female.victory.2", "dialogue:rich_female.victory.3"],
+    },
+  ],
+  [TrainerType.RICH_KID]: [
+    {
+      encounter: ["dialogue:rich_kid.encounter.1", "dialogue:rich_kid.encounter.2", "dialogue:rich_kid.encounter.3"],
+      victory: [
+        "dialogue:rich_kid.victory.1",
+        "dialogue:rich_kid.victory.2",
+        "dialogue:rich_kid.victory.3",
+        "dialogue:rich_kid.victory.4",
+      ],
+    },
+    {
+      encounter: [
+        "dialogue:rich_kid_female.encounter.1",
+        "dialogue:rich_kid_female.encounter.2",
+        "dialogue:rich_kid_female.encounter.3",
+      ],
+      victory: [
+        "dialogue:rich_kid_female.victory.1",
+        "dialogue:rich_kid_female.victory.2",
+        "dialogue:rich_kid_female.victory.3",
+        "dialogue:rich_kid_female.victory.4",
+      ],
+    },
+  ],
   [TrainerType.ROCKET_GRUNT]: [
     {
       encounter: [

src/data/trainer-config.ts

@@ -2141,7 +2141,15 @@ export const trainerConfigs: TrainerConfigs = {
     }),
   [TrainerType.HOOLIGANS]: new TrainerConfig(++t)
     .setDoubleOnly()
+    .setMoneyMultiplier(1.5)
     .setEncounterBgm(TrainerType.ROUGHNECK)
+    .setPartyTemplateFunc(() =>
+      getWavePartyTemplate(
+        trainerPartyTemplates.TWO_WEAK,
+        trainerPartyTemplates.TWO_AVG,
+        trainerPartyTemplates.ONE_AVG_ONE_STRONG,
+      ),
+    )
     .setSpeciesFilter(s => s.isOfType(PokemonType.POISON) || s.isOfType(PokemonType.DARK)),
   [TrainerType.HOOPSTER]: new TrainerConfig(++t).setMoneyMultiplier(1.2).setEncounterBgm(TrainerType.CYCLIST),
   [TrainerType.INFIELDER]: new TrainerConfig(++t).setMoneyMultiplier(1.2).setEncounterBgm(TrainerType.CYCLIST),
@@ -2149,7 +2157,14 @@ export const trainerConfigs: TrainerConfigs = {
   [TrainerType.LINEBACKER]: new TrainerConfig(++t).setMoneyMultiplier(1.2).setEncounterBgm(TrainerType.CYCLIST),
   [TrainerType.MAID]: new TrainerConfig(++t).setMoneyMultiplier(1.6).setEncounterBgm(TrainerType.RICH),
   [TrainerType.MUSICIAN]: new TrainerConfig(++t)
-    .setEncounterBgm(TrainerType.ROUGHNECK)
+    .setMoneyMultiplier(1.1)
+    .setEncounterBgm(TrainerType.POKEFAN)
+    .setPartyTemplates(
+      trainerPartyTemplates.FOUR_WEAKER,
+      trainerPartyTemplates.THREE_WEAK,
+      trainerPartyTemplates.TWO_WEAK_ONE_AVG,
+      trainerPartyTemplates.TWO_AVG,
+    )
     .setSpeciesFilter(s => !!s.getLevelMoves().find(plm => plm[1] === Moves.SING)),
   [TrainerType.HEX_MANIAC]: new TrainerConfig(++t)
     .setMoneyMultiplier(1.5)
@@ -2214,7 +2229,14 @@ export const trainerConfigs: TrainerConfigs = {
         ) || s.getLevelMoves().some(plm => plm[1] === Moves.RAIN_DANCE),
     ), // Mons with rain abilities or who learn Rain Dance by level
   [TrainerType.PILOT]: new TrainerConfig(++t)
+    .setMoneyMultiplier(1.75)
     .setEncounterBgm(TrainerType.CLERK)
+    .setPartyTemplates(
+      trainerPartyTemplates.THREE_WEAK,
+      trainerPartyTemplates.TWO_WEAK_ONE_AVG,
+      trainerPartyTemplates.TWO_AVG,
+      trainerPartyTemplates.THREE_AVG,
+    )
     .setSpeciesFilter(s => tmSpecies[Moves.FLY].indexOf(s.speciesId) > -1),
   [TrainerType.POKEFAN]: new TrainerConfig(++t)
     .setMoneyMultiplier(1.4)
@@ -2230,7 +2252,8 @@ export const trainerConfigs: TrainerConfigs = {
       trainerPartyTemplates.FOUR_WEAK_SAME,
       trainerPartyTemplates.FIVE_WEAK,
       trainerPartyTemplates.SIX_WEAKER_SAME,
-    ),
+    )
+    .setSpeciesFilter(s => tmSpecies[Moves.HELPING_HAND].indexOf(s.speciesId) > -1),
   [TrainerType.PRESCHOOLER]: new TrainerConfig(++t)
     .setMoneyMultiplier(0.2)
     .setEncounterBgm(TrainerType.YOUNGSTER)
@@ -2352,16 +2375,29 @@ export const trainerConfigs: TrainerConfigs = {
       [TrainerPoolTier.SUPER_RARE]: [Species.LARVESTA],
     }),
   [TrainerType.RICH]: new TrainerConfig(++t)
-    .setMoneyMultiplier(5)
+    .setMoneyMultiplier(3.25)
     .setName("Gentleman")
     .setHasGenders("Madame")
-    .setHasDouble("Rich Couple"),
+    .setHasDouble("Rich Couple")
+    .setPartyTemplates(
+      trainerPartyTemplates.THREE_WEAK,
+      trainerPartyTemplates.FOUR_WEAK,
+      trainerPartyTemplates.TWO_WEAK_ONE_AVG,
+      trainerPartyTemplates.THREE_AVG,
+    )
+    .setSpeciesFilter(s => s.isOfType(PokemonType.NORMAL) || s.isOfType(PokemonType.ELECTRIC)),
   [TrainerType.RICH_KID]: new TrainerConfig(++t)
-    .setMoneyMultiplier(3.75)
+    .setMoneyMultiplier(2.5)
     .setName("Rich Boy")
     .setHasGenders("Lady")
     .setHasDouble("Rich Kids")
-    .setEncounterBgm(TrainerType.RICH),
+    .setEncounterBgm(TrainerType.RICH)
+    .setPartyTemplates(
+      trainerPartyTemplates.FOUR_WEAKER,
+      trainerPartyTemplates.THREE_WEAK_SAME,
+      trainerPartyTemplates.TWO_WEAK_SAME_ONE_AVG,
+    )
+    .setSpeciesFilter(s => s.baseTotal <= 460),
   [TrainerType.ROUGHNECK]: new TrainerConfig(++t)
     .setMoneyMultiplier(1.4)
     .setEncounterBgm(TrainerType.ROUGHNECK)