innerthunder
70295280da
[Move] Implement Substitute ( #2559 )
...
* Implement Substitute
Squashed commit from working branch
* Fix integration test imports
* Use Override Helper utils + Fix Baton Pass test
* Update src/test/moves/substitute.test.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Fix test imports + nits
* Document RemoveAllSubstitutesAttr
* Fix some strict-null issues
* more strict-null fixes
* Fix baton pass test
* Reorganized Substitute translation keys
* Added checks for substitute in contact logic
* Clean up Unseen Fist contact logic
* Remove misleading comment in Download attr
* RIP phases.ts
* Fix imports post-phase migration
* Rewrite `move.canIgnoreSubstitute` to `move.hitsSubstitute`
* Also fixed interactions with Shell Trap and Beak Blast
* Removed some leftover `canIgnoreSubstitute`s
* fix issues after beta merge
* Status move effectiveness now accounts for substitute
* More edge case tests (Counter test failing)
* Fix Counter + Trap edge cases + add Fail messagesd
* Fix leftover nit
* Resolve leftover test issues
* Fix Sub offset carrying over to Trainer fights
* Hide substitute sprite during catch attempts
* Make substitutes baton-passable again
* Remove placeholder locale keys and SPLASH_ONLY
* Fix imports and other nits
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* ESLint
* Fix imports
* Fix incorrect `resetSprite` timing
* Fix substitute disappearing on hit (maybe?)
* More animation fixes (mostly for Roar)
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-13 12:46:22 -04:00
Tempoanon
526f9ae2bc
[Balance] Tweak evil boss teams, fix aesthetic details ( #4214 )
...
* oops
* Swap phero and nihi, fix typo
* Actually make the change
2024-09-13 12:44:42 -04:00
Amani H.
1cf075adc9
[Bug] Fix Guard Swap and Power Swap swapping all stats ( #4213 )
...
* [Bug] Fix `SwapStatStagesAttr` Oversight
* Remove SPLASH_ONLY Leftover
2024-09-13 12:31:25 -04:00
Lugiad
dd61950cb1
[Localization] Tiny FR adjustments ( #4212 )
...
* Update tutorial.json
* Update challenges.json
2024-09-13 12:31:00 -04:00
MokaStitcher
48c2bdf1d8
[Bug] fix starter select crash when a variant preference is incorrect ( #4209 )
2024-09-13 09:29:35 -04:00
NightKev
8409f39b8d
[Misc] Allow Meloetta's starting form to be selected ( #4192 )
...
* Allow Meloetta's starting form to be selected
* Meloetta won't change forms during a monotype challenge
Also removes reversion to Aria form when arena resets
2024-09-13 03:49:28 -07:00
NightKev
5f9bd21a51
[Test] Speed up tests and make enemy item override remove existing items ( #4203 )
...
* Make enemy held items override remove randomly generated items
Remove cries from tests
* Override callback delays to 1ms
2024-09-13 01:09:12 -04:00
chaosgrimmon
5f918ca001
[Sprite] Remove repeated animation frames ( #4205 )
...
* [Sprite] Remove fronts repeated frame data
* [Sprite] Remove shiny fronts repeated frame data
* [Sprite] Remove shiny fem fronts repeated frame data
* [Sprite] Remove fem fronts repeated frame data
* [Sprite] Remove backs repeated frame data
* [Sprite] Remove more backs repeated frame data
* [Sprite] Remove fem backs repeated frame data
* [Sprite] Remove shiny backs repeated frame data
* [Sprite] Remove more shiny backs repeated frame data
* [Sprite] Remove shiny fem backs repeated frame data
* [Sprite] Remove exp backs repeated frame data
* [Sprite] Remove shiny exp backs repeated frame data
* [Sprite] Remove exp fronts repeated frame data
* [Sprite] Remove shiny exp fronts repeated frame data
* [Sprite] Togedemaru exp shiny typo
* [Sprite] Togedemaru exp typo
2024-09-13 01:08:38 -04:00
NightKev
9026214f05
[Move] Mark Sky Drop as partial due to missing effects ( #4204 )
2024-09-13 01:07:43 -04:00
PrabbyDD
f80c073def
[Bug] Fix for Roost Grounds the User Rather than Removing Flying Typing#3984 ( #4164 )
...
* double checking tests on a new made branch for bug 3984
* roost test update
* added roost test file
* Roost test update
* removed random stackdump
* cleaned up message for roost
* fixed test file for linter
* cleaning up code and fixing some desync test issues
* Cleaned up more code and added case for double shock
* fixing some messages and putting burn up and double shock in same class
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-12 15:27:47 -04:00
Blitzy
ef4d2ec91e
[Balance] More Evil Team Adjustments ( #4056 )
...
* Update trainer-config.ts
* Update trainer-config.ts
* Devolve 98% of the list
* Update trainer-config.ts
* Update trainer-config.ts
* Update Pools / Minor Giovanni Changes
* Update trainer-config.ts
* Make Ghetsis2 Basculegion/Jellicent male
---------
Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-09-12 12:01:32 -04:00
AJ Fontaine
bfc4f2d1cd
[Balance] Tweak trainer evolution delay so trainers are more likely to use evolved Pokemon in later waves ( #4190 )
...
* Tweak trainer evolution delay
* Document getStrengthLevelDiff
2024-09-12 11:21:43 -04:00
Leo Kim
5724ed4a5c
[Enhancement] Add option for egg skip to settings ( #4193 )
...
* add option for egg skip
* change eggSkip variable name more descriptive to eggSkipPreference
* update requested changes from opaquer and tinylad and walker
* update requested change from tinylad
* update comment
2024-09-12 10:33:36 -04:00
Lugiad
c294e0846d
[Localization] Catalan translation batch ( #4194 )
...
* Update arena-flyout.json
* Update biome.json
* Update common.json
* Update menu.json
* Update nature.json
* Update pokemon-info.json
* Update pokemon-info.json
2024-09-12 10:22:30 -04:00
Chapybara-jp
d4d1788789
[Localisation] [JA] Translated modifier-type.json.json ( #4195 )
...
* Update ability-trigger.json
* Update ability.json
* Update arena-flyout.json
* Update arena-tag.json
* Update battle.json
* Update fight-ui-handler.json
* Update berry.json
* Update menu.json
* Update party-ui-handler.json
* Update starter-select-ui-handler.json
* Update tutorial.json
* Update move.json
* Update battle.json
* Update arena-flyout.json
* Update arena-flyout.json
* Update arena-tag.json
* Update party-ui-handler.json
* Update settings.json
* Update move-trigger.json
* Translate modifier-type.json
* Update modifier-type.json
* Translated modifier-type.json
* Update move-trigger.json
* Update move-trigger.json
* Update move-trigger.json
* Update modifier-type.json
2024-09-12 10:16:45 -04:00
Leo Kim
b422239a82
[Localization(ko)] Update Korean translation ( #4196 )
2024-09-12 10:16:10 -04:00
cam
2f0a53ba46
[Sprite] Added default head spots to spinda ( #4188 )
...
Spritesheets front & front shiny
2024-09-12 00:49:18 -04:00
AJ Fontaine
0af59bbb14
[Refactor] Fix linter issue ( #4191 )
2024-09-12 00:13:57 -04:00
Adrián T.
7ed7fec808
[BUG][UI/UX] Correction of errors when `` Save & Quit` and ` Log out`` ( #3105 )
...
* Fixes confirmation issues in SAVE_AND_QUIT and LOG_OUT
* Added LOADING mode to prevent spamming from SAVE_AND_QUIT and LOG_OUT buttons, and added option to set black background for LOADING mode
* Fixed conditional statement to ensure robustness in live environments to avoid potential issues in production
* Good overlay position
2024-09-11 23:12:20 -04:00
schmidtc1
28012b8d85
[Bug] Fixes Freezy Frost visual bug when attacking ally, and Freezy Frost not applying effects when fainting a target ( #3753 )
...
* Resolves bugs with freezy frost vs ally, and freezy frost fainting opp
* Adjusts unit tests, adds one more for doubles
* Refactor apply function to follow the async/await pattern
* Eslint fix attempt
* Update freezy_frost.test.ts
Remove js file extension
2024-09-11 22:20:24 -04:00
Madmadness65
6decd918e5
[Enhancement] Implement Tera-based form changes (Ogerpon and Terapagos) ( #4147 )
...
* Add Tera-based form changes
* Make teraType property private
2024-09-11 21:47:41 -04:00
Lylian BALL
8195373824
[Move] Add Retaliate double damage condition ( #1831 )
...
* Add retaliate double damage condition
* undo override changes
* add death history and bug fix where retaliate didn't work after 10 turns
* delete the unnecassary log
* optimization
* made some corrections
* add retaliate test as draft
* add retaliate test
* Update src/test/moves/retaliate.test.ts (delete log)
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* remove submodule
* Update src/test/moves/retaliate.test.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* update retaliate test
* Update src/test/moves/retaliate.test.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* update unit test
* remove wide lens for retaliate test
* Update src/test/moves/retaliate.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/battle.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/test/moves/retaliate.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Update src/test/moves/retaliate.test.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* optimization
* Fix indentation
* Use default values
* Add parentheses for clarity
* Update src/battle.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* Update src/battle.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* Update src/data/move.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* Update src/phases/faint-phase.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* Update src/phases/faint-phase.ts
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
* bug on import
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: schmidtc1 <62030095+schmidtc1@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-11 21:31:57 -04:00
NightKev
91d266ea74
[Bug] Burning Bulwark, King's Shield, Obstruct and Silk Trap no longer protect against status moves. ( #4106 )
...
* Obstruct et al no longer protect against status moves
* Remove `.js` from import
Co-authored-by: ImperialSympathizer <110984302+ben-lear@users.noreply.github.com>
* Add tsdocs for new/modified classes
* List relevant moves in tsdocs
---------
Co-authored-by: ImperialSympathizer <110984302+ben-lear@users.noreply.github.com>
2024-09-11 21:31:38 -04:00
NightKev
951b568590
[Documentation] Add some tsdocs to move.ts, mark rollout and iceball (P) ( #4099 )
...
* Add some tsdocs to `move.ts`, some misc cleanup
* Mark Rollout and Ice Ball as partial
2024-09-11 21:05:43 -04:00
flx-sta
18dc1029b7
[Misc] Update issue/feature template ( #4148 )
...
* simplify bug-report form. Add `Triage` label to bug & feature form
* Add repro textfield to bug form
* Fix typo
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-11 21:01:16 -04:00
Mumble
f294f034aa
[Bug] Run History displays Pokemon that have their natures changed during the run ( #4149 )
...
* Nature mints... spaghetti...
* Update src/ui/run-info-ui-handler.ts
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
* No effect when no items
---------
Co-authored-by: frutescens <info@laptop>
Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
2024-09-11 21:00:26 -04:00
NightKev
fec218b747
[Refactor] setTypeIcons explicitly handles null, mark it as such ( #4155 )
2024-09-11 20:59:57 -04:00
NightKev
d4cd74c8b7
[P2 Bug] Baddy Bad shouldn't activate Reflect if the target uses Protect, make gravity and water/mud sport ignore protect( #4180 )
2024-09-11 20:58:21 -04:00
Amani H.
a6d5fc66f2
[Balance] Disable Eviolite for G-Max Pokémon ( #4184 )
...
* [Balance] Disable Eviolite for G-Max Pokémon
* Add Documentation
2024-09-11 20:56:58 -04:00
chaosgrimmon
50a7500561
[Sprite] Fix animated Cursola ( #4186 )
...
* [Sprite] Index Cursola exp
* [Sprite] Index shiny Cursola exp
* [Sprite] Update exp Cursola variant palette
2024-09-11 19:46:38 -04:00
Jannik Tappert
b33d86a1db
[BUG] Make Tate & Liza have seeded randomness #4175
2024-09-11 13:55:13 -07:00
NightKev
ce9a75f074
Replace vi.fn() with () => null whenenver possible ( #4182 )
2024-09-11 13:54:42 -07:00
Lugiad
89dac46dfc
[Localization] Localization batch - [Not meant to be merged until last minute] ( #4127 )
...
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: Asdar <asdargmng@gmail.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: SangaraSorama <100420976+SangaraSorama@users.noreply.github.com>
2024-09-11 13:46:26 -07:00
Frederico Santos
abb133e253
Merge pull request #4167 from DayKev/beta
...
Synchronize beta with main
2024-09-11 15:38:23 +01:00
NightKev
9f82d796d3
Merge branch 'main' into beta
2024-09-11 07:29:18 -07:00
Leo Kim
e657322294
[Enhancement] Update instruction for gamepad in run history UI ( #4053 )
...
* update instruction for pad in run history UI
* move getGamepadType function to ui.ts
* Update src/ui/ui.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-09-10 23:45:53 -04:00
Amani H.
4808c07cf9
[Hotfix] Fix System Data Conversion Failure 2 ( #4159 )
2024-09-10 23:05:48 +01:00
flx-sta
e17bf592c2
[Bug] Use silent mode during tests (unless debugging!) + test workflow optimization ( #4154 )
...
* add :silent to all tests
but disable it if the runner is in debug mode!
* fix: use `--silent` instead of `:silent`
Cause the previous was npm scrpt specific (whops)
* remove env and replace with logic in each call
* reduce redundancy by checking out once
* move pre-test into `needs` after `checkout`
* use cache approach in pre-test
* add node.js install step to `setup` job
* WIP: setup -> pre-test -> all other tests
with using cache
* use matrix approach for tests
* fix matrix approach for tests
* fix wrong use of env var in `run-test-template.yml`
* test: out-comment `run-tests` to see whats wrong
* test: see if this works
* let's try using matrix again...
* make `node-version` input a string
* remove `node-version` input for now
* test: without a matrix fornow
* change usage of reuseable workflow call
* fix call of matrix.project
* try using working-dir
* try setup for pre-tests
* remove `runs-on` from run-tests
* fix some identations for run-tests
* add pre-test as requirement for running tests
* use `1` instead of `'1'` to check `runner.debug`
* add `options` input. Possible fix for debug = not silent
* try again...
* not as an ENV but inside
* move 2nd ${{ !runner.debug && '--silent' }} check into test-template
* fix printing `false` instead of empty-string on runner-debug check
* try a yml array approach
* test running with file include path
* make `project` always `main` for now
* remove all extra vitest workspaces
* adopt `shards` workflow in vitest
* fix workflow reference in tests.yml
* add missing `$` in test-shard-template.yml`
* chore: fix vitest.config.ts after merge
man.. cant trust these machines
* make `project` a variable. try to use inputs on job names
* adjust `test-shard-template` job name
2024-09-10 22:13:42 +01:00
flx-sta
14ace40634
[Misc] eslint rule to prevent .js imports ( #4160 )
...
* add `eslint-plugin-import-x` module
* add import eslint rules
* remove .js extensions
* rename account.spec to account.test
* move fontFace.setup into `setupFiles`
instead of importing it in `vitest.setup.ts`
2024-09-10 22:34:50 +02:00
MokaStitcher
d1b058fe3e
[UI] fix candy upgrade icon not updating after purchasing eggs ( #4153 )
2024-09-10 14:00:50 -04:00
AJ Fontaine
150ab3d1b2
[UI/UX] Make "CH-CHING!" sound when unlocking passive ( #4151 )
...
* Make "CH-CHING!" sound when unlocking passive
* Remove unused parameters in line above sound
2024-09-10 11:54:23 -04:00
Amani H.
bd4729b4c5
[Hotfix] Fix Lapsing Modifiers Not Rolling ( #4152 )
2024-09-10 16:53:40 +01:00
PigeonBar
5bf21a4f75
[Bug] Fix rare egg move and species rates for Manaphy eggs ( #4125 )
2024-09-10 10:15:07 -04:00
Madmadness65
4b8083211a
[P3 Bug] Fix Transform SFX not playing on quiet form changes ( #4144 )
2024-09-10 10:13:16 -04:00
MokaStitcher
9c4c19b5fb
[UI Bug] Fix HA icon not always showing in egg summary screen ( #4150 )
2024-09-10 10:12:17 -04:00
James Diefenbach
7dd1832072
[Hotfix] fix UI transition causing unusual freezes after egg summary shown ( #4126 )
...
* console logs n stuff
* fix bad ui transition for egg summary freeze bug (logs included)
* cleanup egg lapse phase
* touchup
* add back removed whitespace
* remove console logs
---------
Co-authored-by: James Diefenbach <z5421232@ad.unsw.edu.au>
2024-09-10 14:23:13 +01:00
Amani H.
ebb09dda34
[Hotfix] Fix Lures Refreshing on Reload ( #4146 )
2024-09-10 10:37:23 +01:00
Raidette
a919b9c0af
[Move] Implement After You ( #1789 )
...
* Complete after you implementation (no localization)
* reset override changes
* Remove hardcoded English text, add tests
* Fix test
* Make sure phases occur in the correct order
* fix after-you issues
- fix i18n interpolation ot state "target name" and not "pokemon name" as the target takes the offer, not the user
- fix some tsdocs
- add override to apply
- update scene.findPhase to be able to use generic types. Add tsdocs
* add move-trigger.afterYou for DE
* fix after_you.test.ts
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-09 14:35:04 -07:00
Adrian T.
e959595471
[Test] Fix throat chop and gorilla tactics tests ( #4140 )
2024-09-09 16:03:29 -04:00
Jannik Tappert
d9a8448c6e
[Enhancement] Added the ability to localize the tera type hover text ( #4138 )
2024-09-09 15:57:07 -04:00
