Commit Graph

3905 Commits

Author SHA1 Message Date
Leo Kim
91b32132d0
[Bug,Enhancement] Fix and improve Starter selector UI (#3340)
* apply offset to all hybrid filter

* make dropDownType to public for offsetHybridFilter function

* refactoring defaultSettings to additional suport default cursor.

* fix to remember last cursor on hover mode

* remove unnecessary reset code

* fix sort reset function

* update resetFilter function

* update requested changes

* remove log msg

* fix checking default on sort

* refactoring hasDefaultValues function for readability

* fix lastdir bug
2024-08-05 11:42:15 -04:00
flx-sta
97e362368c
[GH] Replace Feature request template with form (#3126)
* replace feature_request.md with feature_request.yml (form)

* fix typo and formatting in feature_request.yml
2024-08-05 11:41:38 -04:00
NightKev
063e6dbd2d
[Bug] Player pokemon shouldn't generate an NPC moveset (#3356)
* Player pokemon shouldn't generate an NPC moveset

* Make sure Keldeo starts new runs in the correct form
2024-08-05 10:22:06 -04:00
NightKev
68d3d27d47
[Test] Fix Power Spot test so Stonjourner always moves second (#3357) 2024-08-05 09:47:54 -04:00
NightKev
a301507f80
[Test] Remove held items from all tests when there are no item overrides (#3358) 2024-08-05 09:46:34 -04:00
innerthunder
32d4102594
[Bug] Fix Make It Rain and Clanging Scales stat drop trigger logic (#3355)
* Fix Make It Rain + Clanging Scales stat drop logic

* Use "includes" instead of "<" for firstTarget logic instead
2024-08-05 01:19:49 -04:00
Madmadness65
b6da93a092
Add ORAS Champion theme for Mixed music (#3351) 2024-08-04 19:45:29 -05:00
José Ricardo Fleury Oliveira
a8bb6e7a0b
[Localization] Update Portuguese translation for filter-bar.ts (#3353) 2024-08-04 20:41:29 -04:00
chaosgrimmon
0572ac4b91
[Sprite] Trim Skeledirge back exp palettes (#3350)
* [Sprite] Trim Skeledirge exp back palette

* [Sprite] Trim Skeledirge shiny back exp palette
2024-08-04 17:53:53 -04:00
DustinLin
d27e764e24
[Bug] Adding check to apply attr on moves that dont fail (parting shot) (#3195) 2024-08-04 15:14:16 -04:00
Tempoanon
84d89617ed
Update move.ts
Fixed accidentally added commas
2024-08-04 14:33:54 -04:00
Tempoanon
6f82d9c96c
Update move.ts
Mark future sight and doom desire as partial
2024-08-04 14:27:37 -04:00
Lugiad
fdf20837a6
[Localization] Small batch of French localization/adjustments (#3339)
* Update filter-bar.ts

* Update trainers.ts

* Update trainers.ts

* Update starter-select-ui-handler.ts

* Update starter-select-ui-handler.ts
2024-08-04 14:12:42 -04:00
NightKev
491f801d1c
[Refactor] Use tagType instead of manually passing BattlerTagType.BYPASS_SLEEP (#3338) 2024-08-04 14:12:22 -04:00
Jannik Tappert
6ce3468e04
[Localization] Fix some errors and transalte admin dialogue (#3335)
* Bring german translation up to date by fixing some errors and translating the admin dialogue

* Update src/locales/de/move-trigger.ts
2024-08-04 14:11:09 -04:00
NightKev
0241abcf61
[Bug] Fix evil team admins (#3341)
* Rename `flare_admin_m copy.json` to `flare_admin_f.json`

* Also fix the Magma Admins
2024-08-04 14:00:49 -04:00
Leo Kim
8b8ac416b8
[Bug] Fix blocking menu when 6 starter selected (#3333)
* fix bug of block menu when 6 starter

* update comment

* update comment again
2024-08-04 03:22:31 -04:00
MokaStitcher
0796a9fce8
[Enhancement] Improvements to starter selection and filtering user experience (#3325)
* [filter-ui] Improvements to starter selection and filtering user experience
Original messages of 14 squashed commits:
* final cleanup and code comments
* automatically go to the list of starters when closing filters
* FilterBar cleanup. Associate each DropDown with an id and access them through it
* reset all filters when creating a new game. Set different default gen filter for challenge mode
* start of code cleanup plus some documentation
* fix filter bar label coloring for legacy theme
* change generation filter default values to be all generations selected
* fix navigation between team and filtered Pokemon
* add missing localisation keys
* first pass at improving navigation between the UI elements
* have each filter group handle its default values instead of the filter bar
* revamp dropdown class. add possibility to display both a sprite and text label at the same time
* groundwork to be able to move around starter ui elements more easily
* add hybrid filtering type for Gen and Type filters, clean up implementation for radial type

* [loc][ko][zh] localisation of starter ui filters for Chinese and Korean

Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* [loc][de] German translations for the filters

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

---------

Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
2024-08-04 02:50:13 -04:00
Tempoanon
22349da663
Update phases.ts
Fixed a linting problem
2024-08-04 01:41:59 -04:00
chaosgrimmon
d879436751
[Sprite] Target FormSpriteKey-labelled sprite assets (#3322) 2024-08-04 01:06:51 -04:00
Jacob Knispel
ca64c4aaf2
[Bug] Skip forced switch if the fainted party member has been revived already (#1236) 2024-08-04 01:04:59 -04:00
damocleas
fdcf21592b
Update pokemon-species.ts (#3329) 2024-08-04 04:09:35 +01:00
Frederico Santos
42d00e208e
Revert "[Bug] fixed switch out bug when fainted single -> double (#3288)" (#3330)
This reverts commit 89d38a3b6b.
2024-08-04 04:09:06 +01:00
NightKev
10aa85e9db
Fix name of files for Aqua Admin (M) (#3323) 2024-08-03 17:04:57 -05:00
Tempoanon
7048fbe06f
[Feature] Implement generic evil team admins (#3234)
* [Hotfix] Fix interactions of some moves not changing types (#3183)

* [Hotfix] Fix wild spawns not having their HA (#3190)

* Add evil admin placeholder images

* Add admin names to locale files

* Add evil team admin dialogue

* Added new sprites

* Make simple admin trainer pools

* Add Korean localization

* Increase evil boss money multiplier from 2.25 to 2.5

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-08-03 16:34:05 -04:00
Madmadness65
153d8ba557
[Sprite] Move Victini graphics to Generation 5 atlases (#3320)
* Move Victini graphics to Generation 5 atlases

* Minor change
2024-08-03 15:03:59 -05:00
Mumble
3fa2088f5b
[Refactor] Merged implementation of CutHpStatBoostAttr moves (#3255)
* Merged implementation of CutHpStatBoostAttr moves

* Fixed failure check

* Fixed Belly Drum details

* Moved comment

* Tests for involved moves

* Fixed belly drum reference

* Added localization

* Manual merge

* Fixed issues discovered by Temp

* Updated moveset overrides to match new format

* Implementing Torranx's fixes

* Localized Belly Drum message to Belly Drum's initialization

* Post Caffeine Activation

* Actual Caffeine Fix-TypeDoc Test

---------

Co-authored-by: Frutescens <info@laptop>
2024-08-03 15:20:19 -04:00
Blitzy
cd1c810c5a
[Balance] Give Dipplin Dragon Cheer as a relearn move, give Applin Matcha Gotcha as egg move instead (#3291)
* Change Relearn Move

* Change Egg Move
2024-08-03 15:18:03 -04:00
Leo Kim
d20b7553ef
[Enhancement] Add confirm exit popup in starter select UI (#3316)
* add confirmExit popup

* add translation entries for `confirmExit`

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-08-03 15:16:29 -04:00
Leo Kim
800abc4767
[QoL] Auto filter for challenge mode in starter select (#3312) 2024-08-03 15:14:42 -04:00
Alex Van Liew
a2a1f3ec24
[Refactor] Refactored duplicated code into a common Pokemon#leaveField() function (#3310)
* refactor duplicated code into leaveField function

* replace bugfix code
2024-08-03 15:13:42 -04:00
chaosgrimmon
bb6ec94c02
[Sprite/Misc] Repo Icon cleanup (#3311)
* [Sprite] Missing Gen 7 variant icons

Taken from current icon spritesheet

* [Sprite] Remove non-Gen 6 icon

* Delete public/images/pokemon/icons/variant/6/742_3.png

* Delete public/images/pokemon/icons/variant/6/743_2.png

* Delete public/images/pokemon/icons/variant/6/743_3.png

* Delete public/images/pokemon/icons/variant/6/777_2.png

* Delete public/images/pokemon/icons/variant/6/777_3.png

* Delete public/images/pokemon/icons/variant/6/779_2.png

* Delete public/images/pokemon/icons/variant/6/779_3.png

* Delete public/images/pokemon/icons/variant/6/354-mega_2.png

* Delete public/images/pokemon/icons/variant/6/354-mega_3.png

* [Sprite] Missing Mega Banette variant icons

Taken from the Gen 6 variant icon folder

* [Sprite] Missing Poltchageist/Sinistcha form icons

Renamed duplicates of alternate forms
2024-08-03 15:12:32 -04:00
Leo Kim
32496fa585
[Misc] Move victini from gen 4 to gen 5 (#3306) 2024-08-03 15:11:05 -04:00
Lugiad
67babd0e83
[Localization] Fresh Start challenge entries added to French locales (#3317)
* Update achv.ts

* Update challenges.ts

* Update achv.ts
2024-08-03 15:09:58 -04:00
hayuna
cdc4826018
[Localization] Update fr locales in challenge (#3319) 2024-08-03 15:09:06 -04:00
Enoch
ec27c14035
[Localization] add missed move trigger and remove getPokemonMessage (#3281)
* localize missed move-trigger message and remove redundant getPokemonMessage

* Update src/locales/zh_CN/move-trigger.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_TW/move-trigger.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/de/move-trigger.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/data/move.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/de/move-trigger.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_TW/move-trigger.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_CN/move-trigger.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/fr/move-trigger.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/it/move-trigger.ts

Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>

* Revert "Update src/data/move.ts"

This reverts commit 4dd6130c39.

* fix italian param error

* Update src/locales/de/move-trigger.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/de/move-trigger.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/pt_BR/move-trigger.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

---------

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
2024-08-02 22:41:55 -04:00
allen925
3055d4500f
[Test] added revive function in gameManager & a double-battle test (#3298)
* added revive function in gamaManager & a double-battle test

* extended timeout of double battle test referencing to battle test

* less code, deleted unused param, clearer description of test

* add back dbond to move in test

* more straight forward testing

* reverse back override

* polish double battle test a bit
2024-08-02 22:30:50 -04:00
NightKev
e1812466a8
[Bug] Weather should be reset upon arena reset (#3301)
* `resetArenaEffects()` should also reset weather

* Update function doc
2024-08-02 22:29:07 -04:00
Opaque02
fc8b708785
[Misc] Tandemaus evolves into 3 family form at a rate of 25% (#2738) 2024-08-02 22:27:54 -04:00
Lugiad
6c6dc01490
[Localization] Small batch of missing French entires (#3309)
* Update trainers.ts

* Update bgm-name.ts

* Update bgm-name.ts
2024-08-02 22:14:09 -04:00
cam
03ba575ee5
[Sprite] Wo-Chien back sprite (#3307)
* [Fix][Sprite] 4083 Galarian Farfetch'd exp

Fixed cropped feet on exp for default & shiny.
Rearranged spritesheet to fit new size.
Both sritesheets have identical sprite framing.
Both json are identical.

* [Fix][Sprite] 1001 Wo-Chien exp fix

cleaned up tips of antlers
slightly improved back sprite
default + shiny. identical json, identical framing
2024-08-02 17:12:06 -04:00
AJ Fontaine
263924feda
[Item] Adjust White Herb weight and add Scope Lens to trainer item pool (#3308) 2024-08-02 17:11:54 -04:00
Frederico Santos
9f68ba8671 null or undefined? who knows. 2024-08-02 21:02:24 +01:00
Frederico Santos
2f83e6e2e1 explicit check for options 2024-08-02 19:28:05 +01:00
Frederico Santos
0d406b1092 hotfix cursor selection 2024-08-02 19:20:17 +01:00
Frederico Santos
3a87c8657f
Disable egg gacha in rewards (#3304)
* chore: Refactor excludedMenus logic in MenuUiHandler

* Refactor excludedMenus logic in MenuUiHandler

* Update src/ui/menu-ui-handler.ts

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* Refactor excludedMenus logic in MenuUiHandler

* chore: Add setup method to MenuUiHandler

* Refactor excludedMenus logic in MenuUiHandler

---------

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-08-02 18:26:49 +01:00
Tempoanon
52ef92ae78
[Enhancement] Add female and double grunts (#3280)
* Add female and double grunts, add localizations

* Update src/locales/fr/trainers.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/it/trainers.ts

Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>

* Update src/locales/ko/trainers.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/pt_BR/trainers.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update trainers.ts

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
2024-08-02 13:03:46 -04:00
Tempoanon
e5f458d2c0
[Bug] Fix affixes appearing when they shouldn't (#3236)
* [Hotfix] Fix interactions of some moves not changing types (#3183)

* [Hotfix] Fix wild spawns not having their HA (#3190)

* Fix some cases of wrong affixes

* There are two trainer send out messages

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-08-02 13:02:49 -04:00
Amani H.
302f1e51a0
[Enhancement] Allow Starters to Remember Egg Moves (#2482)
* Allow Starters to Remember Egg Moves

* Adjust Documentation

* Minor NIT
2024-08-02 17:51:20 +01:00
chaosgrimmon
abbf4974fd
[Sprite] Shiny animated Clawitzer using wrong palette (#3297)
* [Sprite] Recolour shiny Clawitzer

Palette taken from back counterpart

* [Sprite] Recolour shiny Clawitzer

Palette taken from back counterpart
2024-08-02 01:50:08 -04:00