Commit Graph

3436 Commits

Author SHA1 Message Date
flx-sta
f9d7b71fd6
[Refactor] allow null for ui mode constructor argument (#3407) 2024-08-07 14:31:57 -04:00
NightKev
3698f13f49
[Bug] Fix healing modifying the HP stat instead of the Pokemon's HP (#3406) 2024-08-07 14:14:02 -04:00
Chapybara-jp
b0ab207f84
[Localization(ja)] Translate egg.ts (#3405)
* Translate egg.ts

* Update egg.ts
2024-08-07 12:58:28 -04:00
flx-sta
a07d2c57a4
[Refactor] use typescript strict-null (#3259)
* TS: enable strict-null

* fix battle-scene.ts

* fix voucher.ts

* adapt more files to strict-null

* adapt more files to strict-null ( 2)

* adapt ability.ts to strict-null

* adapt `arena.ts` to strict-null

* adapt TagAddedEvent constructor to strict-null

* adapt phases.ts.to strict-null

* adapt status-effect.ts to strict-null

* adapt `account.ts` to strict-null

* adapt `configHandler.ts` to strict-null

* adapt `ability.ts` to strict-null

* adapt `biomes.ts` to strict-null

* adapt `challenge.ts` to strict-null

* adapt `daily-run.ts` to strict-null

* adapt `nature.ts` to strict-null

* adapt `pokemon-forms.ts` to strict-null

* adapt `tainer-names.ts` to strict-null

* adapt `types.ts` to strict-null

* adapt `weather.ts` to strict-null

* adapt `egg-hatch-phase.ts` to strict-null

* adapt `evolution-phase.ts` to strict-null

* adapt `pokemon-sprite-sparkle-handler.ts` to strict-null

* adapt `evolution-phase.ts` to strict-null

* adapt `game-mode.ts` to strict-null

* adapt `utils.ts` to strict-null

* adapt `voucher-ui-handler.ts` to strict-null

* adapt `src/ui/unavailable-modal-ui-handler.ts` to strict-null

* adapt `src/ui/ui.ts` to strict-null

* adapt `src/ui/ui-theme.ts` to strict-null

* adapt `src/ui/title-ui-handler.ts` to strict-null

* adapt `src/ui/time-of-day-widget.ts` to strict-null

* adapt `src/ui/text.ts` to strict-null

* adapt `src/ui/target-select-ui-handler.ts` to strict-null

* adapt `src/ui/settings/settings-keyboard-ui-handler.ts` to strict-null

* adapt more files to strict-null (3)

* adapt more files to strict-null (4)

* adapt more files (mostly tests) to strict-null (5)

* adapt more files to strict-null (6)

* adapt more files to strict-null (7)

* Update `src/data/pokemon-evolutions.ts` for strict-null

Partial update `src/data/pokemon-species.ts` for strict-null

* adapt more files to strict-null (8)

* adapt more files to strict-null (9)

* Strict some more nulls (still a few errors remaining)

* adapt rest of the files to strict-null (9)

* fix tests (check for null instead of undefined)

* repalce a lot of `??` with bangs

And added TODO notice as usual

* fix more tests

* all tests pass now

* fix broken game-loop after trainer battle

add some console.warn for missing cases and falling back to default

* remove guessed fallback from utils.rgbHexToRgba

* add TODO for this.currentBattle = null

* adjust   getPokemonById() return to include `null`

* fix compilation errors

* add test for pokemon.trySetStatus

* `chanceMultiplier` shouldn't be optional

* allow `null` for currentPhase

* adjust hasExpSprite logic for no keymatch found

* reduce bang usage in account.updateUserInfo()

* fix new strict-null issues after merge

* fix `strict-null` issues in dropdown.ts

and sand_spit.test.ts

* fix egg-gacha

* adapt gul_missile.test.ts to strict-null

* fix move.ts strict-null

* fix i18n.ts strict-null

* fix strict-null issues

* fix baton_pass test

after accidentially breaking it

* chore: fix compiler errors

* revert accidential changes in baton_pass.test.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-08-07 17:23:12 +01:00
Chapybara-jp
555d33c16c
[Localization(ja)] Update move.ts (#3403)
* Update move.ts

* Update move.ts
2024-08-07 11:46:39 -04:00
NightKev
548bd8978f
[Move] Add type immunity removal moves (Foresight, Odor Sleuth, Miracle Eye) (#3379)
* Update Foresight PR to current beta

Implements Foresight, Miracle Eye, and Odor Sleuth

* Add placeholder i18n strings

* Minor tsdoc updates

* Fix placement of evasion level modifier, add tests

* Add first batch of translations

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Second batch of translations

Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Add Catalan and Japanese translation placeholder strings

* Fix issue caused by merge

---------

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
2024-08-07 10:59:28 -04:00
Chapybara-jp
db3fae1180
[Localization(ja)] Update ability.ts (#3401)
- Changed description of Honey Gather, Ball Fetch and Pickup to properly reflect how they function in PokeRogue.
2024-08-07 10:38:11 -04:00
Jannik Tappert
60d19c9a2c
[Feature] Unique Evil Team Admins (#3384)
* Hardcoded Pokemon should have proper names

* Add evil admin placeholder images

* Add admin names to locale files

* Add evil team admin dialogue

* current things.

* rename

* team galactic wants to be special

* Revert debug changes

* Added Trainer Names and Titles

* [Hotfix] Fix interactions of some moves not changing types (#3183)

* [Hotfix] Fix wild spawns not having their HA (#3190)

* Add evil admin placeholder images

* Add admin names to locale files

* Add evil team admin dialogue

* Added new sprites

* Make simple admin trainer pools

* Add Korean localization

* Revert this

* [Feature] Named Evil Team Admins

* Dateien removed

* Revert override

* French only needs one pair of evil team bosses :)

* Some things Temp Mentioned in the PR

* Removed NoDuplicates again...Because it only works on the speciality pool....
Also reordered the second admin wave. So we guarantee it is never the same one

* German dialogue

* Offset

* Jördis just better

* Credit for the artists (see https://www.deviantart.com/icejkai/art/Magma-Admin-Courtney-Trainer-Sprite-544510574)

* Order

* Added tsdoc and named it more clear

* Fixed formatting and made it a void function

* Changed offset to number and updated tsdoch

* Improve readability

* Removed extra lines

* Fix this

* Revert override

* colress gets his own pool because @blitzy wants it (and i agree)

* Added Rood (some plasma sage guy)

* has voucher is not false by default. So only it will be set true for evil team leaders, gym leaders, elite 4 and champions

* Apply suggestions from code review

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: returntoice <dieandbecome@gmail.com>

* Added the localization also to japanese

* Update src/locales/ko/trainers.ts

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* CA

* Removed Colress

* Colress Last Stand

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
2024-08-07 10:31:02 -04:00
Enoch
1700658c5c
[Localization] Translate weather (Japanese) (#3399) 2024-08-07 10:26:18 -04:00
Leo Kim
c186d53f3e
[QoL] Update Normal -> Not Shiny. Remove no pokerus option (#3402) 2024-08-07 10:24:45 -04:00
NightKev
0ef329e8eb
[Test] Add helper function to modify the turn order for tests (#3374)
* Add helper function to modify the turn order for tests

* Replace manual speed modification with new helper function

* Replace `vi.spyOn()` instances with helper function
2024-08-07 13:52:20 +01:00
Jannik Tappert
df9596a9dc
Added catalan as a language (#3400) 2024-08-07 09:45:29 +01:00
innerthunder
a4c913d963
[Move] Implement (or re-implement?) Lucky Chant (#3352)
* Implement Lucky Chant

* Add i18n keys for NoCritTag messages

* Add Lucky Chant message translations (DE, FR, KO, PT-BR)

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Add ZH translations

Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>

* Add keys for JA locale

---------

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
2024-08-07 02:31:54 -04:00
Alex Van Liew
f555dd6dc8
[Bug] Fix a couple small issues with uturn and friends (#3321)
* prevent double-application of status contact abilities and switch out abilities

* use SwitchPhase for ForceSwitchOutAbAttr instead of switchOut()

* add tests for baton pass/uturn

* PR comments

* Update src/test/moves/baton_pass.test.ts

* add test for forced switch after mutual KO + revive

* tweak condition to fix uturn/baton pass

* improve docs

* style/typo nits from CR

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* CR feedback

* use doSelectPartyPokemon + rename

* int -> number

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-08-07 02:29:51 -04:00
sodam
d2e1340c0c
[Localization] Fixed some trainer names (ko) (#3397)
* fixed trainers name wrong

* removed note(it checked by LeKaaN with pokerogue wiki)

* removed unnecessary spaces
2024-08-07 00:37:22 -04:00
protimita
3277551ce4
[Localization] JA Translation move-trigger.ts (#3396)
Health translations need to be checked in-game to see if they are used correctly.
acquiredAbility is improvived.
2024-08-07 00:04:30 -04:00
Tempoanon
98ae2bc665
[Localization] Add Japanese Localization (#3332)
* Update fonts

* Add locales/ja files

* Add some more files

* Add more ui stuff

* Fix failing typescript doc being generated

* Add the 4 ui handlers

* Add i18n.ts

* Try something in text.ts

* Fix some more errors

* Add ja type icons

* Add missed message keys

* Update src/plugins/i18n.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/ui/text.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/plugins/i18n.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Apply TLs from xsn34kzx

Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>

* Translate essential text (move, ability descriptions)

* Translate missed move/ability

* Translated battle.ts

- All phrases are taken from USUM script via Poké Corpus https://abcboy101.github.io/poke-corpus/ 
(I used the USUM script because it is in hiragana/katakana. If we decide to change these phrases to Kanji later, I will refer to the SV script to modify them again.)
-

* Update battle.ts

* Update battle.ts

* Update src/locales/ja/battle.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update battle.ts

---------

Co-authored-by: EnochG1 <enoch.jwsong@gmail.com>
Co-authored-by: Amani H. <109637146+xsn34kzx@users.noreply.github.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
2024-08-06 20:36:07 -04:00
damocleas
2bdfe9315c
[Balance] Starter Costs Adjustments (Hitmon family, Jynx family, Bidoof) (#3389) 2024-08-06 17:30:05 -04:00
schmidtc1
da51d6ae12
[Bug] Fix moveset flyout not updating PP from Spite (#3388) 2024-08-06 16:59:17 -04:00
Adrian T.
9875fcc59d
[Ability] Partially implement Gulp Missile (#3327)
* implement gulp missile

* add tests

* change fly to dive

* show ability when reverting to normal form

* update ai score, tests

* update score condition

* adjust conditions, damage

* add underwater test

* update damage in test

* partial commit
2024-08-06 16:18:47 -04:00
NightKev
9eadce80c6
[Bug] Fix tier weights and remove unnecessary Math.min() (#3359) 2024-08-06 15:34:43 -04:00
schmidtc1
06ed89ef13
[Bug] Fix sketch being able to copy some unsketchable moves (#3386)
* Cherrypicks due to beta issues

* Adds flags to some unsketchable moves, adds typedoc

* Cherrypicks due to beta issues #2
2024-08-06 15:25:20 -04:00
Tempoanon
c722490f60
[Feature] Allow Phione eggs to have a 1/8 chance to hatch Manaphy (#2787)
* Add feature and debug DO NOT MERGE

* Remove debug stuff
2024-08-06 14:05:19 -04:00
Lugiad
d66d4d1eeb
[Localization] Missing translation placeholders of Fresh Start challenge in some languages (#3383)
* Update achv.ts

* Update challenges.ts

* Update achv.ts

* Update achv.ts

* Update challenges.ts

* Update challenges.ts

* Update achv.ts

* Update challenges.ts

* Update achv.ts

* Update src/locales/de/achv.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/pt_BR/challenges.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update achv.ts

* Update challenges.ts

* Update achv.ts

* Update challenges.ts

* Update achv.ts

* Update challenges.ts

* Update achv.ts

* Update challenges.ts

---------

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
2024-08-06 13:46:11 -04:00
Tempoanon
af56eee1cf
[Bug] Fix Storm moves having accuracy drops in sun/sand (#3381) 2024-08-06 12:20:23 -04:00
Lugiad
3a4eea51c6
[Localization] More French adjuestments (#3382)
* Update battle.ts

* Update starter-select-ui-handler.ts

* Update battle.ts
2024-08-06 12:17:34 -04:00
chaosgrimmon
ed1605de58
[Sprite] Clean up extra Drifblim-related files (#3371)
* Delete public/images/pokemon/variant/back/426_3.png

* Delete public/images/pokemon/variant/back/426_3.json
2024-08-06 10:15:54 -04:00
NightKev
877d0c6db8
[Test] Stylistic consistency pass on tests (#3378)
* Modify tests to use overrides helper functions

* Apply stylistic consistency to overrides in tests

Also remove some non-test-related expects()
2024-08-06 10:06:25 -04:00
damocleas
7e81b50214
Passive Changes (#3372) 2024-08-06 01:24:05 -05:00
Enoch
151e2647cb
[Localization][ko] Translate missed texts in filter bar. (#3370)
* Add missed translation and fix wrong message key

* change some text

* Update src/locales/ko/filter-bar.ts

* Update src/locales/ko/filter-bar.ts

* Add confirmExit translation
2024-08-06 01:08:04 -05:00
Leo Kim
20e52ed9a7
[QoL] Change Dex filter name to Caught (#3361)
* change filter name `Dex` to `Caught`

* fix mis changed entry

* Update src/locales/fr/filter-bar.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/de/filter-bar.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/pt_BR/filter-bar.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update src/locales/ko/filter-bar.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/zh_CN/filter-bar.ts

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update src/locales/zh_TW/filter-bar.ts

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
2024-08-05 22:54:31 -04:00
damocleas
1aa2c219bb
Update pokemon-species.ts (#3368) 2024-08-05 21:30:27 -05:00
AJ Fontaine
1711b6c7ae
[Balance] Set White Herb weight to 0 (#3366)
* Old Yeller White Herb

* ESLint, the accident was 5 years ago, you need to move on

* 'It is nothing, it is nothing...' -Archduke Franz Ferdinand
2024-08-05 21:00:57 -04:00
José Ricardo Fleury Oliveira
dba2adf44e
[Localization] Updated Portuguese filter-bar.ts and confirmExit in the starter select UI (#3363)
* [Localization] Updated Portuguese filter-bar.ts and confirmExit in the starter select UI

* typo
2024-08-05 20:08:12 -04:00
Mason S
1ec7190aba
[Bug] Cosplay Pikachu and Rotom forms not starting with signature moves (#3365)
Changed the level of the signature moves for Cosplay Pikachu and Rotom forms to be 1 instead of 0.
2024-08-05 20:07:13 -04:00
Tempoanon
6a58d1b928
[Misc] Update pull request template (#3360) 2024-08-05 12:02:53 -04:00
NightKev
0a77dcdb4f
[Bug] Sand Spit should only activate when hit with a damaging move (#3337)
* Sand Spit should only activate when hit with a damaging move

* Add tests for Sand Spit
2024-08-05 11:51:36 -04:00
Leo Kim
d323817eb9
[Enhancement] add filters for pokerus, HA, cost reduction (#3343)
* add filters for pokerus, HA, cost reduction

* add entries for translation

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>

* Update src/ui/starter-select-ui-handler.ts

Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>

---------

Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
2024-08-05 11:43:47 -04:00
Leo Kim
91b32132d0
[Bug,Enhancement] Fix and improve Starter selector UI (#3340)
* apply offset to all hybrid filter

* make dropDownType to public for offsetHybridFilter function

* refactoring defaultSettings to additional suport default cursor.

* fix to remember last cursor on hover mode

* remove unnecessary reset code

* fix sort reset function

* update resetFilter function

* update requested changes

* remove log msg

* fix checking default on sort

* refactoring hasDefaultValues function for readability

* fix lastdir bug
2024-08-05 11:42:15 -04:00
flx-sta
97e362368c
[GH] Replace Feature request template with form (#3126)
* replace feature_request.md with feature_request.yml (form)

* fix typo and formatting in feature_request.yml
2024-08-05 11:41:38 -04:00
NightKev
063e6dbd2d
[Bug] Player pokemon shouldn't generate an NPC moveset (#3356)
* Player pokemon shouldn't generate an NPC moveset

* Make sure Keldeo starts new runs in the correct form
2024-08-05 10:22:06 -04:00
NightKev
68d3d27d47
[Test] Fix Power Spot test so Stonjourner always moves second (#3357) 2024-08-05 09:47:54 -04:00
NightKev
a301507f80
[Test] Remove held items from all tests when there are no item overrides (#3358) 2024-08-05 09:46:34 -04:00
innerthunder
32d4102594
[Bug] Fix Make It Rain and Clanging Scales stat drop trigger logic (#3355)
* Fix Make It Rain + Clanging Scales stat drop logic

* Use "includes" instead of "<" for firstTarget logic instead
2024-08-05 01:19:49 -04:00
Madmadness65
b6da93a092
Add ORAS Champion theme for Mixed music (#3351) 2024-08-04 19:45:29 -05:00
José Ricardo Fleury Oliveira
a8bb6e7a0b
[Localization] Update Portuguese translation for filter-bar.ts (#3353) 2024-08-04 20:41:29 -04:00
chaosgrimmon
0572ac4b91
[Sprite] Trim Skeledirge back exp palettes (#3350)
* [Sprite] Trim Skeledirge exp back palette

* [Sprite] Trim Skeledirge shiny back exp palette
2024-08-04 17:53:53 -04:00
DustinLin
d27e764e24
[Bug] Adding check to apply attr on moves that dont fail (parting shot) (#3195) 2024-08-04 15:14:16 -04:00
Tempoanon
84d89617ed
Update move.ts
Fixed accidentally added commas
2024-08-04 14:33:54 -04:00
Tempoanon
6f82d9c96c
Update move.ts
Mark future sight and doom desire as partial
2024-08-04 14:27:37 -04:00