random-mirrors/smaeul-u-boot
1
0
Fork 0
mirror of https://github.com/smaeul/u-boot.git synced 2025-10-28 18:48:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

dm: gpio: Return error when pull up/down is requested but set_flags ops is not implmentated

Browse Source 
Currently in _dm_gpio_set_flags() when set_flags ops is not implemented
direction_output()/_input() is used, but pull up/down is not supported by
these ops.

Signed-off-by: Zixun LI <admin@hifiphile.com>
This commit is contained in:
Zixun LI 2024-10-21 17:04:51 +02:00 committed by Tom Rini
parent 15299fa5dd
commit 3c69a95b9a
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
drivers/gpio/gpio-uclass.c
View File

@ -705,6 +705,9 @@ static int _dm_gpio_set_flags(struct gpio_desc *desc, ulong flags)
if (ops->set_flags) { if (ops->set_flags) {
ret = ops->set_flags(dev, desc->offset, flags); ret = ops->set_flags(dev, desc->offset, flags);
} else { } else {
if (flags & GPIOD_MASK_PULL)
return -EINVAL;
if (flags & GPIOD_IS_OUT) { if (flags & GPIOD_IS_OUT) {
bool value = flags & GPIOD_IS_OUT_ACTIVE; bool value = flags & GPIOD_IS_OUT_ACTIVE;