mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-03 21:48:15 +00:00 
			
		
		
		
	net: dwmac_meson8b: do not set TX delay in TXID & RXID
When the PHY interface is set as TXID & RXID, the delays should be taken from DT,
but first they should not be hardcoded since the PHY driver will set them.
Fixes: 798424e857 ("net: designware: add Amlogic Meson8b & later glue driver")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
			
			
This commit is contained in:
		
							parent
							
								
									60e531fabf
								
							
						
					
					
						commit
						81d0edafd9
					
				@ -59,8 +59,6 @@ static int dwmac_setup_axg(struct udevice *dev, struct eth_pdata *edata)
 | 
			
		||||
	switch (edata->phy_interface) {
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_ID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_RXID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_TXID:
 | 
			
		||||
		/* Set RGMII mode */
 | 
			
		||||
		setbits_le32(plat->regs + ETH_REG_0, AXG_ETH_REG_0_PHY_INTF_RGMII |
 | 
			
		||||
						     AXG_ETH_REG_0_TX_PHASE(1) |
 | 
			
		||||
@ -69,6 +67,15 @@ static int dwmac_setup_axg(struct udevice *dev, struct eth_pdata *edata)
 | 
			
		||||
						     AXG_ETH_REG_0_CLK_EN);
 | 
			
		||||
		break;
 | 
			
		||||
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_RXID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_TXID:
 | 
			
		||||
		/* TOFIX: handle amlogic,tx-delay-ns & rx-internal-delay-ps from DT */
 | 
			
		||||
		setbits_le32(plat->regs + ETH_REG_0, AXG_ETH_REG_0_PHY_INTF_RGMII |
 | 
			
		||||
						     AXG_ETH_REG_0_TX_RATIO(4) |
 | 
			
		||||
						     AXG_ETH_REG_0_PHY_CLK_EN |
 | 
			
		||||
						     AXG_ETH_REG_0_CLK_EN);
 | 
			
		||||
		break;
 | 
			
		||||
 | 
			
		||||
	case PHY_INTERFACE_MODE_RMII:
 | 
			
		||||
		/* Set RMII mode */
 | 
			
		||||
		out_le32(plat->regs + ETH_REG_0, AXG_ETH_REG_0_PHY_INTF_RMII |
 | 
			
		||||
@ -90,8 +97,6 @@ static int dwmac_setup_gx(struct udevice *dev, struct eth_pdata *edata)
 | 
			
		||||
	switch (edata->phy_interface) {
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_ID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_RXID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_TXID:
 | 
			
		||||
		/* Set RGMII mode */
 | 
			
		||||
		setbits_le32(plat->regs + ETH_REG_0, GX_ETH_REG_0_PHY_INTF |
 | 
			
		||||
						     GX_ETH_REG_0_TX_PHASE(1) |
 | 
			
		||||
@ -101,6 +106,16 @@ static int dwmac_setup_gx(struct udevice *dev, struct eth_pdata *edata)
 | 
			
		||||
 | 
			
		||||
		break;
 | 
			
		||||
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_RXID:
 | 
			
		||||
	case PHY_INTERFACE_MODE_RGMII_TXID:
 | 
			
		||||
		/* TOFIX: handle amlogic,tx-delay-ns & rx-internal-delay-ps from DT */
 | 
			
		||||
		setbits_le32(plat->regs + ETH_REG_0, GX_ETH_REG_0_PHY_INTF |
 | 
			
		||||
						     GX_ETH_REG_0_TX_RATIO(4) |
 | 
			
		||||
						     GX_ETH_REG_0_PHY_CLK_EN |
 | 
			
		||||
						     GX_ETH_REG_0_CLK_EN);
 | 
			
		||||
 | 
			
		||||
		break;
 | 
			
		||||
 | 
			
		||||
	case PHY_INTERFACE_MODE_RMII:
 | 
			
		||||
		/* Set RMII mode */
 | 
			
		||||
		out_le32(plat->regs + ETH_REG_0, GX_ETH_REG_0_INVERT_RMII_CLK |
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user