random-mirrors/smaeul-u-boot
1
0
Fork 0
mirror of https://github.com/smaeul/u-boot.git synced 2025-10-14 04:46:01 +01:00
Code Issues Packages Projects Releases Wiki Activity

dm: core: Swap parameters of ofnode_write_prop()

Browse Source 
It is normal for the length to come after the value in libfdt. Follow this
same convention with ofnode.

Signed-off-by: Simon Glass <sjg@chromium.org>
This commit is contained in:
Simon Glass 2022-07-30 15:52:10 -06:00 committed by Tom Rini
parent 6571559449
commit be0789a8ee
3 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/core/ofnode.c
View File

@ -1105,8 +1105,8 @@ ofnode ofnode_by_prop_value(ofnode from, const char *propname,
} }
} }
int ofnode_write_prop(ofnode node, const char *propname, int len, int ofnode_write_prop(ofnode node, const char *propname, const void *value,
const void *value) int len)
{ {
const struct device_node *np = ofnode_to_np(node); const struct device_node *np = ofnode_to_np(node);
struct property *pp; struct property *pp;
@ -1161,7 +1161,7 @@ int ofnode_write_string(ofnode node, const char *propname, const char *value)
debug("%s: %s = %s", __func__, propname, value); debug("%s: %s = %s", __func__, propname, value);
return ofnode_write_prop(node, propname, strlen(value) + 1, value); return ofnode_write_prop(node, propname, value, strlen(value) + 1);
} }
int ofnode_set_enabled(ofnode node, bool value) int ofnode_set_enabled(ofnode node, bool value)

6
include/dm/ofnode.h
View File

@ -1114,13 +1114,13 @@ int ofnode_device_is_compatible(ofnode node, const char *compat);
* *
* @node: The node for whose property should be set * @node: The node for whose property should be set
* @propname: The name of the property to set * @propname: The name of the property to set
* @len: The length of the new value of the property
* @value: The new value of the property (must be valid prior to calling * @value: The new value of the property (must be valid prior to calling
* the function) * the function)
* @len: The length of the new value of the property
* Return: 0 if successful, -ve on error * Return: 0 if successful, -ve on error
*/ */
int ofnode_write_prop(ofnode node, const char *propname, int len, int ofnode_write_prop(ofnode node, const char *propname, const void *value,
const void *value); int len);
/** /**
* ofnode_write_string() - Set a string property of a ofnode * ofnode_write_string() - Set a string property of a ofnode

4
test/dm/ofnode.c
View File

@ -576,8 +576,8 @@ static int dm_test_ofnode_livetree_writing(struct unit_test_state *uts)
/* Non-existent in DTB */ /* Non-existent in DTB */
ut_asserteq_64(FDT_ADDR_T_NONE, dev_read_addr(dev)); ut_asserteq_64(FDT_ADDR_T_NONE, dev_read_addr(dev));
/* reg = 0x42, size = 0x100 */ /* reg = 0x42, size = 0x100 */
ut_assertok(ofnode_write_prop(node, "reg", 8, ut_assertok(ofnode_write_prop(node, "reg",
"\x00\x00\x00\x42\x00\x00\x01\x00")); "\x00\x00\x00\x42\x00\x00\x01\x00", 8));
ut_asserteq(0x42, dev_read_addr(dev)); ut_asserteq(0x42, dev_read_addr(dev));
/* Test disabling devices */ /* Test disabling devices */