random-mirrors/smaeul-u-boot
1
0
Fork 0
mirror of https://github.com/smaeul/u-boot.git synced 2025-11-04 05:50:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

usb: gadget: cdns3: Fix cdns3_ep_config() by setting ep.maxpacket

Browse Source 
The function cdns3_ep_config() calculates the maximum packet size based
on the Endpoint Type and the Gadget Speed and stores it in the variable
"max_packet_size". This value is then programmed in the USB Controller
for the corresponding Endpoint. This may result in a mismatch between
the maximum packet size programmed in the USB controller and the maximum
packet size seen by the UDC Core via "maxpacket" member of "struct usb_ep".
Additionally, since TD_SIZE is calculated in cdns3_ep_run_transfer() on the
basis of the maximum packet size stored in the "maxpacket" member of
"struct usb_ep", it may lead to an incorrect value of TD_SIZE when compared
with what the USB controller actually expects (max_packet_size).

Fix this.

Fixes: 7e91f6ccdc84 ("usb: Add Cadence USB3 host and gadget driver")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Link: https://lore.kernel.org/r/20241007121927.1680039-1-s-vadapalli@ti.com
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
This commit is contained in:
Siddharth Vadapalli 2024-10-07 17:49:27 +05:30 committed by Mattijs Korpershoek
parent ce1023de73
commit c54c72dec7
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
drivers/usb/cdns3/gadget.c
View File

@ -1637,6 +1637,14 @@ void cdns3_ep_config(struct cdns3_endpoint *priv_ep)
else else
priv_ep->trb_burst_size = 16; priv_ep->trb_burst_size = 16;
/*
* The Endpoint is configured to handle a maximum packet size of
* max_packet_size. Hence, set priv_ep->endpoint.maxpacket to
* max_packet_size. This is necessary to ensure that the TD_SIZE
* is calculated correctly in cdns3_ep_run_transfer().
*/
priv_ep->endpoint.maxpacket = max_packet_size;
ret = cdns3_ep_onchip_buffer_reserve(priv_dev, buffering + 1, ret = cdns3_ep_onchip_buffer_reserve(priv_dev, buffering + 1,
!!priv_ep->dir); !!priv_ep->dir);
if (ret) { if (ret) {