random-mirrors/smaeul-u-boot
1
0
Fork 0
mirror of https://github.com/smaeul/u-boot.git synced 2025-10-17 22:28:17 +01:00
Code Issues Packages Projects Releases Wiki Activity

net: phy: possible NULL dereference in fixed_phy_create()

Browse Source 
We check if phydev is NULL. Only but if it is non-NULL we set one
component of phydev. But even if it is NULL we set another. We should not
dereference NULL in either case.

Fixes: e24b58f5ed4f ("net: phy: don't require PHY interface mode during PHY creation")
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
Reviewed-by: Marek Behún <kabel@kernel.org>
This commit is contained in:
Heinrich Schuchardt 2022-07-11 19:40:13 +02:00 committed by Tom Rini
parent 8a3b69d2f2
commit ebb8ff61ad
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
drivers/net/phy/phy.c
View File

@ -984,10 +984,10 @@ struct phy_device *fixed_phy_create(ofnode node)
} }
phydev = phy_device_create(NULL, 0, PHY_FIXED_ID, false); phydev = phy_device_create(NULL, 0, PHY_FIXED_ID, false);
if (phydev) if (phydev) {
phydev->node = subnode; phydev->node = subnode;
phydev->interface = ofnode_read_phy_mode(node);
phydev->interface = ofnode_read_phy_mode(node); }
return phydev; return phydev;
} }