mirror of
https://github.com/smaeul/u-boot.git
synced 2025-10-24 17:48:14 +01:00
b1aade87ca
Commit 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
fixed cache alignment for systems with a D-CACHE.
However it introduced some performance regressions [1] on system
flashing huge images, such as Android.
On AM62x SK EVM, we also observe such performance penalty:
Sending sparse 'super' 1/2 (768793 KB) OKAY [ 23.954s]
Writing 'super' OKAY [ 75.926s]
Sending sparse 'super' 2/2 (629819 KB) OKAY [ 19.641s]
Writing 'super' OKAY [ 62.849s]
Finished. Total time: 182.474s
The reason for this is that we use an arbitrary small buffer
(info->blksz * 100) for transferring.
Fix it by using a bigger buffer (info->blksz * FASTBOOT_MAX_BLK_WRITE)
as suggested in the original's patch review [2].
With this patch, performance impact is mitigated:
Sending sparse 'super' 1/2 (768793 KB) OKAY [ 23.912s]
Writing 'super' OKAY [ 15.780s]
Sending sparse 'super' 2/2 (629819 KB) OKAY [ 19.581s]
Writing 'super' OKAY [ 17.192s]
Finished. Total time: 76.569s
[1] https://lore.kernel.org/r/20221118121323.4009193-1-gary.bisson@boundarydevices.com
[2] https://lore.kernel.org/r/all/43e4c17c-4483-ec8e-f843-9b4c5569bd18@seco.com/
Fixes: 62649165cb02 ("lib: sparse: Make CHUNK_TYPE_RAW buffer aligned")
Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
45 lines
954 B
C
45 lines
954 B
C
/* SPDX-License-Identifier: GPL-2.0+ */
|
|
/*
|
|
* Copyright 2014 Broadcom Corporation.
|
|
*/
|
|
|
|
#include <compiler.h>
|
|
#include <part.h>
|
|
#include <sparse_format.h>
|
|
|
|
#define FASTBOOT_MAX_BLK_WRITE 16384
|
|
|
|
#define ROUNDUP(x, y) (((x) + ((y) - 1)) & ~((y) - 1))
|
|
|
|
struct sparse_storage {
|
|
lbaint_t blksz;
|
|
lbaint_t start;
|
|
lbaint_t size;
|
|
void *priv;
|
|
|
|
lbaint_t (*write)(struct sparse_storage *info,
|
|
lbaint_t blk,
|
|
lbaint_t blkcnt,
|
|
const void *buffer);
|
|
|
|
lbaint_t (*reserve)(struct sparse_storage *info,
|
|
lbaint_t blk,
|
|
lbaint_t blkcnt);
|
|
|
|
void (*mssg)(const char *str, char *response);
|
|
};
|
|
|
|
static inline int is_sparse_image(void *buf)
|
|
{
|
|
sparse_header_t *s_header = (sparse_header_t *)buf;
|
|
|
|
if ((le32_to_cpu(s_header->magic) == SPARSE_HEADER_MAGIC) &&
|
|
(le16_to_cpu(s_header->major_version) == 1))
|
|
return 1;
|
|
|
|
return 0;
|
|
}
|
|
|
|
int write_sparse_image(struct sparse_storage *info, const char *part_name,
|
|
void *data, char *response);
|