Caleb Connolly 7554388c1d initcall: break loop immediately on failure
The current ordering always results in func pointing to the next
function in the init_sequence. e.g. if fdtdec_setup() fails, ret will
be set to the error code, then func will be updated to point to
initf_malloc(), only then is ret checked and the loop broken. The end
result of this is that the "initcall failed at ..." error will point you
to initf_malloc(), when the error actually occured in fdtdec_setup()!

This can be quite confusing and result in a lot of time wasted debugging
code that has nothing to do with the failure (ask me how I know :P).

Adjust the for loop to check ret immediately after the call and break
early so that func will correctly reference the failed function.

Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
2024-03-13 18:47:11 -04:00
..
2024-01-07 13:49:15 -07:00
2022-01-18 08:31:02 -05:00
2024-01-13 18:17:46 +01:00
2023-12-21 08:54:37 -05:00
2023-12-21 08:54:37 -05:00
2011-01-18 23:38:08 +01:00
2023-12-18 09:55:32 -05:00
2019-12-06 16:44:20 -05:00
2023-12-21 08:54:37 -05:00
2023-12-21 08:54:37 -05:00
2023-12-21 08:54:37 -05:00
2020-08-24 14:11:31 -04:00
2022-01-19 18:11:34 +01:00
2019-05-05 08:48:50 -04:00