mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-03 21:48:15 +00:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			34 lines
		
	
	
		
			690 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			34 lines
		
	
	
		
			690 B
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * Copyright (c) 2010-2016, NVIDIA CORPORATION.
 | 
						|
 */
 | 
						|
 | 
						|
#include <common.h>
 | 
						|
#include <asm/arch-tegra/gpu.h>
 | 
						|
 | 
						|
/*
 | 
						|
 * This function is called right before the kernel is booted. "blob" is the
 | 
						|
 * device tree that will be passed to the kernel.
 | 
						|
 */
 | 
						|
int ft_system_setup(void *blob, struct bd_info *bd)
 | 
						|
{
 | 
						|
	const char *gpu_compats[] = {
 | 
						|
#if defined(CONFIG_TEGRA124)
 | 
						|
		"nvidia,gk20a",
 | 
						|
#endif
 | 
						|
#if defined(CONFIG_TEGRA210)
 | 
						|
		"nvidia,gm20b",
 | 
						|
#endif
 | 
						|
	};
 | 
						|
	int i, ret;
 | 
						|
 | 
						|
	/* Enable GPU node if GPU setup has been performed */
 | 
						|
	for (i = 0; i < ARRAY_SIZE(gpu_compats); i++) {
 | 
						|
		ret = tegra_gpu_enable_node(blob, gpu_compats[i]);
 | 
						|
		if (ret)
 | 
						|
			return ret;
 | 
						|
	}
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 |