mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-10-27 01:58:19 +00:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			30 lines
		
	
	
		
			868 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			30 lines
		
	
	
		
			868 B
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  * Copyright 2008 (C) Bryan O'Donoghue
 | |
|  *
 | |
|  * Code copied & edited from Freescale mpc85xx stuff.
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <time.h>
 | |
| #include <linux/libfdt.h>
 | |
| #include <fdt_support.h>
 | |
| 
 | |
| DECLARE_GLOBAL_DATA_PTR;
 | |
| 
 | |
| void ft_cpu_setup(void *blob, struct bd_info *bd)
 | |
| {
 | |
| 	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
 | |
| 			     "timebase-frequency", get_tbclk(), 1);
 | |
| 	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
 | |
| 			     "bus-frequency", bd->bi_busfreq, 1);
 | |
| 	do_fixup_by_prop_u32(blob, "device_type", "cpu", 4,
 | |
| 			     "clock-frequency", bd->bi_intfreq, 1);
 | |
| 	do_fixup_by_compat_u32(blob, "fsl,pq1-soc", "clock-frequency",
 | |
| 			       bd->bi_intfreq, 1);
 | |
| 	do_fixup_by_compat_u32(blob, "fsl,cpm-brg", "clock-frequency",
 | |
| 			       gd->arch.brg_clk, 1);
 | |
| 
 | |
| 	fdt_fixup_memory(blob, (u64)bd->bi_memstart, (u64)bd->bi_memsize);
 | |
| }
 |