mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-04 05:50:17 +00:00 
			
		
		
		
	For UBI partitions ("partubi" in dfu_alt_info), dfu_fill_entity_mtd sets
the mtd.ubi flag; however other functions incorrectly check for nand.ubi
instead. Fix this by checking for the correct flag.
Signed-off-by: Guillermo Rodriguez <guille.rodriguez@gmail.com>
Cc: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Patrick Delaunay <patrick.delaunay@st.com>
		
	
			
		
			
				
	
	
		
			327 lines
		
	
	
		
			7.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			327 lines
		
	
	
		
			7.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * dfu_mtd.c -- DFU for MTD device.
 | 
						|
 *
 | 
						|
 * Copyright (C) 2019,STMicroelectronics - All Rights Reserved
 | 
						|
 *
 | 
						|
 * Based on dfu_nand.c
 | 
						|
 */
 | 
						|
 | 
						|
#include <common.h>
 | 
						|
#include <dfu.h>
 | 
						|
#include <mtd.h>
 | 
						|
#include <jffs2/load_kernel.h>
 | 
						|
#include <linux/err.h>
 | 
						|
 | 
						|
static bool mtd_is_aligned_with_block_size(struct mtd_info *mtd, u64 size)
 | 
						|
{
 | 
						|
	return !do_div(size, mtd->erasesize);
 | 
						|
}
 | 
						|
 | 
						|
static int mtd_block_op(enum dfu_op op, struct dfu_entity *dfu,
 | 
						|
			u64 offset, void *buf, long *len)
 | 
						|
{
 | 
						|
	u64 off, lim, remaining, lock_ofs, lock_len;
 | 
						|
	struct mtd_info *mtd = dfu->data.mtd.info;
 | 
						|
	struct mtd_oob_ops io_op = {};
 | 
						|
	int ret = 0;
 | 
						|
	bool has_pages = mtd->type == MTD_NANDFLASH ||
 | 
						|
			 mtd->type == MTD_MLCNANDFLASH;
 | 
						|
 | 
						|
	/* if buf == NULL return total size of the area */
 | 
						|
	if (!buf) {
 | 
						|
		*len = dfu->data.mtd.size;
 | 
						|
		return 0;
 | 
						|
	}
 | 
						|
 | 
						|
	off = lock_ofs = dfu->data.mtd.start + offset + dfu->bad_skip;
 | 
						|
	lim = dfu->data.mtd.start + dfu->data.mtd.size;
 | 
						|
 | 
						|
	if (off >= lim) {
 | 
						|
		printf("Limit reached 0x%llx\n", lim);
 | 
						|
		*len = 0;
 | 
						|
		return op == DFU_OP_READ ? 0 : -EIO;
 | 
						|
	}
 | 
						|
	/* limit request with the available size */
 | 
						|
	if (off + *len >= lim)
 | 
						|
		*len = lim - off;
 | 
						|
 | 
						|
	if (!mtd_is_aligned_with_block_size(mtd, off)) {
 | 
						|
		printf("Offset not aligned with a block (0x%x)\n",
 | 
						|
		       mtd->erasesize);
 | 
						|
		return 0;
 | 
						|
	}
 | 
						|
 | 
						|
	/* first erase */
 | 
						|
	if (op == DFU_OP_WRITE) {
 | 
						|
		struct erase_info erase_op = {};
 | 
						|
 | 
						|
		remaining = lock_len = round_up(*len, mtd->erasesize);
 | 
						|
		erase_op.mtd = mtd;
 | 
						|
		erase_op.addr = off;
 | 
						|
		erase_op.len = mtd->erasesize;
 | 
						|
		erase_op.scrub = 0;
 | 
						|
 | 
						|
		debug("Unlocking the mtd device\n");
 | 
						|
		ret = mtd_unlock(mtd, lock_ofs, lock_len);
 | 
						|
		if (ret && ret != -EOPNOTSUPP) {
 | 
						|
			printf("MTD device unlock failed\n");
 | 
						|
			return 0;
 | 
						|
		}
 | 
						|
 | 
						|
		while (remaining) {
 | 
						|
			if (erase_op.addr + remaining > lim) {
 | 
						|
				printf("Limit reached 0x%llx while erasing at offset 0x%llx\n",
 | 
						|
				       lim, off);
 | 
						|
				return -EIO;
 | 
						|
			}
 | 
						|
 | 
						|
			ret = mtd_erase(mtd, &erase_op);
 | 
						|
 | 
						|
			if (ret) {
 | 
						|
				/* Abort if its not a bad block error */
 | 
						|
				if (ret != -EIO) {
 | 
						|
					printf("Failure while erasing at offset 0x%llx\n",
 | 
						|
					       erase_op.fail_addr);
 | 
						|
					return 0;
 | 
						|
				}
 | 
						|
				printf("Skipping bad block at 0x%08llx\n",
 | 
						|
				       erase_op.addr);
 | 
						|
			} else {
 | 
						|
				remaining -= mtd->erasesize;
 | 
						|
			}
 | 
						|
 | 
						|
			/* Continue erase behind bad block */
 | 
						|
			erase_op.addr += mtd->erasesize;
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	io_op.mode = MTD_OPS_AUTO_OOB;
 | 
						|
	io_op.len = *len;
 | 
						|
	if (has_pages && io_op.len > mtd->writesize)
 | 
						|
		io_op.len = mtd->writesize;
 | 
						|
	io_op.ooblen = 0;
 | 
						|
	io_op.datbuf = buf;
 | 
						|
	io_op.oobbuf = NULL;
 | 
						|
 | 
						|
	/* Loop over to do the actual read/write */
 | 
						|
	remaining = *len;
 | 
						|
	while (remaining) {
 | 
						|
		if (off + remaining > lim) {
 | 
						|
			printf("Limit reached 0x%llx while %s at offset 0x%llx\n",
 | 
						|
			       lim, op == DFU_OP_READ ? "reading" : "writing",
 | 
						|
			       off);
 | 
						|
			if (op == DFU_OP_READ) {
 | 
						|
				*len -= remaining;
 | 
						|
				return 0;
 | 
						|
			} else {
 | 
						|
				return -EIO;
 | 
						|
			}
 | 
						|
		}
 | 
						|
 | 
						|
		/* Skip the block if it is bad */
 | 
						|
		if (mtd_is_aligned_with_block_size(mtd, off) &&
 | 
						|
		    mtd_block_isbad(mtd, off)) {
 | 
						|
			off += mtd->erasesize;
 | 
						|
			dfu->bad_skip += mtd->erasesize;
 | 
						|
			continue;
 | 
						|
		}
 | 
						|
 | 
						|
		if (op == DFU_OP_READ)
 | 
						|
			ret = mtd_read_oob(mtd, off, &io_op);
 | 
						|
		else
 | 
						|
			ret = mtd_write_oob(mtd, off, &io_op);
 | 
						|
 | 
						|
		if (ret) {
 | 
						|
			printf("Failure while %s at offset 0x%llx\n",
 | 
						|
			       op == DFU_OP_READ ? "reading" : "writing", off);
 | 
						|
			return -EIO;
 | 
						|
		}
 | 
						|
 | 
						|
		off += io_op.retlen;
 | 
						|
		remaining -= io_op.retlen;
 | 
						|
		io_op.datbuf += io_op.retlen;
 | 
						|
		io_op.len = remaining;
 | 
						|
		if (has_pages && io_op.len > mtd->writesize)
 | 
						|
			io_op.len = mtd->writesize;
 | 
						|
	}
 | 
						|
 | 
						|
	if (op == DFU_OP_WRITE) {
 | 
						|
		/* Write done, lock again */
 | 
						|
		debug("Locking the mtd device\n");
 | 
						|
		ret = mtd_lock(mtd, lock_ofs, lock_len);
 | 
						|
		if (ret && ret != -EOPNOTSUPP)
 | 
						|
			printf("MTD device lock failed\n");
 | 
						|
	}
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static int dfu_get_medium_size_mtd(struct dfu_entity *dfu, u64 *size)
 | 
						|
{
 | 
						|
	*size = dfu->data.mtd.info->size;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int dfu_read_medium_mtd(struct dfu_entity *dfu, u64 offset, void *buf,
 | 
						|
			       long *len)
 | 
						|
{
 | 
						|
	int ret = -1;
 | 
						|
 | 
						|
	switch (dfu->layout) {
 | 
						|
	case DFU_RAW_ADDR:
 | 
						|
		ret = mtd_block_op(DFU_OP_READ, dfu, offset, buf, len);
 | 
						|
		break;
 | 
						|
	default:
 | 
						|
		printf("%s: Layout (%s) not (yet) supported!\n", __func__,
 | 
						|
		       dfu_get_layout(dfu->layout));
 | 
						|
	}
 | 
						|
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static int dfu_write_medium_mtd(struct dfu_entity *dfu,
 | 
						|
				u64 offset, void *buf, long *len)
 | 
						|
{
 | 
						|
	int ret = -1;
 | 
						|
 | 
						|
	switch (dfu->layout) {
 | 
						|
	case DFU_RAW_ADDR:
 | 
						|
		ret = mtd_block_op(DFU_OP_WRITE, dfu, offset, buf, len);
 | 
						|
		break;
 | 
						|
	default:
 | 
						|
		printf("%s: Layout (%s) not (yet) supported!\n", __func__,
 | 
						|
		       dfu_get_layout(dfu->layout));
 | 
						|
	}
 | 
						|
 | 
						|
	return ret;
 | 
						|
}
 | 
						|
 | 
						|
static int dfu_flush_medium_mtd(struct dfu_entity *dfu)
 | 
						|
{
 | 
						|
	struct mtd_info *mtd = dfu->data.mtd.info;
 | 
						|
	u64 remaining;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	/* in case of ubi partition, erase rest of the partition */
 | 
						|
	if (dfu->data.mtd.ubi) {
 | 
						|
		struct erase_info erase_op = {};
 | 
						|
 | 
						|
		erase_op.mtd = dfu->data.mtd.info;
 | 
						|
		erase_op.addr = round_up(dfu->data.mtd.start + dfu->offset +
 | 
						|
					 dfu->bad_skip, mtd->erasesize);
 | 
						|
		erase_op.len = mtd->erasesize;
 | 
						|
		erase_op.scrub = 0;
 | 
						|
 | 
						|
		remaining = dfu->data.mtd.start + dfu->data.mtd.size -
 | 
						|
			    erase_op.addr;
 | 
						|
 | 
						|
		while (remaining) {
 | 
						|
			ret = mtd_erase(mtd, &erase_op);
 | 
						|
 | 
						|
			if (ret) {
 | 
						|
				/* Abort if its not a bad block error */
 | 
						|
				if (ret != -EIO)
 | 
						|
					break;
 | 
						|
				printf("Skipping bad block at 0x%08llx\n",
 | 
						|
				       erase_op.addr);
 | 
						|
			}
 | 
						|
 | 
						|
			/* Skip bad block and continue behind it */
 | 
						|
			erase_op.addr += mtd->erasesize;
 | 
						|
			remaining -= mtd->erasesize;
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static unsigned int dfu_polltimeout_mtd(struct dfu_entity *dfu)
 | 
						|
{
 | 
						|
	/*
 | 
						|
	 * Currently, Poll Timeout != 0 is only needed on nand
 | 
						|
	 * ubi partition, as sectors which are not used need
 | 
						|
	 * to be erased
 | 
						|
	 */
 | 
						|
	if (dfu->data.mtd.ubi)
 | 
						|
		return DFU_MANIFEST_POLL_TIMEOUT;
 | 
						|
 | 
						|
	return DFU_DEFAULT_POLL_TIMEOUT;
 | 
						|
}
 | 
						|
 | 
						|
int dfu_fill_entity_mtd(struct dfu_entity *dfu, char *devstr, char *s)
 | 
						|
{
 | 
						|
	char *st;
 | 
						|
	struct mtd_info *mtd;
 | 
						|
	bool has_pages;
 | 
						|
	int ret, part;
 | 
						|
 | 
						|
	mtd = get_mtd_device_nm(devstr);
 | 
						|
	if (IS_ERR_OR_NULL(mtd))
 | 
						|
		return -ENODEV;
 | 
						|
	put_mtd_device(mtd);
 | 
						|
 | 
						|
	dfu->dev_type = DFU_DEV_MTD;
 | 
						|
	dfu->data.mtd.info = mtd;
 | 
						|
 | 
						|
	has_pages = mtd->type == MTD_NANDFLASH || mtd->type == MTD_MLCNANDFLASH;
 | 
						|
	dfu->max_buf_size = has_pages ? mtd->erasesize : 0;
 | 
						|
 | 
						|
	st = strsep(&s, " ");
 | 
						|
	if (!strcmp(st, "raw")) {
 | 
						|
		dfu->layout = DFU_RAW_ADDR;
 | 
						|
		dfu->data.mtd.start = simple_strtoul(s, &s, 16);
 | 
						|
		s++;
 | 
						|
		dfu->data.mtd.size = simple_strtoul(s, &s, 16);
 | 
						|
	} else if ((!strcmp(st, "part")) || (!strcmp(st, "partubi"))) {
 | 
						|
		char mtd_id[32];
 | 
						|
		struct mtd_device *mtd_dev;
 | 
						|
		u8 part_num;
 | 
						|
		struct part_info *pi;
 | 
						|
 | 
						|
		dfu->layout = DFU_RAW_ADDR;
 | 
						|
 | 
						|
		part = simple_strtoul(s, &s, 10);
 | 
						|
 | 
						|
		sprintf(mtd_id, "%s,%d", devstr, part - 1);
 | 
						|
		printf("using id '%s'\n", mtd_id);
 | 
						|
 | 
						|
		mtdparts_init();
 | 
						|
 | 
						|
		ret = find_dev_and_part(mtd_id, &mtd_dev, &part_num, &pi);
 | 
						|
		if (ret != 0) {
 | 
						|
			printf("Could not locate '%s'\n", mtd_id);
 | 
						|
			return -1;
 | 
						|
		}
 | 
						|
 | 
						|
		dfu->data.mtd.start = pi->offset;
 | 
						|
		dfu->data.mtd.size = pi->size;
 | 
						|
		if (!strcmp(st, "partubi"))
 | 
						|
			dfu->data.mtd.ubi = 1;
 | 
						|
	} else {
 | 
						|
		printf("%s: Memory layout (%s) not supported!\n", __func__, st);
 | 
						|
		return -1;
 | 
						|
	}
 | 
						|
 | 
						|
	if (!mtd_is_aligned_with_block_size(mtd, dfu->data.mtd.start)) {
 | 
						|
		printf("Offset not aligned with a block (0x%x)\n",
 | 
						|
		       mtd->erasesize);
 | 
						|
		return -EINVAL;
 | 
						|
	}
 | 
						|
	if (!mtd_is_aligned_with_block_size(mtd, dfu->data.mtd.size)) {
 | 
						|
		printf("Size not aligned with a block (0x%x)\n",
 | 
						|
		       mtd->erasesize);
 | 
						|
		return -EINVAL;
 | 
						|
	}
 | 
						|
 | 
						|
	dfu->get_medium_size = dfu_get_medium_size_mtd;
 | 
						|
	dfu->read_medium = dfu_read_medium_mtd;
 | 
						|
	dfu->write_medium = dfu_write_medium_mtd;
 | 
						|
	dfu->flush_medium = dfu_flush_medium_mtd;
 | 
						|
	dfu->poll_timeout = dfu_polltimeout_mtd;
 | 
						|
 | 
						|
	/* initial state */
 | 
						|
	dfu->inited = 0;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 |