mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-03 21:48:15 +00:00 
			
		
		
		
	The DDR PHY training function, ddrphy_prepare_training() would not work if compiled with GCC 4.9. The struct ddrphy (arch/arm/include/asm/arch-uniphier/ddrphy-regs.h) is specified with __packed because it represents a hardware register mapping, but it turned out to cause a problem on GCC 4.9. If -mno-unaligned-access is specified (yes, it is in arch/arm/cpu/armv7/config.mk), GCC 4.9 is aware of the __attribute__((packed)) and generates extra instructions to perform the memory access in a way that does not cause unaligned access. (Actually it is not need here because the register base, the first argument of the ddrphy_prepare_training(), is always given with a 4-byte aligned address.) Anyway, as a result, readl() / writel() is divided into byte-wise accesses. The problem is that this hardware only accepts 4-byte register access. Byte-wise accesses lead to unexpected behavior. There are some options to avoid this problem. [1] Remove -mno-unaligned-access [2] Add __aligned(4) along with __packed to struct ddrphy [3] Remove __packed from struct ddrphy [1] solves the problem for ARMv7, but it does not for pre-ARMv6 and ARMv6-M architectures where -mno-unaligned-access is default. So, [1] does not seem reasonable in terms of code portability. Both [2] and [3] work well, but [2] seems too much. All the members of struct ddrphy have the u32 type. No padding would be inserted even if __packed is dropped. Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com> Reviewed-by: Tom Rini <trini@ti.com>
		
			
				
	
	
		
			173 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			173 lines
		
	
	
		
			6.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * UniPhier DDR PHY registers
 | 
						|
 *
 | 
						|
 * Copyright (C) 2014 Panasonic Corporation
 | 
						|
 *   Author: Masahiro Yamada <yamada.m@jp.panasonic.com>
 | 
						|
 *
 | 
						|
 * SPDX-License-Identifier:	GPL-2.0+
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef ARCH_DDRPHY_REGS_H
 | 
						|
#define ARCH_DDRPHY_REGS_H
 | 
						|
 | 
						|
#include <linux/compiler.h>
 | 
						|
 | 
						|
#ifndef __ASSEMBLY__
 | 
						|
 | 
						|
struct ddrphy {
 | 
						|
	u32 ridr;		/* Revision Identification Register */
 | 
						|
	u32 pir;		/* PHY Initialixation Register */
 | 
						|
	u32 pgcr[2];		/* PHY General Configuration Register */
 | 
						|
	u32 pgsr[2];		/* PHY General Status Register */
 | 
						|
	u32 pllcr;		/* PLL Control Register */
 | 
						|
	u32 ptr[5];		/* PHY Timing Register */
 | 
						|
	u32 acmdlr;		/* AC Master Delay Line Register */
 | 
						|
	u32 acbdlr;		/* AC Bit Delay Line Register */
 | 
						|
	u32 aciocr;		/* AC I/O Configuration Register */
 | 
						|
	u32 dxccr;		/* DATX8 Common Configuration Register */
 | 
						|
	u32 dsgcr;		/* DDR System General Configuration Register */
 | 
						|
	u32 dcr;		/* DRAM Configuration Register */
 | 
						|
	u32 dtpr[3];		/* DRAM Timing Parameters Register */
 | 
						|
	u32 mr0;		/* Mode Register 0 */
 | 
						|
	u32 mr1;		/* Mode Register 1 */
 | 
						|
	u32 mr2;		/* Mode Register 2 */
 | 
						|
	u32 mr3;		/* Mode Register 3 */
 | 
						|
	u32 odtcr;		/* ODT Configuration Register */
 | 
						|
	u32 dtcr;		/* Data Training Configuration Register */
 | 
						|
	u32 dtar[4];		/* Data Training Address Register */
 | 
						|
	u32 dtdr[2];		/* Data Training Data Register */
 | 
						|
	u32 dtedr[2];		/* Data Training Eye Data Register */
 | 
						|
	u32 rsv0[13];		/* Reserved */
 | 
						|
	u32 dcuar;		/* DCU Address Register */
 | 
						|
	u32 dcudr;		/* DCU Data Register */
 | 
						|
	u32 dcurr;		/* DCU Run Register */
 | 
						|
	u32 dculr;		/* DCU Loop Register */
 | 
						|
	u32 dcugcr;		/* DCU General Configuration Register */
 | 
						|
	u32 dcutpr;		/* DCU Timing Parameters Register */
 | 
						|
	u32 dcusr[2];		/* DCU Status Register */
 | 
						|
	u32 rsv1[8];		/* Reserved */
 | 
						|
	u32 bistrr;		/* BIST Run Register */
 | 
						|
	u32 bistwcr;		/* BIST Word Count Register */
 | 
						|
	u32 bistmskr[3];	/* BIST Mask Register */
 | 
						|
	u32 bistlsr;		/* BIST LFSR Sed Register */
 | 
						|
	u32 bistar[3];		/* BIST Address Register */
 | 
						|
	u32 bistudpr;		/* BIST User Data Pattern Register */
 | 
						|
	u32 bistgsr;		/* BIST General Status Register */
 | 
						|
	u32 bistwer;		/* BIST Word Error Register */
 | 
						|
	u32 bistber[4];		/* BIST Bit Error Register */
 | 
						|
	u32 bistwcsr;		/* BIST Word Count Status Register */
 | 
						|
	u32 bistfwr[3];		/* BIST Fail Word Register */
 | 
						|
	u32 rsv2[10];		/* Reserved */
 | 
						|
	u32 gpr[2];		/* General Purpose Register */
 | 
						|
	struct ddrphy_zq {	/* ZQ */
 | 
						|
		u32 cr[2];	/* Impedance Control Register */
 | 
						|
		u32 sr[2];	/* Impedance Status Register */
 | 
						|
	} zq[4];
 | 
						|
	struct ddrphy_datx8 {	/* DATX8 */
 | 
						|
		u32 gcr;	/* General Configuration Register */
 | 
						|
		u32 gsr[2];	/* General Status Register */
 | 
						|
		u32 bdlr[5];	/* Bit Delay Line Register */
 | 
						|
		u32 lcdlr[3];	/* Local Calibrated Delay Line Register */
 | 
						|
		u32 mdlr;	/* Master Delay Line Register */
 | 
						|
		u32 gtr;	/* General Timing Register */
 | 
						|
		u32 rsv[3];	/* Reserved */
 | 
						|
	} dx[9];
 | 
						|
};
 | 
						|
 | 
						|
#endif /* __ASSEMBLY__ */
 | 
						|
 | 
						|
#define PIR_INIT		(1 <<  0)	/* Initialization Trigger */
 | 
						|
#define PIR_ZCAL		(1 <<  1)	/* Impedance Calibration */
 | 
						|
#define PIR_PLLINIT		(1 <<  4)	/* PLL Initialization */
 | 
						|
#define PIR_DCAL		(1 <<  5)	/* DDL Calibration */
 | 
						|
#define PIR_PHYRST		(1 <<  6)	/* PHY Reset */
 | 
						|
#define PIR_DRAMRST		(1 <<  7)	/* DRAM Reset */
 | 
						|
#define PIR_DRAMINIT		(1 <<  8)	/* DRAM Initialization */
 | 
						|
#define PIR_WL			(1 <<  9)	/* Write Leveling */
 | 
						|
#define PIR_QSGATE		(1 << 10)	/* Read DQS Gate Training */
 | 
						|
#define PIR_WLADJ		(1 << 11)	/* Write Leveling Adjust */
 | 
						|
#define PIR_RDDSKW		(1 << 12)	/* Read Data Bit Deskew */
 | 
						|
#define PIR_WRDSKW		(1 << 13)	/* Write Data Bit Deskew */
 | 
						|
#define PIR_RDEYE		(1 << 14)	/* Read Data Eye Training */
 | 
						|
#define PIR_WREYE		(1 << 15)	/* Write Data Eye Training */
 | 
						|
#define PIR_LOCKBYP		(1 << 28)	/* PLL Lock Bypass */
 | 
						|
#define PIR_DCALBYP		(1 << 29)	/* DDL Calibration Bypass */
 | 
						|
#define PIR_ZCALBYP		(1 << 30)	/* Impedance Calib Bypass */
 | 
						|
#define PIR_INITBYP		(1 << 31)	/* Initialization Bypass */
 | 
						|
 | 
						|
#define PGSR0_IDONE		(1 <<  0)	/* Initialization Done */
 | 
						|
#define PGSR0_PLDONE		(1 <<  1)	/* PLL Lock Done */
 | 
						|
#define PGSR0_DCDONE		(1 <<  2)	/* DDL Calibration Done */
 | 
						|
#define PGSR0_ZCDONE		(1 <<  3)	/* Impedance Calibration Done */
 | 
						|
#define PGSR0_DIDONE		(1 <<  4)	/* DRAM Initialization Done */
 | 
						|
#define PGSR0_WLDONE		(1 <<  5)	/* Write Leveling Done */
 | 
						|
#define PGSR0_QSGDONE		(1 <<  6)	/* DQS Gate Training Done */
 | 
						|
#define PGSR0_WLADONE		(1 <<  7)	/* Write Leveling Adjust Done */
 | 
						|
#define PGSR0_RDDONE		(1 <<  8)	/* Read Bit Deskew Done */
 | 
						|
#define PGSR0_WDDONE		(1 <<  9)	/* Write Bit Deskew Done */
 | 
						|
#define PGSR0_REDONE		(1 << 10)	/* Read Eye Training Done */
 | 
						|
#define PGSR0_WEDONE		(1 << 11)	/* Write Eye Training Done */
 | 
						|
#define PGSR0_IERR		(1 << 16)	/* Initialization Error */
 | 
						|
#define PGSR0_PLERR		(1 << 17)	/* PLL Lock Error */
 | 
						|
#define PGSR0_DCERR		(1 << 18)	/* DDL Calibration Error */
 | 
						|
#define PGSR0_ZCERR		(1 << 19)	/* Impedance Calib Error */
 | 
						|
#define PGSR0_DIERR		(1 << 20)	/* DRAM Initialization Error */
 | 
						|
#define PGSR0_WLERR		(1 << 21)	/* Write Leveling Error */
 | 
						|
#define PGSR0_QSGERR		(1 << 22)	/* DQS Gate Training Error */
 | 
						|
#define PGSR0_WLAERR		(1 << 23)	/* Write Leveling Adj Error */
 | 
						|
#define PGSR0_RDERR		(1 << 24)	/* Read Bit Deskew Error */
 | 
						|
#define PGSR0_WDERR		(1 << 25)	/* Write Bit Deskew Error */
 | 
						|
#define PGSR0_REERR		(1 << 26)	/* Read Eye Training Error */
 | 
						|
#define PGSR0_WEERR		(1 << 27)	/* Write Eye Training Error */
 | 
						|
#define PGSR0_DTERR_SHIFT	28		/* Data Training Error Status*/
 | 
						|
#define PGSR0_DTERR		(7 << (PGSR0_DTERR_SHIFT))
 | 
						|
#define PGSR0_APLOCK		(1 << 31)	/* AC PLL Lock */
 | 
						|
 | 
						|
#define DXCCR_DQSRES_OPEN	(0 << 5)
 | 
						|
#define DXCCR_DQSRES_688_OHM	(1 << 5)
 | 
						|
#define DXCCR_DQSRES_611_OHM	(2 << 5)
 | 
						|
#define DXCCR_DQSRES_550_OHM	(3 << 5)
 | 
						|
#define DXCCR_DQSRES_500_OHM	(4 << 5)
 | 
						|
#define DXCCR_DQSRES_458_OHM	(5 << 5)
 | 
						|
#define DXCCR_DQSRES_393_OHM	(6 << 5)
 | 
						|
#define DXCCR_DQSRES_344_OHM	(7 << 5)
 | 
						|
 | 
						|
#define DXCCR_DQSNRES_OPEN	(0 << 9)
 | 
						|
#define DXCCR_DQSNRES_688_OHM	(1 << 9)
 | 
						|
#define DXCCR_DQSNRES_611_OHM	(2 << 9)
 | 
						|
#define DXCCR_DQSNRES_550_OHM	(3 << 9)
 | 
						|
#define DXCCR_DQSNRES_500_OHM	(4 << 9)
 | 
						|
#define DXCCR_DQSNRES_458_OHM	(5 << 9)
 | 
						|
#define DXCCR_DQSNRES_393_OHM	(6 << 9)
 | 
						|
#define DXCCR_DQSNRES_344_OHM	(7 << 9)
 | 
						|
 | 
						|
#define DTCR_DTRANK_SHIFT	4		/* Data Training Rank */
 | 
						|
#define DTCR_DTRANK_MASK	(0x3 << (DTCR_DTRANK_SHIFT))
 | 
						|
#define DTCR_DTMPR		(1 << 6)	/* Data Training using MPR */
 | 
						|
#define DTCR_RNKEN_SHIFT	24		/* Rank Enable */
 | 
						|
#define DTCR_RNKEN_MASK		(0xf << (DTCR_RNKEN_SHIFT))
 | 
						|
 | 
						|
#define DXGCR_WLRKEN_SHIFT	26		/* Write Level Rank Enable */
 | 
						|
#define DXGCR_WLRKEN_MASK	(0xf << (DXGCR_WLRKEN_SHIFT))
 | 
						|
 | 
						|
/* SoC-specific parameters */
 | 
						|
#define NR_DATX8_PER_DDRPHY	2
 | 
						|
 | 
						|
#if defined(CONFIG_MACH_PH1_LD4) || defined(CONFIG_MACH_PH1_SLD8)
 | 
						|
#define NR_DDRPHY_PER_CH		1
 | 
						|
#else
 | 
						|
#define NR_DDRPHY_PER_CH		2
 | 
						|
#endif
 | 
						|
 | 
						|
#define NR_DDRCH		2
 | 
						|
 | 
						|
#define DDRPHY_BASE(ch, phy)	(0x5bc01000 + 0x200000 * (ch) + 0x1000 * (phy))
 | 
						|
 | 
						|
#ifndef __ASSEMBLY__
 | 
						|
void ddrphy_init(struct ddrphy __iomem *phy, int freq, int size);
 | 
						|
void ddrphy_prepare_training(struct ddrphy __iomem *phy, int rank);
 | 
						|
int ddrphy_training(struct ddrphy __iomem *phy);
 | 
						|
#endif
 | 
						|
 | 
						|
#endif /* ARCH_DDRPHY_REGS_H */
 |