mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-10-31 20:18:18 +00:00 
			
		
		
		
	Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to.  This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value.  Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.
Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g.  COLD vs WARM resets).  As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).
To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely.  Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.
This transformation was done with the following coccinelle patch:
    @@
    expression argvalue;
    @@
    - reset_cpu(argvalue)
    + reset_cpu()
    @@
    identifier argname;
    type argtype;
    @@
    - reset_cpu(argtype argname)
    + reset_cpu(void)
    { ... }
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
		
	
			
		
			
				
	
	
		
			33 lines
		
	
	
		
			885 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			33 lines
		
	
	
		
			885 B
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  *  Processor reset using WDT.
 | |
|  *
 | |
|  * Copyright (C) 2012 Dmitry Bondar <bond@inmys.ru>
 | |
|  * Copyright (C) 2007 Sergey Kubushyn <ksi@koi8.net>
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <cpu_func.h>
 | |
| #include <asm/io.h>
 | |
| #include <asm/arch/timer_defs.h>
 | |
| #include <asm/arch/hardware.h>
 | |
| 
 | |
| void reset_cpu(void)
 | |
| {
 | |
| 	struct davinci_timer *const wdttimer =
 | |
| 		(struct davinci_timer *)DAVINCI_WDOG_BASE;
 | |
| 	writel(0x08, &wdttimer->tgcr);
 | |
| 	writel(readl(&wdttimer->tgcr) | 0x03, &wdttimer->tgcr);
 | |
| 	writel(0, &wdttimer->tim12);
 | |
| 	writel(0, &wdttimer->tim34);
 | |
| 	writel(0, &wdttimer->prd12);
 | |
| 	writel(0, &wdttimer->prd34);
 | |
| 	writel(readl(&wdttimer->tcr) | 0x40, &wdttimer->tcr);
 | |
| 	writel(readl(&wdttimer->wdtcr) | 0x4000, &wdttimer->wdtcr);
 | |
| 	writel(0xa5c64000, &wdttimer->wdtcr);
 | |
| 	writel(0xda7e4000, &wdttimer->wdtcr);
 | |
| 	writel(0x4000, &wdttimer->wdtcr);
 | |
| 	while (1)
 | |
| 		/*nothing*/;
 | |
| }
 |