mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-04 05:50:17 +00:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			46 lines
		
	
	
		
			662 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			46 lines
		
	
	
		
			662 B
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * (C) Copyright 2007
 | 
						|
 * Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
 | 
						|
 */
 | 
						|
 | 
						|
#include <common.h>
 | 
						|
#include <command.h>
 | 
						|
#include <irq_func.h>
 | 
						|
#include <cpu_func.h>
 | 
						|
#include <net.h>
 | 
						|
#include <netdev.h>
 | 
						|
#include <asm/processor.h>
 | 
						|
 | 
						|
int checkcpu(void)
 | 
						|
{
 | 
						|
	puts("CPU: SH4\n");
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int cpu_init (void)
 | 
						|
{
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int cleanup_before_linux (void)
 | 
						|
{
 | 
						|
	disable_interrupts();
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int do_reset(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
 | 
						|
{
 | 
						|
	disable_interrupts();
 | 
						|
	reset_cpu(0);
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int cpu_eth_init(struct bd_info *bis)
 | 
						|
{
 | 
						|
#ifdef CONFIG_SH_ETHER
 | 
						|
	sh_eth_initialize(bis);
 | 
						|
#endif
 | 
						|
	return 0;
 | 
						|
}
 |