mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-10-31 03:58:17 +00:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			52 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			52 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  * ARM-specific information for the 'bd' command
 | |
|  *
 | |
|  * (C) Copyright 2003
 | |
|  * Wolfgang Denk, DENX Software Engineering, wd@denx.de.
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <init.h>
 | |
| 
 | |
| DECLARE_GLOBAL_DATA_PTR;
 | |
| 
 | |
| void arch_print_bdinfo(void)
 | |
| {
 | |
| 	struct bd_info *bd = gd->bd;
 | |
| 
 | |
| 	bdinfo_print_num("arch_number", bd->bi_arch_number);
 | |
| #ifdef CONFIG_SYS_MEM_RESERVE_SECURE
 | |
| 	if (gd->arch.secure_ram & MEM_RESERVE_SECURE_SECURED) {
 | |
| 		bdinfo_print_num("Secure ram",
 | |
| 				 gd->arch.secure_ram &
 | |
| 				 MEM_RESERVE_SECURE_ADDR_MASK);
 | |
| 	}
 | |
| #endif
 | |
| #ifdef CONFIG_RESV_RAM
 | |
| 	if (gd->arch.resv_ram)
 | |
| 		bdinfo_print_num("Reserved ram", gd->arch.resv_ram);
 | |
| #endif
 | |
| #if !(CONFIG_IS_ENABLED(SYS_ICACHE_OFF) && CONFIG_IS_ENABLED(SYS_DCACHE_OFF))
 | |
| 	bdinfo_print_num("TLB addr", gd->arch.tlb_addr);
 | |
| #endif
 | |
| 	bdinfo_print_num("irq_sp", gd->irq_sp);	/* irq stack pointer */
 | |
| 	bdinfo_print_num("sp start ", gd->start_addr_sp);
 | |
| 	/*
 | |
| 	 * TODO: Currently only support for davinci SOC's is added.
 | |
| 	 * Remove this check once all the board implement this.
 | |
| 	 */
 | |
| #ifdef CONFIG_CLOCKS
 | |
| 	printf("ARM frequency = %ld MHz\n", bd->bi_arm_freq);
 | |
| 	printf("DSP frequency = %ld MHz\n", bd->bi_dsp_freq);
 | |
| 	printf("DDR frequency = %ld MHz\n", bd->bi_ddr_freq);
 | |
| #endif
 | |
| #ifdef CONFIG_BOARD_TYPES
 | |
| 	printf("Board Type  = %ld\n", gd->board_type);
 | |
| #endif
 | |
| #if CONFIG_VAL(SYS_MALLOC_F_LEN)
 | |
| 	printf("Early malloc usage: %lx / %x\n", gd->malloc_ptr,
 | |
| 	       CONFIG_VAL(SYS_MALLOC_F_LEN));
 | |
| #endif
 | |
| }
 |