Chen-Yu Tsai a85ba87dbe net: sun8i_emac: Drop redundant and incorrect setting of syscon register
In sun8i_emac_board_setup, the driver partially configures the syscon
register for H3 EPHY. However, the settings are incomplete, and
completely unusable. The correct settings are later set in
sun8i_emac_set_syscon, but the incorrect CLK_SEL setting persists.

It is incorrect to use CLK_SEL to select 25 MHz, as the SoC does not
have a 25 MHz clock the EPHY can use.

This patch removes the setting of the syscon register in board_setup,
and also moves set_syscon above mdio_init. While mdio_init does not
access the PHY, it is better to have the PHY parameters setup before
the MDIO bus is registered.

Fixes: a29710c525ff ("net: Add EMAC driver for H3/A83T/A64 SoCs.")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
2016-07-26 21:56:03 +02:00
..
2016-05-02 18:37:09 -04:00
2010-07-12 00:14:29 -07:00
2016-02-05 12:47:23 +08:00
2016-01-25 10:40:01 -05:00
2016-05-02 18:37:09 -04:00
2016-02-06 12:00:59 +01:00
2014-04-18 10:42:30 -04:00
2016-06-12 23:49:38 +02:00
2015-08-11 13:27:15 -05:00
2016-01-14 14:08:59 +01:00
2016-05-02 18:37:09 -04:00
2013-04-01 16:33:52 -04:00
2015-11-05 08:22:21 +01:00
2016-01-07 12:18:58 -07:00
2015-09-11 17:14:43 -04:00
2015-09-11 17:14:43 -04:00