mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-11-03 21:48:15 +00:00 
			
		
		
		
	The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include <asm/u-boot.h> #include <asm/u-boot.h> void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: <smpl> @@ typedef bd_t; @@ -bd_t +struct bd_info </smpl> Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
		
			
				
	
	
		
			86 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			86 lines
		
	
	
		
			1.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
// SPDX-License-Identifier: GPL-2.0+
 | 
						|
/*
 | 
						|
 * Copyright (c) 2011 The Chromium OS Authors.
 | 
						|
 */
 | 
						|
 | 
						|
#include <common.h>
 | 
						|
#include <cpu_func.h>
 | 
						|
#include <cros_ec.h>
 | 
						|
#include <dm.h>
 | 
						|
#include <init.h>
 | 
						|
#include <led.h>
 | 
						|
#include <os.h>
 | 
						|
#include <asm/test.h>
 | 
						|
#include <asm/u-boot-sandbox.h>
 | 
						|
 | 
						|
/*
 | 
						|
 * Pointer to initial global data area
 | 
						|
 *
 | 
						|
 * Here we initialize it.
 | 
						|
 */
 | 
						|
gd_t *gd;
 | 
						|
 | 
						|
/* Add a simple GPIO device */
 | 
						|
U_BOOT_DEVICE(gpio_sandbox) = {
 | 
						|
	.name = "sandbox_gpio",
 | 
						|
};
 | 
						|
 | 
						|
void flush_cache(unsigned long start, unsigned long size)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
#ifndef CONFIG_TIMER
 | 
						|
/* system timer offset in ms */
 | 
						|
static unsigned long sandbox_timer_offset;
 | 
						|
 | 
						|
void timer_test_add_offset(unsigned long offset)
 | 
						|
{
 | 
						|
	sandbox_timer_offset += offset;
 | 
						|
}
 | 
						|
 | 
						|
unsigned long timer_read_counter(void)
 | 
						|
{
 | 
						|
	return os_get_nsec() / 1000 + sandbox_timer_offset * 1000;
 | 
						|
}
 | 
						|
#endif
 | 
						|
 | 
						|
int dram_init(void)
 | 
						|
{
 | 
						|
	gd->ram_size = CONFIG_SYS_SDRAM_SIZE;
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int board_init(void)
 | 
						|
{
 | 
						|
	if (IS_ENABLED(CONFIG_LED))
 | 
						|
		led_default_state();
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
int ft_board_setup(void *fdt, struct bd_info *bd)
 | 
						|
{
 | 
						|
	/* Create an arbitrary reservation to allow testing OF_BOARD_SETUP.*/
 | 
						|
	return fdt_add_mem_rsv(fdt, 0x00d02000, 0x4000);
 | 
						|
}
 | 
						|
 | 
						|
#ifdef CONFIG_BOARD_LATE_INIT
 | 
						|
int board_late_init(void)
 | 
						|
{
 | 
						|
	struct udevice *dev;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	ret = uclass_first_device_err(UCLASS_CROS_EC, &dev);
 | 
						|
	if (ret && ret != -ENODEV) {
 | 
						|
		/* Force console on */
 | 
						|
		gd->flags &= ~GD_FLG_SILENT;
 | 
						|
 | 
						|
		printf("cros-ec communications failure %d\n", ret);
 | 
						|
		puts("\nPlease reset with Power+Refresh\n\n");
 | 
						|
		panic("Cannot init cros-ec device");
 | 
						|
		return -1;
 | 
						|
	}
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
#endif
 |