mirror of
				https://github.com/smaeul/u-boot.git
				synced 2025-10-31 03:58:17 +00:00 
			
		
		
		
	Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to.  This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value.  Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.
Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g.  COLD vs WARM resets).  As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).
To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely.  Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.
This transformation was done with the following coccinelle patch:
    @@
    expression argvalue;
    @@
    - reset_cpu(argvalue)
    + reset_cpu()
    @@
    identifier argname;
    type argtype;
    @@
    - reset_cpu(argtype argname)
    + reset_cpu(void)
    { ... }
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
		
	
			
		
			
				
	
	
		
			74 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			74 lines
		
	
	
		
			1.6 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier:    GPL-2.0
 | |
| /*
 | |
|  * Copyright (C) 2018 Marvell International Ltd.
 | |
|  *
 | |
|  * https://spdx.org/licenses
 | |
|  */
 | |
| 
 | |
| #include <common.h>
 | |
| #include <asm/armv8/mmu.h>
 | |
| #include <asm/global_data.h>
 | |
| #include <asm/io.h>
 | |
| #include <asm/arch/board.h>
 | |
| 
 | |
| DECLARE_GLOBAL_DATA_PTR;
 | |
| 
 | |
| #define OTX2_MEM_MAP_USED 4
 | |
| 
 | |
| /* +1 is end of list which needs to be empty */
 | |
| #define OTX2_MEM_MAP_MAX (OTX2_MEM_MAP_USED + CONFIG_NR_DRAM_BANKS + 1)
 | |
| 
 | |
| static struct mm_region otx2_mem_map[OTX2_MEM_MAP_MAX] = {
 | |
| 	{
 | |
| 		.virt = 0x800000000000UL,
 | |
| 		.phys = 0x800000000000UL,
 | |
| 		.size = 0x40000000000UL,
 | |
| 		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
 | |
| 			 PTE_BLOCK_NON_SHARE
 | |
| 	}, {
 | |
| 		.virt = 0x840000000000UL,
 | |
| 		.phys = 0x840000000000UL,
 | |
| 		.size = 0x40000000000UL,
 | |
| 		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
 | |
| 			 PTE_BLOCK_NON_SHARE
 | |
| 	}, {
 | |
| 		.virt = 0x880000000000UL,
 | |
| 		.phys = 0x880000000000UL,
 | |
| 		.size = 0x40000000000UL,
 | |
| 		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
 | |
| 			 PTE_BLOCK_NON_SHARE
 | |
| 	}, {
 | |
| 		.virt = 0x8c0000000000UL,
 | |
| 		.phys = 0x8c0000000000UL,
 | |
| 		.size = 0x40000000000UL,
 | |
| 		.attrs = PTE_BLOCK_MEMTYPE(MT_DEVICE_NGNRNE) |
 | |
| 			 PTE_BLOCK_NON_SHARE
 | |
| 	}
 | |
| };
 | |
| 
 | |
| struct mm_region *mem_map = otx2_mem_map;
 | |
| 
 | |
| void mem_map_fill(void)
 | |
| {
 | |
| 	int banks = OTX2_MEM_MAP_USED;
 | |
| 	u32 dram_start = CONFIG_SYS_TEXT_BASE;
 | |
| 
 | |
| 	for (int i = 0; i < CONFIG_NR_DRAM_BANKS; i++) {
 | |
| 		otx2_mem_map[banks].virt = dram_start;
 | |
| 		otx2_mem_map[banks].phys = dram_start;
 | |
| 		otx2_mem_map[banks].size = gd->ram_size;
 | |
| 		otx2_mem_map[banks].attrs = PTE_BLOCK_MEMTYPE(MT_NORMAL) |
 | |
| 					    PTE_BLOCK_NON_SHARE;
 | |
| 		banks = banks + 1;
 | |
| 	}
 | |
| }
 | |
| 
 | |
| u64 get_page_table_size(void)
 | |
| {
 | |
| 	return 0x80000;
 | |
| }
 | |
| 
 | |
| void reset_cpu(void)
 | |
| {
 | |
| }
 |