Fix strict mode

This commit is contained in:
Steve Faulkner 2020-09-10 18:39:52 -05:00
parent d494278488
commit 23599741d7
5 changed files with 18 additions and 14 deletions

View File

@ -3,8 +3,8 @@ import useSWR from "swr";
import { ProgressIndicator } from "office-ui-fabric-react/lib/ProgressIndicator";
import { Spinner, SpinnerSize } from "office-ui-fabric-react/lib/Spinner";
import { Stack } from "office-ui-fabric-react/lib/Stack";
import { listConnectionInfo } from "../../../Utils/arm/generatedClients/2020-04-01-notebooks/notebookWorkspaces";
import { NotebookWorkspaceConnectionInfoResult } from "../../../Utils/arm/generatedClients/2020-04-01-notebooks/types";
import { listConnectionInfo } from "../../../Utils/arm/generatedClients/2020-04-01-notebook/notebookWorkspaces";
import { NotebookWorkspaceConnectionInfoResult } from "../../../Utils/arm/generatedClients/2020-04-01-notebook/types";
import { userContext } from "../../../UserContext";
export interface MemoryUsageInfo {
@ -33,7 +33,7 @@ const fetchMemoryInfo = async (_key: unknown, connectionInfo: NotebookWorkspaceC
};
export const MemoryTrackerComponent: FunctionComponent = () => {
const { data: connectionInfo } = useSWR<NotebookWorkspaceConnectionInfoResult>(
const { data: connectionInfo } = useSWR(
[
"notebooksConnectionInfo",
userContext.subscriptionId,
@ -44,7 +44,7 @@ export const MemoryTrackerComponent: FunctionComponent = () => {
(_key, subscriptionId, resourceGroup, accountName, workspace) =>
listConnectionInfo(subscriptionId, resourceGroup, accountName, workspace)
);
const { data } = useSWR<any>(connectionInfo ? ["memoryUsage", connectionInfo] : null, fetchMemoryInfo, {
const { data } = useSWR(connectionInfo ? ["memoryUsage", connectionInfo] : null, fetchMemoryInfo, {
refreshInterval: 2000
});

View File

@ -14,7 +14,7 @@ export async function listByDatabaseAccount(
subscriptionId: string,
resourceGroupName: string,
accountName: string
): Promise<Types.NotebookWorkspaceListResult | unknown> {
): Promise<Types.NotebookWorkspaceListResult> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "GET", apiVersion });
}
@ -25,7 +25,7 @@ export async function get(
resourceGroupName: string,
accountName: string,
notebookWorkspaceName: string
): Promise<Types.NotebookWorkspace | unknown> {
): Promise<Types.NotebookWorkspace> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "GET", apiVersion });
}
@ -37,7 +37,7 @@ export async function createOrUpdate(
accountName: string,
notebookWorkspaceName: string,
body: Types.NotebookWorkspaceCreateUpdateParameters
): Promise<Types.NotebookWorkspace | unknown> {
): Promise<Types.NotebookWorkspace> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "PUT", apiVersion, body });
}
@ -48,7 +48,7 @@ export async function destroy(
resourceGroupName: string,
accountName: string,
notebookWorkspaceName: string
): Promise<void | unknown> {
): Promise<void> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "DELETE", apiVersion });
}
@ -59,7 +59,7 @@ export async function listConnectionInfo(
resourceGroupName: string,
accountName: string,
notebookWorkspaceName: string
): Promise<Types.NotebookWorkspaceConnectionInfoResult | unknown> {
): Promise<Types.NotebookWorkspaceConnectionInfoResult> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}/listConnectionInfo`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "POST", apiVersion });
}
@ -70,7 +70,7 @@ export async function regenerateAuthToken(
resourceGroupName: string,
accountName: string,
notebookWorkspaceName: string
): Promise<void | unknown> {
): Promise<void> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}/regenerateAuthToken`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "POST", apiVersion });
}
@ -81,7 +81,7 @@ export async function start(
resourceGroupName: string,
accountName: string,
notebookWorkspaceName: string
): Promise<void | unknown> {
): Promise<void> {
const path = `/subscriptions/${subscriptionId}/resourceGroups/${resourceGroupName}/providers/Microsoft.DocumentDB/databaseAccounts/${accountName}/notebookWorkspaces/${notebookWorkspaceName}/start`;
return armRequest({ host: configContext.ARM_ENDPOINT, path, method: "POST", apiVersion });
}

View File

@ -68,7 +68,7 @@
"./src/Utils/MessageValidation.ts",
"./src/Utils/OfferUtils.ts",
"./src/Utils/StringUtils.ts",
"./src/Utils/arm/generatedClients/2020-04-01/types.ts",
"./src/Utils/arm/generatedClients/2020-04-01-cosmos-db/types.ts",
"./src/quickstart.ts",
"./src/setupTests.ts",
"./src/workers/upload/definitions.ts"

View File

@ -14,7 +14,7 @@ But it does work well enough to generate a fully typed tree-shakeable client for
Results of this file should be checked into the repo.
*/
const rpname = "cosmos-db"; // Can also use "notebooks"
const rpname = "notebook"; // Can also use "notebooks"
// Array of strings to use for eventual output
const outputTypes: string[] = [""];
@ -79,12 +79,16 @@ function responseType(operation: Operation, namespace: string) {
if (operation.responses) {
return Object.keys(operation.responses)
.map((responseCode: string) => {
// "default" always seems to be an ErrorResponse which we do not want to include in the possible return type
if (responseCode === "default") {
return undefined;
}
if (!operation.responses[responseCode].schema) {
return "void";
}
return refToType(operation.responses[responseCode].schema.$ref, namespace);
})
.filter((value, index, array) => array.indexOf(value) === index)
.filter((value, index, array) => value && array.indexOf(value) === index) // Ensure all values are truthy and unique
.join(" | ");
}
return "unknown";