mirror of
https://github.com/Azure/cosmos-explorer.git
synced 2025-12-20 01:11:25 +00:00
Remove Tabs from ComponentRegisterer (#713)
Now that Tabs are being rendered via Tabs.tsx the knockout component names are not needed either.
This commit is contained in:
@@ -103,11 +103,8 @@ function TabPane({ tab, active }: { tab: Tab; active: boolean }) {
|
||||
ko.applyBindings(tab, element);
|
||||
const ctx = ko.contextFor(element).createChildContext(tab);
|
||||
ko.applyBindingsToDescendants(ctx, element);
|
||||
return () => ko.cleanNode(element);
|
||||
}
|
||||
|
||||
if ("render" in tab) {
|
||||
tab.isTemplateReady(true);
|
||||
return () => ko.cleanNode(element);
|
||||
}
|
||||
}, [ref, tab]);
|
||||
|
||||
@@ -115,5 +112,5 @@ function TabPane({ tab, active }: { tab: Tab; active: boolean }) {
|
||||
return <div {...attrs}>{tab.render()}</div>;
|
||||
}
|
||||
|
||||
return <div {...attrs} ref={ref} data-bind="html: constructor.component.template" />;
|
||||
return <div {...attrs} ref={ref} data-bind="html:html" />;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user