Remove token from the URL for the websocket connections (#1591)
This commit is contained in:
parent
c8e7e69aa5
commit
f8ff0626d9
|
@ -100,9 +100,6 @@ const addInitialCodeCellEpic = (
|
|||
*/
|
||||
const formWebSocketURL = (serverConfig: NotebookServiceConfig, kernelId: string, sessionId?: string): string => {
|
||||
const params = new URLSearchParams();
|
||||
if (serverConfig.token) {
|
||||
params.append("token", serverConfig.token);
|
||||
}
|
||||
if (sessionId) {
|
||||
params.append("session_id", sessionId);
|
||||
}
|
||||
|
|
|
@ -47,10 +47,9 @@ export class JupyterLabAppFactory {
|
|||
}
|
||||
|
||||
public async createTerminalApp(serverSettings: ServerConnection.ISettings): Promise<ITerminalConnection | undefined> {
|
||||
//Need to add this after we remove passing token through url
|
||||
//const configurationSettings: Partial<ServerConnection.ISettings> = serverSettings;
|
||||
//(configurationSettings.appendToken as boolean) = false;
|
||||
//serverSettings = ServerConnection.makeSettings(configurationSettings);
|
||||
const configurationSettings: Partial<ServerConnection.ISettings> = serverSettings;
|
||||
(configurationSettings.appendToken as boolean) = false;
|
||||
serverSettings = ServerConnection.makeSettings(configurationSettings);
|
||||
const manager = new TerminalManager({
|
||||
serverSettings: serverSettings,
|
||||
});
|
||||
|
|
Loading…
Reference in New Issue