random-mirrors/cosmos-explorer
1
0
Fork 0
mirror of https://github.com/Azure/cosmos-explorer.git synced 2024-11-25 15:06:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove token from the URL for the websocket connections (#1591)

Browse Source
This commit is contained in:
Karthik chakravarthy 2023-08-30 15:54:20 -04:00 committed by GitHub
parent c8e7e69aa5
commit f8ff0626d9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/Explorer/Notebook/NotebookComponent/epics.ts
View File

@ -100,9 +100,6 @@ const addInitialCodeCellEpic = (
*/ */
const formWebSocketURL = (serverConfig: NotebookServiceConfig, kernelId: string, sessionId?: string): string => { const formWebSocketURL = (serverConfig: NotebookServiceConfig, kernelId: string, sessionId?: string): string => {
const params = new URLSearchParams(); const params = new URLSearchParams();
if (serverConfig.token) {
params.append("token", serverConfig.token);
}
if (sessionId) { if (sessionId) {
params.append("session_id", sessionId); params.append("session_id", sessionId);
} }

7
src/Terminal/JupyterLabAppFactory.ts
View File

@ -47,10 +47,9 @@ export class JupyterLabAppFactory {
} }
public async createTerminalApp(serverSettings: ServerConnection.ISettings): Promise<ITerminalConnection | undefined> { public async createTerminalApp(serverSettings: ServerConnection.ISettings): Promise<ITerminalConnection | undefined> {
//Need to add this after we remove passing token through url const configurationSettings: Partial<ServerConnection.ISettings> = serverSettings;
//const configurationSettings: Partial<ServerConnection.ISettings> = serverSettings; (configurationSettings.appendToken as boolean) = false;
//(configurationSettings.appendToken as boolean) = false; serverSettings = ServerConnection.makeSettings(configurationSettings);
//serverSettings = ServerConnection.makeSettings(configurationSettings);
const manager = new TerminalManager({ const manager = new TerminalManager({
serverSettings: serverSettings, serverSettings: serverSettings,
}); });