Merge branch 'master' into remove-jquery-typeahead

.eslintignore

@@ -8,6 +8,9 @@ src/Bindings/BindingHandlersRegisterer.ts
 src/Bindings/ReactBindingHandler.ts
 src/Common/Constants.ts
 src/Common/CosmosClient.test.ts
+src/Common/CosmosClient.ts
+src/Common/DataAccessUtilityBase.test.ts
+src/Common/DataAccessUtilityBase.ts
 src/Common/EditableUtility.ts
 src/Common/HashMap.test.ts
 src/Common/Logger.test.ts
@@ -17,7 +20,6 @@ src/Common/MongoProxyClient.test.ts
 src/Common/MongoUtility.ts
 src/Common/NotificationsClientBase.ts
 src/Common/QueriesClient.ts
-src/Common/UrlUtility.ts
 src/Common/Splitter.ts
 src/Config.ts
 src/Contracts/ActionContracts.ts

src/Common/CosmosClient.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import * as Cosmos from "@azure/cosmos";
 import { RequestInfo, setAuthorizationTokenHeaderUsingMasterKey } from "@azure/cosmos";
 import { configContext, Platform } from "../ConfigContext";
@@ -81,9 +80,7 @@ export async function getTokenFromAuthService(verb: string, resourceType: string
 let _client: Cosmos.CosmosClient;
 
 export function client(): Cosmos.CosmosClient {
-  if (_client) {
-    return _client;
-  }
+  if (_client) return _client;
   const options: Cosmos.CosmosClientOptions = {
     endpoint: endpoint() || "https://cosmos.azure.com", // CosmosClient gets upset if we pass a bad URL. This should never actually get called
     key: userContext.masterKey,

src/Common/Splitter.ts

@@ -36,10 +36,7 @@ export class Splitter {
   }
 
   public initialize() {
-    if (
-      document.getElementById(this.splitterId) !== undefined &&
-      document.getElementById(this.leftSideId) !== undefined
-    ) {
+    if (document.getElementById(this.splitterId) !== null && document.getElementById(this.leftSideId) != null) {
       this.splitter = <HTMLElement>document.getElementById(this.splitterId);
       this.leftSide = <HTMLElement>document.getElementById(this.leftSideId);
     }

src/Definitions/jquery-typescript.d.ts

@@ -1,34 +0,0 @@
-/* Type definitions for code-runner's jquery-typeahead v2.8.0
- * https://github.com/running-coder/jquery-typeahead
- *
- * There is no DefinitelyTyped support for this library, yet, so we only define here what we use.
- * https://github.com/running-coder/jquery-typeahead/issues/156
- * TODO: Replace this minimum definition by the official one when it comes out.
- */
-/// <reference path="jquery.d.ts" />
-
-interface JQueryTypeaheadParam {
-  input: string;
-  order?: string;
-  source: any;
-  callback?: any;
-  minLength?: number;
-  searchOnFocus?: boolean;
-  template?: string | { (query: string, item: any): string };
-  dynamic?: boolean;
-  mustSelectItem?: boolean;
-}
-
-/**
- * For use with: $.typeahead()
- */
-interface JQueryStatic {
-  typeahead(arg: JQueryTypeaheadParam): void;
-}
-
-/**
- * For use with $('').typehead()
- */
-// interface JQuery {
-//     typeahead(arg: JQueryTypeaheadParam): void;
-// }

src/Explorer/Controls/InputTypeahead/InputTypeaheadComponent.test.tsx

@@ -1,7 +1,6 @@
-import React from "react";
 import { shallow } from "enzyme";
+import React from "react";
 import { InputTypeaheadComponent, InputTypeaheadComponentProps } from "./InputTypeaheadComponent";
-import "../../../../externals/jquery.typeahead.min.js";
 
 describe("inputTypeahead", () => {
   it("renders <input />", () => {

src/Explorer/Graph/GraphExplorerComponent/GraphExplorer.test.tsx

@@ -4,7 +4,6 @@ import { mount, ReactWrapper } from "enzyme";
 import * as Q from "q";
 import React from "react";
 import * as sinon from "sinon";
-import "../../../../externals/jquery.typeahead.min";
 import { queryDocuments } from "../../../Common/dataAccess/queryDocuments";
 import { queryDocumentsPage } from "../../../Common/dataAccess/queryDocumentsPage";
 import * as DataModels from "../../../Contracts/DataModels";

src/Main.tsx

@@ -9,7 +9,6 @@ import "../externals/jquery-ui.structure.min.css";
 import "../externals/jquery-ui.theme.min.css";
 import "../externals/jquery.dataTables.min.css";
 import "../externals/jquery.typeahead.min.css";
-import "../externals/jquery.typeahead.min.js";
 // Image Dependencies
 import "../images/CosmosDB_rgb_ui_lighttheme.ico";
 import "../images/favicon.ico";

src/Platform/Hosted/extractFeatures.ts

@@ -75,6 +75,6 @@ export function extractFeatures(given = new URLSearchParams(window.location.sear
     autoscaleDefault: "true" === get("autoscaledefault"),
     partitionKeyDefault: "true" === get("partitionkeytest"),
     partitionKeyDefault2: "true" === get("pkpartitionkeytest"),
-    notebooksTemporarilyDown: "true" === get("notebookstemporarilydown", "true"),
+    notebooksTemporarilyDown: "true" === get("notebooksTemporarilyDown", "true"),
   };
 }