Compare commits

..

2 Commits

Author SHA1 Message Date
vaidankarswapnil
9eb5b0a1f6 Updated 1 test snapshot 2022-01-25 13:16:18 +05:30
vaidankarswapnil
2dd20e793f Fixed a11y issue for Settings pane spinbuttons 2022-01-25 09:14:39 +05:30
5 changed files with 44 additions and 29680 deletions

29666
package-lock.json generated

File diff suppressed because it is too large Load Diff

View File

@@ -231,6 +231,8 @@ export const SettingsPane: FunctionComponent = () => {
onDecrement={(newValue) => setMaxDegreeOfParallelism(parseInt(newValue) - 1 || maxDegreeOfParallelism)}
onValidate={(newValue) => setMaxDegreeOfParallelism(parseInt(newValue) || maxDegreeOfParallelism)}
ariaLabel="Max degree of parallelism"
incrementButtonAriaLabel="Increase value by 1"
decrementButtonAriaLabel="Decrease value by 1"
/>
</div>
</div>

View File

@@ -143,7 +143,9 @@ exports[`Settings Pane should render Default properly 1`] = `
<StyledSpinButton
ariaLabel="Max degree of parallelism"
className="textfontclr"
decrementButtonAriaLabel="Decrease value by 1"
id="max-degree"
incrementButtonAriaLabel="Increase value by 1"
min={-1}
onDecrement={[Function]}
onIncrement={[Function]}

View File

@@ -12,13 +12,13 @@
margin: auto;
padding-left: 21px;
padding-right: 16px;
max-width: 1168px;
max-width: 1168px;;
> * {
>* {
justify-content: space-between;
}
> .title {
>.title {
position: relative; // To attach FeaturePanelLauncher as absolute
color: @BaseHigh;
font-size: 48px;
@@ -27,7 +27,7 @@
text-align: center;
}
> .subtitle {
>.subtitle {
color: @BaseHigh;
font-size: 18px;
padding-left: 0px;
@@ -41,7 +41,7 @@
cursor: pointer;
margin: 40px auto;
> .mainButton {
>.mainButton {
min-width: 124px;
max-width: 296px;
padding: 32px 16px;
@@ -52,7 +52,7 @@
box-shadow: 0px 4px 4px rgba(0, 0, 0, 0.25);
border-radius: 4px;
> .legendContainer {
>.legendContainer {
margin-left: 16px;
text-align: left;
@@ -68,7 +68,7 @@
}
}
> :nth-child(n + 2) {
>:nth-child(n+2) {
margin-left: 32px;
}
}
@@ -83,7 +83,7 @@
min-width: 124px;
max-width: 296px;
> .title {
>.title {
font-size: 18px;
font-family: @SemiboldFont;
color: @BaseDark;
@@ -91,7 +91,7 @@
margin-bottom: 16px;
}
> ul {
>ul {
list-style: none;
padding-left: 0px;
margin-bottom: 0px;
@@ -101,7 +101,7 @@
.flex-display();
align-items: flex-start;
> img {
>img {
margin-right: @DefaultSpace;
width: 24px;
height: 24px;
@@ -133,12 +133,12 @@
.flex-display();
.flex-direction();
> .title {
>.title {
color: @BaseDark;
padding: 0px;
font-size: 12px;
}
> .description {
>.description {
color: @BaseDark;
}
@@ -150,14 +150,6 @@
&.commonTasks {
li {
cursor: pointer;
.commonTaskList {
width: 100%;
> img {
margin-right: @DefaultSpace;
width: 24px;
height: 24px;
}
}
}
}
@@ -175,12 +167,12 @@
}
&:focus {
.focus();
.focus();
}
&:active {
.active();
.active();
}
}
}
}
}

View File

@@ -57,13 +57,13 @@ export class SplashScreen extends React.Component<SplashScreenProps> {
this.subscriptions = [];
}
public componentWillUnmount(): void {
public componentWillUnmount() {
while (this.subscriptions.length) {
this.subscriptions.pop().dispose();
}
}
public componentDidMount(): void {
public componentDidMount() {
this.subscriptions.push(
{
dispose: useNotebook.subscribe(
@@ -131,13 +131,13 @@ export class SplashScreen extends React.Component<SplashScreenProps> {
key={`${item.title}${item.description}`}
onClick={item.onClick}
onKeyPress={(event: React.KeyboardEvent) => this.onSplashScreenItemKeyPress(event, item.onClick)}
tabIndex={0}
role="button"
>
<div className="commonTaskList" role="button" tabIndex={0}>
<img src={item.iconSrc} alt="" />
<span className="oneLineContent" title={item.info}>
{item.title}
</span>
</div>
<img src={item.iconSrc} alt="" />
<span className="oneLineContent" title={item.info}>
{item.title}
</span>
</li>
))}
</ul>