fixed eslint of TableDataClient file

.eslintignore

@@ -46,8 +46,8 @@ src/Explorer/DataSamples/DataSamplesUtil.test.ts
 src/Explorer/DataSamples/DataSamplesUtil.ts
 src/Explorer/Graph/GraphExplorerComponent/ArraysByKeyCache.test.ts
 src/Explorer/Graph/GraphExplorerComponent/ArraysByKeyCache.ts
-# src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.test.ts
-# src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.ts
+src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.test.ts
+src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.ts
 src/Explorer/Graph/GraphExplorerComponent/EdgeInfoCache.ts
 src/Explorer/Graph/GraphExplorerComponent/GraphData.test.ts
 src/Explorer/Graph/GraphExplorerComponent/GraphData.ts
@@ -84,7 +84,6 @@ src/Explorer/Tables/DataTable/DataTableOperationManager.ts
 src/Explorer/Tables/DataTable/DataTableViewModel.ts
 src/Explorer/Tables/DataTable/TableEntityListViewModel.ts
 src/Explorer/Tables/QueryBuilder/CustomTimestampHelper.ts
-src/Explorer/Tables/TableDataClient.ts
 src/Explorer/Tables/TableEntityProcessor.ts
 src/Explorer/Tables/Utilities.ts
 src/Explorer/Tabs/ConflictsTab.ts

src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.test.ts

@@ -1,5 +1,4 @@
-/*eslint-disable jest/no-test-callback */
-import * as sinon from "sinon";
+import * as sinon from "sinon";
 import GraphTab from "../../Tabs/GraphTab";
 import { D3Link, D3Node, GraphData } from "../GraphExplorerComponent/GraphData";
 import { D3ForceGraph, D3GraphNodeData, LoadMoreDataAction } from "./D3ForceGraph";
@@ -71,7 +70,6 @@ describe("D3ForceGraph", () => {
       forceGraph = new D3ForceGraph({
         igraphConfig: GraphTab.createIGraphConfig(),
         onHighlightedNode: sinon.spy(),
-        //eslint-disable-next-line
         onLoadMoreData: (action: LoadMoreDataAction): void => {},
 
         // parent to graph

src/Explorer/Graph/GraphExplorerComponent/D3ForceGraph.ts

@@ -1,6 +1,4 @@
-/*eslint-disable @typescript-eslint/no-explicit-any*/
-/*eslint-disable @typescript-eslint/no-this-alias*/
-import { BaseType } from "d3";
+import { BaseType } from "d3";
 import { map as d3Map } from "d3-collection";
 import { D3DragEvent, drag } from "d3-drag";
 import { forceCollide, forceLink, forceManyBody, forceSimulation } from "d3-force";
@@ -263,10 +261,10 @@ export class D3ForceGraph implements GraphRenderer {
         return;
       }
 
-      const self = this;
+      var self = this;
       // Select this node id
       selectAll(".node")
-        .filter((d: D3Node) => {
+        .filter(function (d: D3Node, i) {
           return d.id === newVal;
         })
         .each(function (d: D3Node) {
@@ -279,15 +277,15 @@ export class D3ForceGraph implements GraphRenderer {
   } // initialize
 
   private updateUniqueValues(key: string) {
-    for (let i = 0; i < this.graphDataWrapper.vertices.length; i++) {
-      const vertex = this.graphDataWrapper.vertices[i];
+    for (var i = 0; i < this.graphDataWrapper.vertices.length; i++) {
+      let vertex = this.graphDataWrapper.vertices[i];
 
-      const props = D3ForceGraph.getNodeProperties(vertex);
+      let props = D3ForceGraph.getNodeProperties(vertex);
       if (props.indexOf(key) === -1) {
         // Vertex doesn't have the property
         continue;
       }
-      const val = GraphData.getNodePropValue(vertex, key);
+      let val = GraphData.getNodePropValue(vertex, key);
       if (typeof val !== "string" && typeof val !== "number") {
         // Not a type we can map
         continue;
@@ -315,7 +313,7 @@ export class D3ForceGraph implements GraphRenderer {
    */
   private static getNodeProperties(node: D3Node): string[] {
     let props = ["id", "label"];
-    //eslint-disable-next-line
+
     if (node.hasOwnProperty("properties")) {
       props = props.concat(Object.keys(node.properties));
     }
@@ -407,7 +405,7 @@ export class D3ForceGraph implements GraphRenderer {
     // Remember nodes current position
     const posMap = new Map<string, Point2D>();
     this.simulation.nodes().forEach((d: D3Node) => {
-      if (d.x === undefined || d.y === undefined) {
+      if (d.x == undefined || d.y == undefined) {
         return;
       }
       posMap.set(d.id, { x: d.x, y: d.y });
@@ -551,7 +549,7 @@ export class D3ForceGraph implements GraphRenderer {
       .transition()
       .delay(D3ForceGraph.TRANSITION_STEP3_MS - 100)
       .duration(D3ForceGraph.TRANSITION_STEP3_MS)
-      .attrTween("fill", () => {
+      .attrTween("fill", (t: any) => {
         const ic = interpolate("#ffffff", "#000000");
         return (t: number) => {
           return ic(t);
@@ -569,7 +567,7 @@ export class D3ForceGraph implements GraphRenderer {
     // Distribute nodes initial position before simulation
     const nodes = graph.vertices;
     for (let i = 0; i < nodes.length; i++) {
-      const v = nodes[i];
+      let v = nodes[i];
 
       if (v._isRoot) {
         this.rootVertex = v;
@@ -613,20 +611,6 @@ export class D3ForceGraph implements GraphRenderer {
 
     const self = this;
 
-    const ticked = () => {
-      self.linkSelection.select(".link").attr("d", (l: D3Link) => {
-        return self.positionLink(l);
-      });
-      if (!D3ForceGraph.useSvgMarkerEnd()) {
-        self.linkSelection.select(".markerEnd").attr("transform", (l: D3Link) => {
-          return self.positionLinkEnd(l);
-        });
-      }
-      self.nodeSelection.attr("transform", (d: D3Node) => {
-        return self.positionNode(d);
-      });
-    };
-
     this.simulation.nodes(nodes).on("tick", ticked);
 
     this.simulation.force<d3.ForceLink<D3Node, D3Link>>("link").links(graph.edges);
@@ -650,6 +634,20 @@ export class D3ForceGraph implements GraphRenderer {
       this.simulation.alpha(1).restart();
       this.params.onGraphUpdated(new Date().getTime());
     });
+
+    function ticked() {
+      self.linkSelection.select(".link").attr("d", (l: D3Link) => {
+        return self.positionLink(l);
+      });
+      if (!D3ForceGraph.useSvgMarkerEnd()) {
+        self.linkSelection.select(".markerEnd").attr("transform", (l: D3Link) => {
+          return self.positionLinkEnd(l);
+        });
+      }
+      self.nodeSelection.attr("transform", (d: D3Node) => {
+        return self.positionNode(d);
+      });
+    }
   }
 
   private addNewLinks(): d3.Selection<Element, any, any, any> {
@@ -679,7 +677,7 @@ export class D3ForceGraph implements GraphRenderer {
   }
 
   private addNewNodes(): d3.Selection<Element, any, any, any> {
-    const self = this;
+    var self = this;
 
     const newNodes = this.nodeSelection
       .enter()
@@ -707,7 +705,7 @@ export class D3ForceGraph implements GraphRenderer {
         this.highlightNode(this, d);
         this.simulation.stop();
       })
-      .on("mouseout", () => {
+      .on("mouseout", (_: MouseEvent, d: D3Node) => {
         if (this.isHighlightDisabled || this.selectedNode || this.isDragging) {
           return;
         }
@@ -728,7 +726,7 @@ export class D3ForceGraph implements GraphRenderer {
       .attr("class", "main")
       .attr("r", this.igraphConfig.nodeSize);
 
-    const iconGroup = newNodes
+    var iconGroup = newNodes
       .append("g")
       .attr("class", "iconContainer")
       .attr("tabindex", 0)
@@ -751,8 +749,8 @@ export class D3ForceGraph implements GraphRenderer {
           self.onNodeClicked(this.parentNode, d);
         }
       });
-    const nodeSize = this.igraphConfig.nodeSize;
-    const bgsize = nodeSize + 1;
+    var nodeSize = this.igraphConfig.nodeSize;
+    var bgsize = nodeSize + 1;
 
     iconGroup
       .append("rect")
@@ -760,7 +758,7 @@ export class D3ForceGraph implements GraphRenderer {
       .attr("y", -bgsize)
       .attr("width", bgsize * 2)
       .attr("height", bgsize * 2)
-      .attr("fill-opacity", () => {
+      .attr("fill-opacity", (d: D3Node) => {
         return this.igraphConfig.nodeIconKey ? 1 : 0;
       })
       .attr("class", "icon-background");
@@ -832,10 +830,10 @@ export class D3ForceGraph implements GraphRenderer {
           self.loadNeighbors(d, PAGE_ACTION.NEXT_PAGE);
         }
       }) as any)
-      .on("mouseover", ((e: MouseEvent) => {
+      .on("mouseover", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", true);
       }) as any)
-      .on("mouseout", ((e: MouseEvent) => {
+      .on("mouseout", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", false);
       }) as any)
       .attr("visibility", (d: D3Node) => (!d._outEAllLoaded || !d._inEAllLoaded ? "visible" : "hidden"));
@@ -861,10 +859,10 @@ export class D3ForceGraph implements GraphRenderer {
           self.loadNeighbors(d, PAGE_ACTION.PREVIOUS_PAGE);
         }
       }) as any)
-      .on("mouseover", ((e: MouseEvent) => {
+      .on("mouseover", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", true);
       }) as any)
-      .on("mouseout", ((e: MouseEvent) => {
+      .on("mouseout", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", false);
       }) as any)
       .attr("visibility", (d: D3Node) =>
@@ -957,10 +955,10 @@ export class D3ForceGraph implements GraphRenderer {
           self.loadNeighbors(d, PAGE_ACTION.FIRST_PAGE);
         }
       }) as any)
-      .on("mouseover", ((e: MouseEvent) => {
+      .on("mouseover", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", true);
       }) as any)
-      .on("mouseout", ((e: MouseEvent) => {
+      .on("mouseout", ((e: MouseEvent, d: D3Node) => {
         select(e.target as any).classed("active", false);
       }) as any);
   }
@@ -969,9 +967,10 @@ export class D3ForceGraph implements GraphRenderer {
    * Remove LoadMore subassembly for existing nodes that show all their children in the graph
    */
   private updateLoadMore(nodeSelection: d3.Selection<Element, any, any, any>) {
+    const self = this;
     nodeSelection.selectAll(".loadmore").remove();
 
-    const nodeSize = this.igraphConfig.nodeSize;
+    var nodeSize = this.igraphConfig.nodeSize;
     const rootSelectionG = nodeSelection
       .filter((d: D3Node) => {
         return !!d._isRoot && !!d._pagination;
@@ -1091,7 +1090,7 @@ export class D3ForceGraph implements GraphRenderer {
 
   private fadeNonNeighbors(nodeId: string) {
     this.g.selectAll(".node").classed("inactive", (d: D3Node) => {
-      const neighbors = ((showNeighborType) => {
+      var neighbors = ((showNeighborType) => {
         switch (showNeighborType) {
           case NeighborType.SOURCES_ONLY:
             return this.graphDataWrapper.getSourcesForId(nodeId);
@@ -1152,7 +1151,7 @@ export class D3ForceGraph implements GraphRenderer {
   }
 
   private retrieveNodeCaption(d: D3Node) {
-    const key = this.igraphConfig.nodeCaption;
+    let key = this.igraphConfig.nodeCaption;
     let value: string = d.id || d.label;
     if (key) {
       value = <string>GraphData.getNodePropValue(d, key) || "";
@@ -1203,14 +1202,14 @@ export class D3ForceGraph implements GraphRenderer {
       y: (<D3Node>l.target).y,
     };
     const d1 = D3ForceGraph.calculateControlPoint(source, target);
-    const radius = this.igraphConfig.nodeSize + 3;
+    var radius = this.igraphConfig.nodeSize + 3;
 
     // End
     const dx = target.x - d1.x;
     const dy = target.y - d1.y;
     const angle = Math.atan2(dy, dx);
-    const ux = target.x - Math.cos(angle) * radius;
-    const uy = target.y - Math.sin(angle) * radius;
+    var ux = target.x - Math.cos(angle) * radius;
+    var uy = target.y - Math.sin(angle) * radius;
 
     return `translate(${ux},${uy}) rotate(${(angle * 180) / Math.PI})`;
   }
@@ -1225,21 +1224,21 @@ export class D3ForceGraph implements GraphRenderer {
       y: (<D3Node>l.target).y,
     };
     const d1 = D3ForceGraph.calculateControlPoint(source, target);
-    const radius = this.igraphConfig.nodeSize + 3;
+    var radius = this.igraphConfig.nodeSize + 3;
 
     // Start
-    let dx = d1.x - source.x;
-    let dy = d1.y - source.y;
-    let angle = Math.atan2(dy, dx);
-    const tx = source.x + Math.cos(angle) * radius;
-    const ty = source.y + Math.sin(angle) * radius;
+    var dx = d1.x - source.x;
+    var dy = d1.y - source.y;
+    var angle = Math.atan2(dy, dx);
+    var tx = source.x + Math.cos(angle) * radius;
+    var ty = source.y + Math.sin(angle) * radius;
 
     // End
     dx = target.x - d1.x;
     dy = target.y - d1.y;
     angle = Math.atan2(dy, dx);
-    const ux = target.x - Math.cos(angle) * radius;
-    const uy = target.y - Math.sin(angle) * radius;
+    var ux = target.x - Math.cos(angle) * radius;
+    var uy = target.y - Math.sin(angle) * radius;
 
     return "M" + tx + "," + ty + "S" + d1.x + "," + d1.y + " " + ux + "," + uy;
   }
@@ -1261,9 +1260,9 @@ export class D3ForceGraph implements GraphRenderer {
   }
 
   private static computeImageData(d: D3Node, config: IGraphConfig): string {
-    const propValue = <string>GraphData.getNodePropValue(d, config.nodeIconKey) || "";
+    let propValue = <string>GraphData.getNodePropValue(d, config.nodeIconKey) || "";
     // Trim leading and trailing spaces to make comparison more forgiving.
-    const value = config.iconsMap[propValue.trim()];
+    let value = config.iconsMap[propValue.trim()];
     if (!value) {
       return undefined;
     }
@@ -1289,7 +1288,7 @@ export class D3ForceGraph implements GraphRenderer {
       // clear icons
       this.g.selectAll(".node .icon").attr("xlink:href", undefined);
     }
-    this.g.selectAll(".node .icon-background").attr("fill-opacity", () => {
+    this.g.selectAll(".node .icon-background").attr("fill-opacity", (d: D3Node) => {
       return config.nodeIconKey ? 1 : 0;
     });
     this.g.selectAll(".node text.caption").text((d: D3Node) => {

src/Explorer/Tables/TableDataClient.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-explicit-any */
 import { FeedOptions } from "@azure/cosmos";
 import * as ko from "knockout";
 import Q from "q";
@@ -31,8 +32,6 @@ export interface CassandraTableKey {
 }
 
 export abstract class TableDataClient {
-  constructor() {}
-
   public abstract createDocument(
     collection: ViewModels.Collection,
     entity: Entities.ITableEntity
@@ -54,7 +53,7 @@ export abstract class TableDataClient {
   public abstract deleteDocuments(
     collection: ViewModels.Collection,
     entitiesToDelete: Entities.ITableEntity[]
-  ): Promise<any>;
+  ): Promise<unknown>;
 }
 
 export class TablesAPIDataClient extends TableDataClient {
@@ -67,7 +66,7 @@ export class TablesAPIDataClient extends TableDataClient {
       collection,
       TableEntityProcessor.convertEntityToNewDocument(<Entities.ITableEntityForTablesAPI>entity)
     ).then(
-      (newDocument: any) => {
+      (newDocument: unknown) => {
         const newEntity = TableEntityProcessor.convertDocumentsToEntities([newDocument])[0];
         deferred.resolve(newEntity);
       },
@@ -146,7 +145,7 @@ export class CassandraAPIDataClient extends TableDataClient {
     const clearInProgressMessage = logConsoleProgress(`Adding new row to table ${collection.id()}`);
     let properties = "(";
     let values = "(";
-    for (let property in entity) {
+    for (const property in entity) {
       if (entity[property]._ === null) {
         continue;
       }
@@ -164,7 +163,7 @@ export class CassandraAPIDataClient extends TableDataClient {
     const deferred = Q.defer<Entities.ITableEntity>();
     this.queryDocuments(collection, query)
       .then(
-        (data: any) => {
+        () => {
           entity[TableConstants.EntityKeyNames.RowKey] = entity[this.getCassandraPartitionKeyProperty(collection)];
           entity[TableConstants.EntityKeyNames.RowKey]._ = entity[TableConstants.EntityKeyNames.RowKey]._.toString();
           logConsoleInfo(`Successfully added new row to table ${collection.id()}`);
@@ -188,10 +187,10 @@ export class CassandraAPIDataClient extends TableDataClient {
 
     try {
       let whereSegment = " WHERE";
-      let keys: CassandraTableKey[] = collection.cassandraKeys.partitionKeys.concat(
+      const keys: CassandraTableKey[] = collection.cassandraKeys.partitionKeys.concat(
         collection.cassandraKeys.clusteringKeys
       );
-      for (let keyIndex in keys) {
+      for (const keyIndex in keys) {
         const key = keys[keyIndex].property;
         const keyType = keys[keyIndex].type;
         whereSegment += this.isStringType(keyType)
@@ -203,7 +202,7 @@ export class CassandraAPIDataClient extends TableDataClient {
       let updateQuery = `UPDATE ${collection.databaseId}.${collection.id()}`;
       let isPropertyUpdated = false;
       let isFirstPropertyToUpdate = true;
-      for (let property in newEntity) {
+      for (const property in newEntity) {
         if (
           !originalDocument[property] ||
           newEntity[property]._.toString() !== originalDocument[property]._.toString()
@@ -229,7 +228,7 @@ export class CassandraAPIDataClient extends TableDataClient {
 
       let deleteQuery = `DELETE `;
       let isPropertyDeleted = false;
-      for (let property in originalDocument) {
+      for (const property in originalDocument) {
         if (property !== TableConstants.EntityKeyNames.RowKey && !newEntity[property] && !!originalDocument[property]) {
           deleteQuery += ` ${property},`;
           isPropertyDeleted = true;
@@ -333,16 +332,16 @@ export class CassandraAPIDataClient extends TableDataClient {
     resourceId: string,
     explorer: Explorer,
     createKeyspaceQuery: string
-  ): Q.Promise<any> {
+  ): Q.Promise<unknown> {
     if (!createKeyspaceQuery) {
       return Q.reject("No query specified");
     }
 
-    const deferred: Q.Deferred<any> = Q.defer();
+    const deferred: Q.Deferred<unknown> = Q.defer();
     const clearInProgressMessage = logConsoleProgress(`Creating a new keyspace with query ${createKeyspaceQuery}`);
     this.createOrDeleteQuery(cassandraEndpoint, resourceId, createKeyspaceQuery)
       .then(
-        (data: any) => {
+        () => {
           logConsoleInfo(`Successfully created a keyspace with query ${createKeyspaceQuery}`);
           deferred.resolve();
         },
@@ -366,8 +365,8 @@ export class CassandraAPIDataClient extends TableDataClient {
     explorer: Explorer,
     createTableQuery: string,
     createKeyspaceQuery?: string
-  ): Q.Promise<any> {
-    let createKeyspacePromise: Q.Promise<any>;
+  ): Q.Promise<unknown> {
+    let createKeyspacePromise: Q.Promise<unknown>;
     if (createKeyspaceQuery) {
       createKeyspacePromise = this.createKeyspace(cassandraEndpoint, resourceId, explorer, createKeyspaceQuery);
     } else {
@@ -380,7 +379,7 @@ export class CassandraAPIDataClient extends TableDataClient {
         const clearInProgressMessage = logConsoleProgress(`Creating a new table with query ${createTableQuery}`);
         this.createOrDeleteQuery(cassandraEndpoint, resourceId, createTableQuery)
           .then(
-            (data: any) => {
+            () => {
               logConsoleInfo(`Successfully created a table with query ${createTableQuery}`);
               deferred.resolve();
             },
@@ -399,7 +398,7 @@ export class CassandraAPIDataClient extends TableDataClient {
   }
 
   public getTableKeys(collection: ViewModels.Collection): Q.Promise<CassandraTableKeys> {
-    if (!!collection.cassandraKeys) {
+    if (collection.cassandraKeys) {
       return Q.resolve(collection.cassandraKeys);
     }
     const clearInProgressMessage = logConsoleProgress(`Fetching keys for table ${collection.id()}`);
@@ -408,7 +407,7 @@ export class CassandraAPIDataClient extends TableDataClient {
       authType === AuthType.EncryptedToken
         ? Constants.CassandraBackend.guestKeysApi
         : Constants.CassandraBackend.keysApi;
-    let endpoint = `${configContext.BACKEND_ENDPOINT}/${apiEndpoint}`;
+    const endpoint = `${configContext.BACKEND_ENDPOINT}/${apiEndpoint}`;
     const deferred = Q.defer<CassandraTableKeys>();
 
     $.ajax(endpoint, {
@@ -429,7 +428,7 @@ export class CassandraAPIDataClient extends TableDataClient {
           logConsoleInfo(`Successfully fetched keys for table ${collection.id()}`);
           deferred.resolve(data);
         },
-        (error: any) => {
+        (error: Error) => {
           handleError(error, "FetchKeysCassandra", `Error fetching keys for table ${collection.id()}`);
           deferred.reject(error);
         }
@@ -439,7 +438,7 @@ export class CassandraAPIDataClient extends TableDataClient {
   }
 
   public getTableSchema(collection: ViewModels.Collection): Q.Promise<CassandraTableKey[]> {
-    if (!!collection.cassandraSchema) {
+    if (collection.cassandraSchema) {
       return Q.resolve(collection.cassandraSchema);
     }
     const clearInProgressMessage = logConsoleProgress(`Fetching schema for table ${collection.id()}`);
@@ -448,7 +447,7 @@ export class CassandraAPIDataClient extends TableDataClient {
       authType === AuthType.EncryptedToken
         ? Constants.CassandraBackend.guestSchemaApi
         : Constants.CassandraBackend.schemaApi;
-    let endpoint = `${configContext.BACKEND_ENDPOINT}/${apiEndpoint}`;
+    const endpoint = `${configContext.BACKEND_ENDPOINT}/${apiEndpoint}`;
     const deferred = Q.defer<CassandraTableKey[]>();
 
     $.ajax(endpoint, {
@@ -469,7 +468,7 @@ export class CassandraAPIDataClient extends TableDataClient {
           logConsoleInfo(`Successfully fetched schema for table ${collection.id()}`);
           deferred.resolve(data.columns);
         },
-        (error: any) => {
+        (error: Error) => {
           handleError(error, "FetchSchemaCassandra", `Error fetching schema for table ${collection.id()}`);
           deferred.reject(error);
         }
@@ -496,7 +495,7 @@ export class CassandraAPIDataClient extends TableDataClient {
       beforeSend: this.setAuthorizationHeader,
       cache: false,
     }).then(
-      (data: any) => {
+      () => {
         deferred.resolve();
       },
       (reason) => {