Updated favourited_by_accounts_controller to return empty object

Removed ability to view accounts that favorited a status
This commit is contained in:
mgabdev 2019-07-04 00:10:24 -04:00
parent e210c70e21
commit f849321b07

View File

@ -4,74 +4,52 @@ class Api::V1::Statuses::FavouritedByAccountsController < Api::BaseController
include Authorization include Authorization
before_action -> { authorize_if_got_token! :read, :'read:accounts' } before_action -> { authorize_if_got_token! :read, :'read:accounts' }
before_action :set_status
after_action :insert_pagination_headers
respond_to :json respond_to :json
def index def index
@accounts = load_accounts render json: {}, status: :ok
render json: @accounts, each_serializer: REST::AccountSerializer
end end
private private
def load_accounts def load_accounts
default_accounts.merge(paginated_favourites).to_a #
end end
def default_accounts def default_accounts
Account #
.includes(:favourites, :account_stat)
.references(:favourites)
.where(favourites: { status_id: @status.id })
end end
def paginated_favourites def paginated_favourites
Favourite.paginate_by_max_id( #
limit_param(DEFAULT_ACCOUNTS_LIMIT),
params[:max_id],
params[:since_id]
)
end
def insert_pagination_headers
set_pagination_headers(next_path, prev_path)
end end
def next_path def next_path
if records_continue? #
api_v1_status_favourited_by_index_url pagination_params(max_id: pagination_max_id)
end
end end
def prev_path def prev_path
unless @accounts.empty? #
api_v1_status_favourited_by_index_url pagination_params(since_id: pagination_since_id)
end
end end
def pagination_max_id def pagination_max_id
@accounts.last.favourites.last.id #
end end
def pagination_since_id def pagination_since_id
@accounts.first.favourites.first.id #
end end
def records_continue? def records_continue?
@accounts.size == limit_param(DEFAULT_ACCOUNTS_LIMIT) #
end end
def set_status def set_status
@status = Status.find(params[:status_id]) #
authorize @status, :show?
rescue GabSocial::NotPermittedError
# Reraise in order to get a 404 instead of a 403 error code
raise ActiveRecord::RecordNotFound
end end
def pagination_params(core_params) def pagination_params(core_params)
params.slice(:limit).permit(:limit).merge(core_params) #
end end
end end