random-mirrors/pokerogue
1
0
Fork 0
mirror of https://github.com/pagefaultgames/pokerogue.git synced 2025-01-18 15:00:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

[BUG] Fix Move Info Overlay Scroll Bug (#1856)

Browse Source 
* Added "Skip Dialogues" option (if at least 1 classic win)

* Removed error sound and hide option instead when classic wins = 0

* Add skip dialogues option to Unlockables and show unlocked message on first classic win

* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage

* oops

* dont show charSprite when skipping a dialogue, small fixes

* correctly reset move description scrolling when changing move

* override fix

---------

Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
This commit is contained in:
Frede 2024-06-06 15:22:37 +02:00 committed by GitHub
parent 0e9bcfb4fd
commit 40328d5712
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/ui/move-info-overlay.ts
View File

@ -142,10 +142,11 @@ export default class MoveInfoOverlay extends Phaser.GameObjects.Container implem
this.desc.setText(move?.effect || ""); this.desc.setText(move?.effect || "");
// stop previous scrolling effects // stop previous scrolling effects and reset y position
if (this.descScroll) { if (this.descScroll) {
this.descScroll.remove(); this.descScroll.remove();
this.descScroll = null; this.descScroll = null;
this.desc.y = (this.options?.top ? EFF_HEIGHT : 0) + BORDER - 2;
} }
// determine if we need to add new scrolling effects // determine if we need to add new scrolling effects