innerthunder
03025b2674
[P2] Fix various charge move bugs ( #4595 )
...
* Add charge move classes and phase
* Integrate `MoveChargePhase` in battle phase sequence
* Fix Protean + charge move interaction
* Fix effect chance applying to semi-invulnerability
* Remove `ChargeAttr` and fix ChargeAnim loading
* Restore move history entry for charge phases
* Gravity now cancels Fly, etc. after charge turn
* Dig integration tests
* Fly integration tests
* Dive integration test + fix Dive in Harsh Sun bug
* Solar Beam integration tests + `CHARGING` tag fixes
* Fix dive test
* Electro Shot integration tests
* fix import in MoveChargePhase
* Electro Shot Multi Lens test
* Geomancy integration tests
* Fix duplicate move queue
* Update import
* Docs + Fix Meteor Beam being boosted by Sheer Force
* Fix volt absorb test
* Apply PigeonBar's suggested move-phase changes
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
* Make Electro Shot Sheer Force boosted again
* Apply PigeonBar's feedback pt. 2
* Apply suggestions from code review
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* Fix mistimed/dupe showMoveText and leftover TODO
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: PigeonBar <56974298+PigeonBar@users.noreply.github.com>
2024-10-23 11:08:40 -04:00
NightKev
22442d3aa0
[Refactor] Refactor move phase and add documentation ( #3974 )
...
* Refactor `MovePhase` to improve readability/maintainability
Add tsdocs/comments all over
Mark all functions/fields with public/etc
Fix multi-hit moves called from Metronome/etc, fixes #3914
Remove unused function `BattleScene.pushMovePhase`
Don't use failure text as a condition for move success
A move defining potential failure text doesn't mean it failed
Replace relative imports with absolute imports in `battle-scene.ts`
Change some fields from optional to default `false`
* Fix Whirlwind test
* Fix linting
2024-10-04 10:50:03 -04:00
torranx
644c078a6c
add new lint rules....again
2024-10-04 13:08:31 +08:00
flx-sta
6030b780f2
[Move][Mirror] Update HitTagAttr attributes v2 ( #4297 )
...
* [Move] Updated HitAttr tags
Affects Whirlwind/Fly, Steamroller/Minimize, and Malicious Moonsault/Minimize
* [Move] Update for MinimizeAccuracyAttr
Affects Steamroller and Malicious Moonsault
* add: whirlwind test
* add: steamroller test
* rename: `AlwaysHitMinimizeAttr` (from `MinimizeAccuracyAttr`)
* rename: `DealsDoubleDamageToTagAttr` (from `HitsTagAttr`)
---------
Co-authored-by: chaosgrimmon <31082757+chaosgrimmon@users.noreply.github.com>
2024-09-17 22:41:46 -04:00
