20 Commits

Author SHA1 Message Date
flx-sta
a07d2c57a4
[Refactor] use typescript strict-null (#3259)
* TS: enable strict-null

* fix battle-scene.ts

* fix voucher.ts

* adapt more files to strict-null

* adapt more files to strict-null ( 2)

* adapt ability.ts to strict-null

* adapt `arena.ts` to strict-null

* adapt TagAddedEvent constructor to strict-null

* adapt phases.ts.to strict-null

* adapt status-effect.ts to strict-null

* adapt `account.ts` to strict-null

* adapt `configHandler.ts` to strict-null

* adapt `ability.ts` to strict-null

* adapt `biomes.ts` to strict-null

* adapt `challenge.ts` to strict-null

* adapt `daily-run.ts` to strict-null

* adapt `nature.ts` to strict-null

* adapt `pokemon-forms.ts` to strict-null

* adapt `tainer-names.ts` to strict-null

* adapt `types.ts` to strict-null

* adapt `weather.ts` to strict-null

* adapt `egg-hatch-phase.ts` to strict-null

* adapt `evolution-phase.ts` to strict-null

* adapt `pokemon-sprite-sparkle-handler.ts` to strict-null

* adapt `evolution-phase.ts` to strict-null

* adapt `game-mode.ts` to strict-null

* adapt `utils.ts` to strict-null

* adapt `voucher-ui-handler.ts` to strict-null

* adapt `src/ui/unavailable-modal-ui-handler.ts` to strict-null

* adapt `src/ui/ui.ts` to strict-null

* adapt `src/ui/ui-theme.ts` to strict-null

* adapt `src/ui/title-ui-handler.ts` to strict-null

* adapt `src/ui/time-of-day-widget.ts` to strict-null

* adapt `src/ui/text.ts` to strict-null

* adapt `src/ui/target-select-ui-handler.ts` to strict-null

* adapt `src/ui/settings/settings-keyboard-ui-handler.ts` to strict-null

* adapt more files to strict-null (3)

* adapt more files to strict-null (4)

* adapt more files (mostly tests) to strict-null (5)

* adapt more files to strict-null (6)

* adapt more files to strict-null (7)

* Update `src/data/pokemon-evolutions.ts` for strict-null

Partial update `src/data/pokemon-species.ts` for strict-null

* adapt more files to strict-null (8)

* adapt more files to strict-null (9)

* Strict some more nulls (still a few errors remaining)

* adapt rest of the files to strict-null (9)

* fix tests (check for null instead of undefined)

* repalce a lot of `??` with bangs

And added TODO notice as usual

* fix more tests

* all tests pass now

* fix broken game-loop after trainer battle

add some console.warn for missing cases and falling back to default

* remove guessed fallback from utils.rgbHexToRgba

* add TODO for this.currentBattle = null

* adjust   getPokemonById() return to include `null`

* fix compilation errors

* add test for pokemon.trySetStatus

* `chanceMultiplier` shouldn't be optional

* allow `null` for currentPhase

* adjust hasExpSprite logic for no keymatch found

* reduce bang usage in account.updateUserInfo()

* fix new strict-null issues after merge

* fix `strict-null` issues in dropdown.ts

and sand_spit.test.ts

* fix egg-gacha

* adapt gul_missile.test.ts to strict-null

* fix move.ts strict-null

* fix i18n.ts strict-null

* fix strict-null issues

* fix baton_pass test

after accidentially breaking it

* chore: fix compiler errors

* revert accidential changes in baton_pass.test.ts

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-08-07 17:23:12 +01:00
NightKev
877d0c6db8
[Test] Stylistic consistency pass on tests (#3378)
* Modify tests to use overrides helper functions

* Apply stylistic consistency to overrides in tests

Also remove some non-test-related expects()
2024-08-06 10:06:25 -04:00
Felix Staud
8e09714904 add OverridesHelper.enemyHeldItems 2024-07-29 07:45:09 -07:00
Felix Staud
fa8e9c38bc add OverridesHelper.enemyStatusEffect() 2024-07-29 07:45:00 -07:00
Felix Staud
05a3142c13 add OverridesHelper.startingHeldItems 2024-07-29 07:44:41 -07:00
Felix Staud
b72a1347b2 add OverridesHelper.passiveAbility 2024-07-29 07:44:29 -07:00
Felix Staud
e0e37314ce add OverridesHelper.enemyPassiveAbility 2024-07-29 07:42:09 -07:00
Felix Staud
a87aec4f27 add OverridesHelper.disableCrits() 2024-07-29 07:41:59 -07:00
Felix Staud
a9031a3215 add OverridesHelper.enemyLevel 2024-07-29 07:41:35 -07:00
Felix Staud
97376d5c70 add OverridesHelper.starterForms 2024-07-29 07:41:24 -07:00
Felix Staud
bb1e3f7d20 add OverridesHelper.moveset() 2024-07-29 07:40:28 -07:00
Felix Staud
7732411c92 add OverridesHelper.ability() 2024-07-29 07:40:13 -07:00
Felix Staud
b16a28d5b8 add OverridesHelper.startingLevel() 2024-07-29 07:40:05 -07:00
Felix Staud
f8e6230a14 add OverridesHelper.starterSpecies() 2024-07-29 07:39:56 -07:00
Felix Staud
f55bfc3681 add OverridesHelper.enemyMoveset() 2024-07-29 07:39:15 -07:00
Felix Staud
7cd75b13b9 add OverridesHelper.enemyAbility 2024-07-29 07:39:05 -07:00
Felix Staud
6674fe4984 allow number for OverridesHelper.enemySpecies() 2024-07-29 07:38:53 -07:00
Felix Staud
08e0531eae add OverridesHelper.enemySpecies() 2024-07-29 07:38:47 -07:00
Felix Staud
3788631846 add game.override.battleType 2024-07-29 07:37:56 -07:00
Felix Staud
6fb50593dc add overridesHelper.ts 2024-07-29 07:35:15 -07:00