Commit Graph

4058 Commits

Author SHA1 Message Date
Leo Kim
5020d742f7
[Bug] Fixed bug where container for unfiltered Pokémon does not try to setVisible (#3509) 2024-08-12 09:25:24 -04:00
Amani H.
a35aff7b25
[Refactor/Bug] Overhaul & Document Item/Modifier Overrides (#2320)
* Overhaul & Document Item/Modifier Overrides

* add reverse lookup for modifier tier in modifier overrides

* Refactor `withTierFromPool`

* Minor NIT

* Another NIT

* Fix `strict null` issue

---------

Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-08-12 11:54:52 +01:00
NightKev
223295e827
[Fix] Refactor Disguise to work like Ice Face (#2684)
* Fix typos in `src/data/egg.ts` comments

* Refactor Disguise using Ice Face as a base

i18n {
  Co-authored-by: Arxxer <javiptn7@gmail.com>
  Co-authored-by: GoldTra <162721984+GoldTra@users.noreply.github.com>
  Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
  Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
  Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
}

Update tests

* Update jsdoc

* Make recoil damage a parameter

* Fix Ice Face i18n parameter name

* Add i18n placeholder strings for translation

* Update disguise test with override helper functions

* Move a form change from `battle-scene.ts` to `ability.ts`

* Remove a bit of obsolete code from the Disguise test

* Add some translations

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>

* Add translation placeholder strings for Japanese and Catalan

* Update for strict-null

* Remove unused parameter from the `BattlerTag` class

* Remove species checks, fusion doesn't seem to be an issue (any more?)

* Move Ice Face weather-based code to a subclass

* Condense conditionals

Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Sonny Ding <93831983+sonnyding1@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-08-12 11:52:39 +01:00
Leo Kim
d3d376dca3
[Enhancement] update initial filter setting when not in challenge mode (#3506)
* update initial filter setting when not in challenge mode

* Modify the code with more consideration for future scalability.

* update initial setting in challenge mode also. no conditional setting!
2024-08-12 02:19:20 -04:00
Amani H.
d2c6aa5df8
[Bug] Prevent Relearnable Egg Moves in Fresh Start (#3466)
* [Bug] Prevent Relearnable Egg Moves in Fresh Start

* Mention Condition in Docs

* Use `isFreshStartChallenge()`
2024-08-12 01:49:32 -04:00
Tempoanon
63b5195b14
[Bug] Some fresh start fixes (#3420)
* Fix some fresh start bugs

* Forgot a !

* Add fresh start check on eviolite too

* Remove part about cost being 3

* Update src/game-mode.ts

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* Rename isFreshStart helper function

---------

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-08-12 01:34:53 -04:00
allen925
c078e5d612
[Bug][Test] Fix minor bug of ability Flash Fire, added test file (#3458)
* fix: let flash fire hit after frozen, and baton pass not passing it. added: flash fire test file

* added more tests and made small adjustments

* Update src/test/abilities/flash_fire.test.ts

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
2024-08-12 01:26:37 -04:00
DustinLin
ec26e751f8
[TEST] - adding parting shot move test (#3412)
* adding parting shot test

* improve tests

* updating test

* fixing existing tests

* more tests

* adding more tests
2024-08-12 01:13:56 -04:00
Enoch
0c64b01f3f
[Refactor] move and change localization key of battler-tags (#3498)
* move locale messages of battler tags : battle.ts -> battler-tags.ts

* Change message key name to simple

* Apply suggestions from code review

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-08-12 01:02:44 -04:00
Chapybara-jp
0028ae8a6d
[Localization(ja)] Translate starter-select-ui-handler.ts (#3481)
* [JA] [Localization] Translate starter-select-ui-handler.ts

Unsure about "Enable/Disbale Passive", need some advice.

* Update starter-select-ui-handler.ts
2024-08-12 01:02:06 -04:00
protimita
097d43feaf
[Localization(ja)] Translated modifier.ts, arena-tag.ts (#3487)
* [Localization][JA] translated modifier.ts

translation for modifier.ts

* Update src/locales/ja/modifier.ts

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/modifier.ts

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* [Localization][JA] Translated arena-tag.ts

Translation for arena-tag.ts

---------

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
2024-08-12 01:00:54 -04:00
Chapybara-jp
d19caf6650
[Localisation(ja)] Translated save-slot-select-ui-handler.ts (#3475)
* Translated save-slot-select-ui-handler.ts

"Wave" needs special coding to look correct.

* Update save-slot-select-ui-handler.ts

missed a space, punctuation

* Update save-slot-select-ui-handler.ts

* Update save-slot-select-ui-handler.ts
2024-08-12 00:57:47 -04:00
AJ Fontaine
77a9a2306b
[Item] Skip Ability Charm reward after wave 189 in classic (#3477) 2024-08-12 00:57:19 -04:00
Adrian T.
4b16b64eed
[Test] move util func to gameManager.ts (#3494) 2024-08-12 00:56:31 -04:00
NightKev
0e0ed10ce0
[Test] Fix test names that weren't changed from copy/pasting (#3502) 2024-08-12 00:54:42 -04:00
Leo Kim
53e54df9ee
[Enhancement] Add Passive / Cost Reduction - Can Unlock option and Egg purchasable filter (#3478)
* add unlockable state in passive/cost reduction filter. add egg purchasable filter

* update placeholders

* update option order of UNLOCKABLE between ON and EXCLUDE

* remove egg restriction when buying eggs
2024-08-12 00:44:15 -04:00
MokaStitcher
f8b9397d06
[UI] add open filter button for mobile touch pad (#3480) 2024-08-12 00:44:00 -04:00
Leo Kim
0f09893091
Immediately update the passive background upon unlocking (#3479) 2024-08-12 03:03:20 +01:00
ImperialSympathizer
988ec664e9
Disable endless boss passives (#3451)
* fix strict null broken

* disable endless boss passives

* jsdocs on mock objects and move helper function to gameManager.ts

* Apply suggestions from flx's review

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* fix broken test

* fix lint

---------

Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-08-11 19:40:47 +01:00
Chapybara-jp
b20314b45f
[Localization(jp)] Translate voucher.ts (#3476)
Need to be consistent with names of vouchers in modifiers.ts.
2024-08-10 12:25:25 -04:00
Tim Perdok
566cd80522
[Feature] Move touch controls configuration (Reopened) (#3256)
* [Hotfix] Fix interactions of some moves not changing types (#3183)

* [Hotfix] Fix wild spawns not having their HA (#3190)

* [Hotfix] Allow to hatch pokemon with Hidden Ability again (#3222)

* chore: Update TNC links layout and position in index.html

* chore: Update TNC links font size in index.css (#3230)

* Move Touch Controls

* ConfigToolbar alignment

* Insert config toolbar on open, camel-case classes, hidden setting

* Better toolbar styling, fixed double configToolbar bug

* Fixed typedocs

---------

Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Frederico Santos <frederico.f.santos@tecnico.ulisboa.pt>
2024-08-10 14:17:04 +01:00
DustinLin
638a0a66b5
[Bug] removing destroy() calls on enemy pokemon after BattleEndPhase and breaks endless %50 waves (#3461) 2024-08-10 01:27:22 -04:00
NightKev
e820163505
[Misc] Update Pull Request template (#3467) 2024-08-09 16:58:15 -04:00
Blitzy
d127773a89
[Balance] Change Some Mainline Starter's Early Learnset (#3445)
* Update pokemon-level-moves.ts

* Change Poipole's Early Move

* Add notes
2024-08-09 18:48:10 +01:00
flx-sta
762feea332
[Bug][Localhost] fix Json parse issue when trying to load battle-anim (#3455)
* add content-type check for loading battle-anims

* add missing `headers` to response mocks
2024-08-09 11:17:34 -04:00
Adrian T.
bfdcd4fc1e
[Dev] Move function from testUtils.ts to gameManager.ts (2/3) (#3432)
* move mockTurnOrder to gameManager

* change name

* fix test failing

* fix purify test

* fix typo
2024-08-09 11:07:55 -04:00
Leo Kim
dcbdc511cf
[Localization] update korean translation of filter for costReduction (#3464) 2024-08-09 11:06:57 -04:00
Adrian T.
2b12326280
[Dev] Move function from testUtils.ts to gameManager.ts (1/3) (#3430)
* move mockHitCheck to gameManager

* add abstract base class and move helper class

* add param for single target miss
2024-08-09 10:37:10 -04:00
Leo Kim
14b3907b11
[Enhancement] Add favorite filter in Starter UI (#3431)
* add favorite filter. add favorite starter attribute

* add error handling for undefined favorite attribute

* add placeholders in each locales

* add favorite icon from great art team

* update favorite icon to code

* update korean translation

* align icons

* initialize the starter preferences if they don't exist

* update requested changes
2024-08-09 10:32:30 -04:00
Leo Kim
d2eea96777
[Enhancement] Allow nickname assignment in the starter select UI. (#3456)
* add rename nickname in starter UI

* update requested changes
2024-08-09 10:17:18 -04:00
schmidtc1
57a4e1cc47
[Bug] Fixes bug with freezy frost not eliminating all Pokemon's stat changes (#3362)
* Cherrypick due to beta roll back

* Adds corrected stat eliminated message to move trigger, removes from battle.ts

* Adds check for Clear Smog vs Haze/Freezy Frost for targetting purposes

* Adds translations for fr, de, and pt_br

* Update src/locales/ko/move-trigger.ts with translation

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* Update korean move-trigger.ts with proper translation

* Update src/locales/zh_CN/move-trigger.ts with translation

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_TW/move-trigger.ts with translation

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Adds locales to ja and ca-ES

* Creates unit test for Haze

* Removes repeats option on Haze test left from testing

* Updates title of haze tests, creates freezy frost tests

* Update src/locales/es/move-trigger.ts with translation

Co-authored-by: Asdar <asdargmng@gmail.com>

* Fixes freezy_frost.test.ts copy errors from Haze test

---------

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: Asdar <asdargmng@gmail.com>
2024-08-09 10:16:38 -04:00
NightKev
fe429d0c8c
[Test] Fix hyper beam and purify test rng (#3449) 2024-08-09 09:40:00 -04:00
Chapybara-jp
750d9051c4
[Localization(ja)] Added kanji to battle.ts (#3446)
Added kanji
漢字に変更しました
Changed spacing to full width
スペースを全角スペースに変更しました
2024-08-09 09:38:51 -04:00
José Ricardo Fleury Oliveira
3dfe4570de
[Localization] Update Portuguese translations for achievements, trainers and dialogues (#3452) 2024-08-09 09:33:46 -04:00
flx-sta
30cc6aba89
[Bug] Fix DNA splicers broken from the strictnull check (#3454)
This makes DNA-splicer work again
2024-08-09 09:33:31 -04:00
ImperialSympathizer
b794662776
[Test] Fix final boss test (#3444)
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-08-08 17:06:57 -04:00
ImperialSympathizer
ba9378d1d8
disables final boss passive (#3393)
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-08-08 20:59:23 +01:00
Leo Kim
b54a255c15
[Enhancement] Add go filter shortcut (#3345)
* update goFilter shortcut

* fix filter instruction position

* remove unnecessary new lines

* update requested changes. add other language entries too

* remove unnecessary case code

* open dropdown when pressing goFilter shortcut

* add missing entry for `fr`

* Update src/locales/fr/starter-select-ui-handler.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/de/starter-select-ui-handler.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* update instruction container position and text offset for more longer instruction label. decrease size of fr instruction font

* fixed de info font size

* Update src/locales/pt_BR/starter-select-ui-handler.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update src/locales/ko/starter-select-ui-handler.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/zh_TW/starter-select-ui-handler.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_CN/starter-select-ui-handler.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* update font size, starterInfoXPos and starterInfoYOffset in zh. update starterInfoXPos in de

* Update src/locales/es/starter-select-ui-handler.ts

Co-authored-by: Asdar <asdargmng@gmail.com>

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: Asdar <asdargmng@gmail.com>
2024-08-08 20:34:20 +01:00
Chapybara-jp
cff5a670b1
[Localization(ja)] First draft translated achv.ts (#3408)
* First draft translated achv.ts

* Update achv.ts

Added Earth Monotype challenge translation 
じめんタイプチャレンジのギャグを加えました
Changed spacing size
空白を全角スペースに変えた

* Update src/locales/ja/achv.ts

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update achv.ts

* Update achv.ts

---------

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
2024-08-08 15:30:42 -04:00
Chapybara-jp
6ad32f3c40
[Localisation(ja)] Translate challenges.ts (#3439)
Discordでこの質問を聞きましたが、ここでも聞いて置きます:
"Starters" をどう翻訳しましょうか?一番合ってる公式の用語は「最初のパートナー」だと思いますが、ちょっと長いです。
2024-08-08 15:28:26 -04:00
innerthunder
2e823b1914
[Documentation] Add comments to MoveEffectPhase (+ some style changes) (#3392)
* Document MoveEffectPhase

* Edits based on Temp's suggestions
2024-08-08 15:27:26 -04:00
innerthunder
7f5e873457
[Move] Fully Implement Gulp Missile (#3438)
* Fix Dive + Gulp Missile interaction

* Fix animation + remove tests for inaccurate behavior

* Fix strict-null issue in new test
2024-08-08 14:23:11 -04:00
Enoch
15106b83fb
[Localization(ja)] Translated ability-trigger.ts, status-effect.ts (#3428)
* Translated ability-trigger.ts, status-effect.ts

* Apply suggestions from code review

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Apply suggestions from code review

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

---------

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
2024-08-08 14:04:04 -04:00
innerthunder
b4a891cc71
[Move] Reimplement Beak Blast (#3427)
* Re-Implement Beak Blast

* Fix charge animation loading issues
2024-08-08 14:03:28 -04:00
Jannik Tappert
b5a40bfdfc
[Localization] German missing keys (#3436)
* Add all keys that are in english but missing in german

* useless change

* Revert "useless change"

This reverts commit 15cff42d8d.
2024-08-08 14:02:26 -04:00
NightKev
f0d4dfa09e
[Test] Mock turn order in Miracle Eye test (#3437) 2024-08-08 14:02:02 -04:00
Opaque02
49bb681554
[Bug] Starter UI challenge form fix (#3373)
* First issue with soft attribute on challenges as well as incorrect sprites appearing on the starter select ui

* Updated logic to fix starter party icons, forms and shinies in starter selection area

* Fixed issue where some pokemon were being shown in challenges originally if the default form didn't meet the criteria

* Updated docs and tests to account for new behaviour

* Removed some debugging comments

* Fixed rotom form not counting as valid party

* Fixed a bug where the cursor's last known position would be used when pokemon forms were being changed when other forms were available when updated from your party directly

* Fixed issue with starter party icons' forms updating incorrectly when removing pokemon from party

* Fixed docs

* Updated code to allow for starter icons to remember their previous state after a reload
2024-08-08 09:16:27 -04:00
Alex Van Liew
aaad2241ae
[Dev] Add typecheck command (#3409)
* add test command for typechecking

* change command name
2024-08-08 13:58:07 +01:00
Opaque02
cff3adf2e6
Updating locale folder from ca-ES to ca_ES (#3429)
* Updating locale folder from ca-ES to ca_ES

* Updated the i18n config file to include ca_ES instead of ca-ES
2024-08-08 13:55:56 +01:00
Opaque02
9eb57c0c66
[QoL] IV scanner update to hide the prompt and let you see the stats mid battle on the stats screen (#3285)
* IV scanner PR fix

Updated locales to have updated keys for IV scanner in menu

Updated legacy UI to work with IV scanner changes

Updated code to have player and enemy battle stats for ease of use

Updated logic to make the player side work exactly the same as previously since there should be no HP stat shown for players. Also updated the colours so there's no more grey option for unknown stats

Added HP, updated logic and colours. Need to undo changes to player pokemon to not be as squished because of no HP, and need to see what happens for trainers

Fixing up some git errors

Fixed a bug with double battles not updating the pokemon properly

Updated settings to allow for the ability to skip the IV scanning prompts

Adding functionality to IV scanner to skip prompt and see IVs mid battle

* Merged with latest + fixed bug with IV scanner vs pokemon info container getRootSpeciesId being different

* Updated as per merge comment

* Updating to fix comments

* Updated comments

* Update src/locales/fr/settings.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/de/settings.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update src/locales/pt_BR/settings.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update src/locales/ko/settings.ts

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/zh_CN/settings.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Update src/locales/zh_TW/settings.ts

Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>

* Updating text of IV scanner to be gold

* Updated text colour to use one of the existing golds instead of a custom gold

* Japanese locale

* Updating docs

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
2024-08-08 01:04:12 -04:00