Commit Graph

3341 Commits

Author SHA1 Message Date
DustinLin
ccb38ca12b
[BUG] fixing multi-hit and move messages on faint (#2981)
* fixing order of messages, scences, to render messages before fainting

* updated fix for effectiveness text rendering order for multi hit moves

* fixing messages not appearing for multi-hit moves on faint

* updated multi-hit condition)

* fixing PR conflicts

* adding comments and FaintPhase setPhaseQueueSplice bug, fixing overrides merge conflict

* writing better comments

* removing space diff in overrides

* adding fainting check for self damage moves

* emergency fixing broken last commit

* additional comments for multi-hit problem

* updating comments, jsdoc style

* fixing linter, destiny bond errors

* splitting up varaible comments to be in JSDoc format

* fixing tests and merge mistakes

* adding rendering of multihit moves that only hit once

* fixing comment formatting_tabs and spaces

---------

Co-authored-by: Benjamin Odom <bennybroseph@gmail.com>
2024-07-22 13:44:29 -04:00
Madmadness65
d0cbe19bd8
Allow Necrozma forms to play their special music (#3054) 2024-07-22 12:35:11 -05:00
chaosgrimmon
de0aacfcc7
[Sprite] Show Partner Eevee variants (#3097)
* [Sprite] Show Partner Eevee variants

Taken from non-partner Eevee

* [Sprite] Show Partner Eevee variants

Taken from non-partner Eevee

* [Sprite] Show Partner Eevee variants
2024-07-22 13:12:15 -04:00
sirzento
01de9b9b58
[Feature] Added pokemon nicknames/renaming (#2570)
* Added basic temp renaming

* Made nickname persistant after reloading

* Localization and cancel button

* Fixed instant rename on active pokemon

* Small bugfix to prevent console errors

* Changed logic to use the new nickname field. Replaced most .name with getNameToRender() for display.

* Changed evolution message. Removed log messagesc

* Added localization keys for other languages

* Removed empty lines

* French translation

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Chinese translation

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Portuguese (Brazil) translation

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Korean translation

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update menu.ts

* Update menu.ts [Localization(it)]

* Changed most .getNameToRender() instance to getPokemonNameWithAffix()

* Changed wild encounter messages back to just use the name without affix.

* Added localization for the party ui rename selection

* Escaping nickname characters to support all characters

* Better Error handling

* Update src/field/pokemon.ts

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

---------

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-07-22 12:46:52 -04:00
schmidtc1
fc722bea7f
[Bug] Enemies can properly use stuff cheeks (#3090) 2024-07-22 12:01:59 -04:00
gjeodnd12165
21940e6426
[Bug] fix not changing moveset after add to starter #1932 (#2396) 2024-07-22 11:25:55 -04:00
NightKev
b6266c6da1
[Move] Finish implementation of Glaive Rush (#2720)
* Finish implementation of Glaive Rush

* Fix test RNG

* Add code/test for Multi-Lens interaction

* Fix off-by-one error in test caused by rounding issues

* Update for code changes

* Fix BattlerTag name
2024-07-22 11:16:59 -04:00
AJ Fontaine
10413722c6
[Sprite] Fix a number of sprite issues including the Zubat line, Goldeen, Golett, Dudunsparce, H-Sneasel, Garchomp, Sylveon, Marshadow (#3069)
* Batfix, Goldeen, Chomp, Golett, genies

* Fix Dudunsparce using Reborn shiny backsprite for whatever reason

* Fix female Hisuian Sneasel missing variants

* Marshadow epic front and Zenith, Sylveon back

* Fix Zubat line back sprite inconsistencies

* Fix Noivern shiny back
2024-07-22 11:16:23 -04:00
Adrian T.
f298ec3111
[Enhancement] Decouple move accuracy and accuracy multiplier calculation from phases.ts (#2899)
* refactor accuracy calc

* update doc

* move accuracy multiplier calculation outside phases

* update wonder skin unit test

* rename method

* add docs

* add unit tests

* address feedback

* rename method

* fix imports

* improve tests

* add test for ohko move accuracy
2024-07-22 11:14:42 -04:00
AJ Fontaine
4ad53024b4
Add remaining relearn moves (#2894) 2024-07-22 11:14:15 -04:00
schmidtc1
21f5595e06
[Bug] Fixes Encore bug with multi-target moves missing (#3060)
* Pushes move history even when multi target move misses

* Move pushMoveHistory out of Move Pending condition
2024-07-22 10:59:04 -04:00
NightKev
ecbf7570b3
Make EXP boosting items stack additively and not multiplicatively (#3094)
Fixes #2040
2024-07-22 10:47:56 -04:00
NightKev
cc6b424813
Prevent RNG from breaking the Quick Draw tests (#3096) 2024-07-22 10:32:31 -04:00
NightKev
50cf1c07a2
Fix broken multi_target tests and remove RNG-based failures (#3095) 2024-07-22 10:30:56 -04:00
서명인 (Myungin, SEO)
cda74481de
[Localization] Add minor Korean translations to ability-trigger file (trace) (#3093)
* modify trace trigger description (refered from official translation)

modify trace trigger description (refered from official translation)

* modify trace trigger description (refered from official translation)

modify trace trigger description (refered from official translation)
2024-07-22 01:33:04 -04:00
Frederico Santos
5abf9ec190 feat: Delete duplicate cookies with the same name in getCookie function 2024-07-21 16:30:53 +01:00
Frederico Santos
cf950313fc feat: Improve cookie handling in getCookie function 2024-07-21 16:08:51 +01:00
Frederico Santos
93bcf8ade9 fix: Remove unnecessary cookie setting in LoginPhase and MenuUiHandler 2024-07-21 15:55:42 +01:00
Frederico Santos
4c655691e5 feat: Add prompt=none to Discord OAuth authorization URL 2024-07-21 15:47:35 +01:00
Frederico Santos
22cd54c4f0 fix: update SameSite attribute in setCookie function to Strict 2024-07-21 15:25:38 +01:00
Frederico Santos
8d1a0660cb fix: update SameSite attribute in setCookie function to None 2024-07-21 14:48:42 +01:00
Amani H.
a2edc214f0
[Refactor/Test] Update Dynamax Cannon Unit Tests (#3074)
* [Refactor/Test] Update Dynamax Cannon Unit Tests

* Adjust Test Names
2024-07-19 22:32:47 -04:00
AJ Fontaine
94b032ab1c
[Balance] Add 12 new TMs and remove 3 (#2733)
* Added Counter TM

* Counter, Aqua Tail, Gastro Acid, Pluck, Secret Power, Aurora Veil, Incinerate

* Placed TMs in proper order, added to pool

* Add Secret Power to the pool

* Add TM for Synthesis

* Covet, Heal Bell, PUPunch, Recycle, Volt Tackle, Worry Seed

* Remove species specific TMs

* Remove Secret Power TM until implementation
2024-07-20 02:16:19 +01:00
Dakurei
be1f938d2c
[Music/BGM] New music added for the "Sea" biome, composed by Andr06 (#3063)
* Replacement of the BGM in the sea biome (by Andr06)

* Modification of BGM credits in README.md

* Replacement of the BGM name by the title chosen by its composer in all languages

* Update BGM loop point for biome 'SEA'
2024-07-19 00:51:10 -04:00
chaosgrimmon
6735dd7241
[Sprite] Mega Mewtwo sprite fixes (#3065)
* [Sprite] Add static epic Mega Mewtwo Y

Colours taken from exp, as consistent/exp rare backs share palettes.

* [Sprite] Fix transparent pixels on Mega Mewtwo X

* [Sprite] Fix transparent pixels on Mega Mewtwo X

* [Sprite] Add static epic Mega Mewtwo Y

Now exists, and is a paletteswap
2024-07-19 00:50:42 -04:00
chaosgrimmon
36cf0eacd0
[Sprite] Remove extra Oinkologne sprites (#3067)
* Delete public/images/pokemon/female/916.png

* Delete public/images/pokemon/exp/female/916.json

* Delete public/images/pokemon/exp/female/916.png

* Delete public/images/pokemon/female/916.json
2024-07-19 00:50:25 -04:00
DustinLin
37526c8356
[BUG] Uturn faint switch bug fix (#2980)
* reordering adding switch phases for u-turn

* reverting some temp changes

* generalizing function

* adding PR suggestions

* nit indenting
2024-07-19 00:03:57 +01:00
송영진
eb4604db26
[Bug] implemented multi target damage penalty (#2329)
* fix: damage multiplier by  the number of targets

* fix: used actual number value rather than the number holder

* test: added unit test for counting targets

* multi-target: fixed names of the unit tests.

* test: simple-test changes

* test: changed multi-target test code

* test: testing damage decreasement

* test: multi-target test fix

* resolved conflicts in test

---------

Co-authored-by: Tempoanon <163687446+Tempo-anon@users.noreply.github.com>
2024-07-18 16:49:00 -04:00
Dakurei
719764e2a4
[Music/BGM] New music added for the "Slum" biome, composed by Andr06 (#3000)
* Replacement of the BGM in the slum biome (by Andr06)

* Modification of BGM credits in README.md

* Replacement of the BGM name by the title chosen by its composer in all languages

* Update BGM loop point for biome 'SLUM'
2024-07-18 16:41:13 -04:00
Amani H.
99f4a9dd25
[Item] Add Scope Lens and Leek (#2666)
* [Item] Add Scope Lens and Leek

* Add Entry to pt_BR

* Localize for pt_BR

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Fix & Clean Unit Tests

---------

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
2024-07-18 10:20:55 -04:00
flx-sta
dd693ae2d3
stop loading pride-update banner (#3057) 2024-07-17 19:20:59 -05:00
Dakurei
27b03aface
[Music/BGM] Fix bgm file & loop for battle_rival (#3053) 2024-07-17 16:32:38 -04:00
José Ricardo Fleury Oliveira
c4e146b24b
[Beta][Localization] Update Portuguese battler-tags.ts and battle.ts (#3050) 2024-07-17 12:30:12 -04:00
Dakurei
bde9b84cac
Fix FR typo (#3051) 2024-07-17 11:06:51 +01:00
AJ Fontaine
4353ccc008
[Sprite] Fix Cofagrigus sprite (#3045)
* Fix Cofagrigus sprite

* Base sprite fix

* Created json variant file... manually
2024-07-17 00:19:01 -04:00
cam
fcbe5e9d76
[Bug][Fix][Surf][Muddy Water][Sludge Wave][Animation] Added image to move animations. (#3044)
* Update muddy-water.json

* Update sludge-wave.json

* Update surf.json
2024-07-16 22:17:30 -04:00
mcmontag
514c6a196c
[Bug] Fix level 100 moves being skipped if leveled past 100 (#3040) 2024-07-16 22:16:57 -04:00
chaosgrimmon
d96b553dc2
[Sprite] Revert Larvesta, fixing stray pixels (#3042)
* [Sprite] Remove normal Larvesta stray pixels

Taken from original commit

* [Sprite] Revert shiny Larvesta stray pixels

Taken from original commit

* [Sprite] Match variant Larvesta colours
2024-07-16 22:12:15 -04:00
Niccolò
e6639eca04
Update egg.ts (italian) (#3038) 2024-07-16 13:21:08 -04:00
Enoch
7d0437de6a
[Localization] Localize ability messages in ability.ts (trigger, apply...) (#2972)
* localize ability messages

* Update src/locales/de/ability-trigger.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Modify parameter name, fix eslint

* Korean Translation, modify some wrong param

* Add missed message

* Update src/locales/de/ability-trigger.ts

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>

* Update ability-trigger.ts (Partial) (Italian)

* Localize type name

* Localize type name > Libero, Protean

* param bug fix

* Update src/data/ability.ts

* Update zh-cn

* Update ability-trigger.ts (Partial part 2, still not completed) (Italian)

* Update src/locales/fr/ability-trigger.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

* Update src/locales/pt_BR/ability-trigger.ts

Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>

* Update src/locales/fr/ability-trigger.ts

Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>

---------

Co-authored-by: 송지원 <jiwsong@gmarket.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
2024-07-16 10:19:49 +01:00
Madmadness65
66481c0283 Add missing passive background graphic for legacy UI
Relating to #2497 , this adds an identical graphic to the legacy UI files, as it will show up as a missing texture otherwise.
2024-07-15 20:07:33 -05:00
schmidtc1
4261ab37ab
[BUG] Fixes bug with Metronome freezing the game (#2819)
* Tests MovePhase with new PokemonMove instead of moveset search

* Accounts for metronome call on charging moves

* Update comment in ChargeAttr to be clearer
2024-07-15 13:13:04 -04:00
schmidtc1
b215de1628
[Move] Implements Conversion 2 (#2943)
* Creates function to get type resistances, implements conversion 2

* Removes unimplemented tag, adds condition for move history to exist

* Cleans up type selection, creates i18n entries for typeChanged

* Uses typeChanged i18n in Conversion move

* More detailed docs, early return with stellar/unknown type

* Adds note that it wont track type-changing moves properly

* Rephrases doc description, adds partial since it can't track type-changing moves

* Updates localization, removes typeChanged entry to use move-trigger entry

* Missed locale de entry in last commit

* Adds comment for reason of .partial()

* Fixes localization error due to revert, removes improper merge conflict from prior commit
2024-07-15 13:12:35 -04:00
NightKev
21f2e6981c
[Bug] Remove redundant damage number popups (#3024)
* Remove magic number from Belly Drum's attr

* Remove redundant damage number popup

* Fix merge issue and remove another duplicate damage number instance
2024-07-15 01:51:26 -04:00
Jannik Tappert
4bf5031304
[Localization] Brought german localization up to date (#3010)
* Fixed errors in the german localization

* Fresh Start Challenge

* Update src/locales/de/move-trigger.ts

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>

* Apply suggestions from code review

---------

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-07-15 01:44:19 -04:00
Corrade
b1e7ae43a1
[Bug] Prevent fixed-damage and OHKO moves from being modified by damage-reducing abilities (#2703)
* ReceivedMoveDamageMultiplierAbAttr patch: WIP refactored damage calculation, reordered ReceivedMoveDamageMultiplierAbAttr to avoid issues with fixed damage and OHKO moves, stubbed unit tests for dragon rage (fixed damage) and fissure (OHKO)

* ReceivedMoveDamageMultiplierAbAttr patch: commented concerns regarding EnemyDamageBooster/ReducerModifier for others' reference in WIP branch

* ReceivedMoveDamageMultiplierAbAttr patch: reordered ReceivedMoveDamageMultiplierAbAttr and EnemyDamageBooster/ReducerModifier to not trigger for fixed damage and OHKO moves, completed relevant tests for dragon rage and fissure

* ReceivedMoveDamageMultiplierAbAttr patch: removed newline

* ReceivedMoveDamageMultiplierAbAttr patch: in the unit test, extracted hard-coded Dragon Rage damage to a variable

* ReceivedMoveDamageMultiplierAbAttr patch: naming consistency

* ReceivedMoveDamageMultiplierAbAttr patch: replaced awaiting DamagePhase with TurnEndPhase as the former assumes damage will be done

* ReceivedMoveDamageMultiplierAbAttr patch: removed redundant overrides in Fissure tests

* ReceivedMoveDamageMultiplierAbAttr patch: tests: refactored crit removal, removed berries, fixed bug associated with Porygon sometimes getting Trace and copying the opponent's ability, which would override the manual ability override

* Fixed unit tests

* Added a comment and cleaned up an existing one
2024-07-14 19:16:15 -04:00
sodam
a9a071bb4d
[Localization(ko)] Fixed typo in Bertha's dialogue (#3025) 2024-07-14 15:23:04 -04:00
Jannik Tappert
76b42c4f46
Revert "[Localization]Localized move-trigger text (#2913)" (#3026)
This reverts commit 39bdfea0c8.
2024-07-14 16:24:37 +01:00
Enoch
2efde67d3d
[Localization(ko)] Change line-break position of ghost type curse add message (#3022) 2024-07-14 00:56:59 -04:00
Zoruu
984b1883fc
[Bug] Fix to epic shiny Yungoos icon (#2991) (#3016)
Fixed a floating pixel in epic shiny Yungoos' icon. Caused by Mimikyu's epic shiny sprite being placed too high on the sprite sheet. Moved Mimikyu's sprite down and updated json to reflect the change.
2024-07-14 00:39:01 -04:00