+ Choose colors adapted to provide a contrast that facilitates reading (ratio of 3.0 or more)
Tool used: https://webaim.org/resources/contrastchecker/
+ Refactoring of the condition to avoid unnecessarily assigning variable several times depending on the contents of 'ppPercentLeft'
* Fixed bug where pokemon info container will show form of a pokemon that doesn't have it if the previously caught pokemon has a form
* Updated pokemonFormText to also disable interactive section if there was one
* Adding UI elements for new gender, ability and nature
* Added new indicators for shiny, gender, ability and nature
* Changed position of gender icon to top left
* Changes with logging and old (+) indicators for nature, form and ability
* Updated to remove old code and comments, as well as various console logs
* Updated commented code
* Addressing PR feedback
* Updated form to have a label and form name, along with cutting off the form name if it's too long
* Updated stats container to move some labels around so there's less text clumped together
* Removed some old commented code
* Fixed some issues with typing and naming
* Accidentally pushed my overrides.ts before :). Sorry!
* Updated the form name's hover over section to only work when the text is truncated
* Updating the gender check to work off DexAttr instead of a weird 2
---------
Co-authored-by: Temps Ray <temps.ray@gmail.com>
* Colorcode pp in fight ui if only half/quarter of maxPP is left
* Use three-level color coding for remaining pp
* use if/else for calculating pp color
---------
Co-authored-by: Kevin Greiner <greiner@infai.org>
* Achivments(localization of name and description) now depend on the player gender
* Fixed Name in ptBr config
* Now the achivments are also shown with a gender specific title
* Changed it so it checks if PlayerGender is undefined first
* Update src/locales/de/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/en/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/es/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/fr/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/it/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/ko/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/pt_BR/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/system/voucher.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/zh_CN/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/locales/zh_TW/config.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achv-bar.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achv-bar.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achv-bar.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achv-bar.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/system/achv.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/system/achv.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/system/achv.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achvs-ui-handler.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achvs-ui-handler.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* Update src/ui/achvs-ui-handler.ts
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
* instantiate player gender on in AchvBar constructor
* Reverted the change made only for the tests. And adjusted the import to use the new enum file
* Changed a import to make vite build it again correctly
* Again some changes to the imports for the github docs that was complaining
* The new challenges are also now localized and gender based
* Readded getDescription
---------
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
* show currently bound controls on starter menu for last active device
* add special handling for touch controls
* remove hardcoded controls for all locales
* type hints
* fix overwritten change
* don't set color to white, just leave it unchanged
* remove unrelated code
* don't show hints if no opponents, use type effectiveness instead of move effectiveness
* fix color not going back to white when new opponent is sent
* move effectiveness to move info container
* add effectiveness overlay, partial hints only show move effectiveness, improve colors
* lint
* docs
* remove full hints, move container to right of enemy info box
* hide effectiveness while flyout is visible
* move setting to display, use default style color instead of white
* Initial challenge framework
* Add type localisation
* Change how challenges are tracked
Also fixes the difficulty total text
* MVP
Renames challenge types, temporarily hides difficulty, and implements challenge saving.
* Attempt to fix one legal pokemon in a double battle
* Make monotype ignore type changing effects
* Make isOfType correctly detect normal types
* Try to fix double battles again
* Make challenge function more like classic
* Add helper function for fainted or not allowed
* Add framework for fresh start challenge and improve comments
* Try to fix evolution issues
* Make form changing items only usable from rewards screen
* Update localisation
* Additional localisation change
* Add achievements for completing challenges
* Fix initialisation bug with challenge achievements
* Add support for gamemode specific fixed battles
Also make monogen challenges face the e4 of their generation
* Add better support for mobile in challenges
* Localise illegal evolution/form change message
* Update achievement names
* Make alternate forms count for monogen
* Update monotype achievement icons
* Add more comments
* Improve comments
* Fix mid battle form changes
* Reorder mode list
* Remove currently unused localisation entry
* Add type overrides for monotype challenges
Meloetta always counts for psychic and castform always counts for normal
* Change how form changes are handled
Now attempts a switch at the start of each turn instead of immediately
* Add start button to challenge select screen
* Make starter select back out to challenge screen if using challenges
* Fix daily runs
* Update tests to new game mode logic
* refactor executed code while importing and initializing all of these in loading-scene
* reset to main
* fix server url
* added rule no-trailing-spaces
* made progress
* test somme data from a session save is working
* trying to launch a battle
* added fetch wrapper to load data locally
* trying to mockAllSettled
* pushPhase & shiftPhase
* check integrity of exported session
* set toke + loggedInUser in tests
* progress on starting new battle
* tring to test phase but it's async
* mocking fetch
* working mock fetch
* need to handle pile of data
* attempt to use real phaser classes
* reorder overrides
* refactored to use some real classes from phaser
* removed useless things
* started to work on some container mock
* finished the mockContainer time to add some logic
* some more mock containers
* removed addMethods since there is the mock classes now
* commented issues
* attempt to create mockTextureManager
* fix tests
* mockSprite & mockText
* yes but not really
* yes but not really
* fix tutorial callback
* reached mode title
* added achievement tests
* fix test achievements with current state of mock
* correct sequence loading for BattleScene with mockLoader !
* deep dive into next step
* working wait until starter selection screen
* added newGame method into wrapper
* expect to save_slot
* trying to manage pokemon sprite for getAll without success yet
* added test for egg output
* fixed egg test for June
* fix tests + locate next issue to fix
* we are in battle baby
* added new game in one-line
* export is working but export only what's in the fetch
* fix start game as guest
* refactored how we start a battle + cleanup
* overrided mewtwo but issue with currentBattle
* refactor: rename InitAchievements to initAchievements
* added missing mock method
* override level and pokemon forms working as intended
* bringToTop Obj
* remove launch battle in achivement test
* fix getIndex when same pokemon
* can run all tests
* first attack, faint, and shop modifiers, MockClock
* on method for container
* added doAttack one-liner
* one-line export data
* removed throw error
* feat: Make `scenes` property of `GameWrapper` class public
The `scenes` property of the `GameWrapper` class was changed from private to public. This change allows external access to the `scenes` map, which is used to store Phaser scenes. This modification was made to enable easier manipulation and interaction with the scenes in the game.
* correction
* removed CanvasRenderer
* added a param to remove console.log and added a param to preven scene create call
* fix encounter wave 30 when it's a trainer
* test double-battle
* test fight without KO
* test double fight no ko
* fix crashing texture + added Text wrapper to log fight
* fix tests on boss - trainer - rival
* chore: Refactor BattleScene initialization and add new phases
Refactor the BattleScene initialization code to remove unnecessary delay and improve performance. Also, add new phases for the title and unavailable states to enhance the game experience.
* rework of Game tests
* skipFn is working
* added onNextPrompt and restore Og Start
* better newGame
* added skipFN in remove
* not yet working test but updated interceptors
* do attack work but not on PostSummonPhase phase when there is mention of silcoon and wurmple
* error located, it's just a double fight, i was not there yet
* single OHKO & double no OHKO
* added expirationFn into next prompt
* all tests are passing
* working test on non damaging move from opponent
* cleaned a bit
* removed phaser initialisation on every tests
* renamed test file
* added load system data
* added some ability support
* added onKill & onSummon abilities test
* removed useless test + cleanup
* removed useless test + cleanup
* fixed tests after merge main
* added itemHeld endTurn trigger test (toxic orb)
* added runFrom..To
* added mustRun to assert currentPhase
* added no-miss move to test things
* cleaner restore mock
* fix test
* fix moxie test + game speed
* improve test speed
* added onOurself and onOpponent mvoe test
* added onDamage test for tackle
* removed timeout in intervals to run tests faster
* cleanup
* added never crit override + separate file per test + remove randomness in randBattleSeedInt
* move folders
* better org
* renamed itemHeld folder to items
* fix deploy.yml
* cleanup
* simplified the gameManager start battle and allow single pokemon in party
* remove the need of mode development
* added input handler to test inputs + remove time from phaser into inputController
* added keyboard support
* added fakeMobile support
* added details
* removed a console.log + added logUp
* move test to folder
* fixed canvas issue
* added starter select tests
* added some more test on starter-select
* added battle-order tests
* added battle-order tests
* fixing Phaser RNG
* ordering stats for better reading
* fix tests for main
* adapt battle-order test to be more readable
* fix merge
* fix some errors and silent all errors from gameWrapper since it's not possible to avoid them
* fix mocks to manage childs & stuffs
* added some docs
* fix achievement test
* removed an unused file
* separate misc tests to clean battle.test file
* added a basic french lokalization test
* added i18n where it needs to be used only
* revers extracted method
* removed unused method
* removed handler fetch since we do not test anything server related
* fix test with handlers removed
* added intrepid sword test
* fix enum exp party
---------
Co-authored-by: Frederico Santos <frederico.f.santos@tecnico.ulisboa.pt>
* fixed wrongly stacking overlay issues
- starter selection
- IVs are now behind the overlay
- the overlay should clear when exiting it via controller (requires tests as i don't have a controller)
- TM
- will prevent C/Shift from showing the overlay until the next item selection, when selecting a TM as item reward.
- will prevent C/Shift from showing the overlay when canceling item selection
* removed reference to previously deleted resource
* fixed override
* [Feature] Move to start button when you can't add party anymore
* Add comment about #1673
* Update starter-select-ui-handler.ts
---------
Co-authored-by: Benjamin Odom <bennybroseph@gmail.com>
* Refactored settings UI menu options and added the battle style setting
* Removed the new Battle Style setting. It will be added in a seperate PR.
* Fixed typo and spacing
* Added "Skip Dialogues" option (if at least 1 classic win)
* Removed error sound and hide option instead when classic wins = 0
* Add skip dialogues option to Unlockables and show unlocked message on first classic win
* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage
* oops
* dont show charSprite when skipping a dialogue, small fixes
* correctly reset move description scrolling when changing move
* override fix
---------
Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
* move info implemented for starter selection
a move info box is displayed when editing the starter moveset.
also menus have now onHover triggers.
todo:
- show ui when selecting TMs
- show ui when selecting moves to remember (memory mushroom)
* More Move Info Overlays
Added overlays during Memory Mushroom use and when viewing TMs.
Furthermore a settings option can enable/disable those overlays.
* Added missing ko language entry
... though translation still remains necessary
* updated ui
also added overrides for item rewards
* minor ui update
moved values to the right in the tm move info box
* fixed typedoc issues
* removed settings in to prepare for merge
* updated settings option
added settings option to new settings implementation
* minor changes
removed unused graphic
moved settings option to accessibility
* move PlayerGender enum into src/data/enums/player-gender.ts
this is necessary to avoid circular dependencies which did crash tests in the past (in PRs)
* Update settings.ts
* Update game-data.ts
* Update summary-ui-handler.ts
* Update ui.ts
* move Passive & GameDataType enums into own files
* Added "Skip Dialogues" option (if at least 1 classic win)
* Removed error sound and hide option instead when classic wins = 0
* Add skip dialogues option to Unlockables and show unlocked message on first classic win
* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage
* oops
* dont show charSprite when skipping a dialogue, small fixes
* pokemonInfoContainer always on top of battle UI when shown
* removed setDepth and rather hide enemyModifierBar
---------
Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
* Added "Skip Dialogues" option (if at least 1 classic win)
* Removed error sound and hide option instead when classic wins = 0
* Add skip dialogues option to Unlockables and show unlocked message on first classic win
* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage
* oops
* dont show charSprite when skipping a dialogue, small fixes
* pokemonInfoContainer always on top of battle UI when shown
---------
Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
* Handle if the browser gives a long form of a language (like "de-DE") for cases where we only have the short form "de".
* Changed it so that now resolved Language is now used anywhere. This is basically what i orignally did manually but provided from i18next directly
* Added "Skip Dialogues" option (if at least 1 classic win)
* Removed error sound and hide option instead when classic wins = 0
* Add skip dialogues option to Unlockables and show unlocked message on first classic win
* Only skips seen dialogues, removed dialogue option from unlockables, seen dialogues get saved to local storage
* oops
* dont show charSprite when skipping a dialogue, small fixes
---------
Co-authored-by: Frederik Hobein <frederik.hobein@nterra.com>
* organizing, translations and achv localization
* localized for all languages
* minor fix
* minor fix 2
* minor fix 3
* Fixed Achivment Localization, Added german localization and fixes some issues with german localization at other parts
* fix pickup description
* Update French achv.ts
* French typo correction achv.ts
* eslint fixes
* added zhTW
* minor fix
* Achivment Bar is localized and gets bigger when using german
* Changed some things to make it not as Big
* The Achivment Bar now grows with the context
* Updated Achivment Names in german
* Update French achv.ts
* Vouchers now will show the correct descrption again
* minor fix
* minor fixes
* "sub" to "semi"
* minor fix
* fixes warning and organizes some files
* forgot about english
* korean translations
* test fix
---------
Co-authored-by: Jannik Tappert <tappertjannik@googlemail.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
* squased merge rebind_menu
* azerty to qwerty
* add a check to preven a crash in firefox
* reset navigation menu on quit
* removed dual lock mekanism
* navigation display update icons on new bind
* added submit binding
* removed attribute no longer used
* change protected to abstract
* remove last bind protection since action and cancel are protected + renamed default controller to controller
* removed default alt qwerty keys in config
* fix some errors for doc
* fix tests
* fix some more errors for docs
* fix some more errors for docs final ?
* added alt bind for menu navigation + update icons on delete/home
* Transferring item does not kick out of transfer menu
* Select simultaneously the item to transfer and the quantity
* eslint fix
* eslint fix
* Reset quantity on scroll
* Documentation
* eslint fix
