NightKev
0107b1d47e
[Refactor] Create global scene variable ( #4766 )
...
* Replace various `scene` pass-arounds with global scene variable
* Modify tests
* Add scene back to `fade[in|out]()` calls
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Fix Bug Superfan ME test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Re-enable fixed test
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
* Rename `gScene` to `globalScene`
* Move `globalScene` to its own file to fix import/async issues
* Fix `SelectModifierPhase` tests
* Fix ME tests by removing `scene` from `expect()`s
* Resolve merge issues
* Remove tsdocs referencing `scene` params
Remove missed instances of `.scene`
* Remove unnecessary `globalScene` usage in `loading-scene.ts`
* Fix merge conflicts
* Attempt to fix circular import issue
* Found the source of the import issue
* Fix merge issues
---------
Co-authored-by: Moka <54149968+MokaStitcher@users.noreply.github.com>
2025-01-12 15:33:05 -08:00
NightKev
00f7fd47df
[Refactor] Remove unnecessary re-exports ( #4818 )
...
* Remove unnecessary re-exports
* Move `Type` enum to `src/enums/type.ts`
* Remove import style change from `modifier-type.ts`
2024-11-08 17:44:34 -05:00
torranx
644c078a6c
add new lint rules....again
2024-10-04 13:08:31 +08:00
innerthunder
145b80f491
[P2] Fix Substitute blocking field effects ( #4504 )
...
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-30 13:14:38 -04:00
innerthunder
029d26b4c9
[Beta][P2 Bug] Fix Sappy Seed applying its secondary effect against targets with Substitute ( #4430 )
...
* Fix Sappy Seed applying Leech Seed through Substitutes
* Add docs
2024-09-25 22:32:20 -04:00
flx-sta
1a5cbf8ecb
[Refactor][Tests] Set default test timeout to 20s
( #4338 )
...
* set default test timeout to 20s
* remove "TIMEOUT" reference from create-test-boilerplate
* remove TIMEOUT from tests
* test: remove leftover `20 sec timeout` references
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
---------
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-20 23:05:45 +02:00
innerthunder
70295280da
[Move] Implement Substitute ( #2559 )
...
* Implement Substitute
Squashed commit from working branch
* Fix integration test imports
* Use Override Helper utils + Fix Baton Pass test
* Update src/test/moves/substitute.test.ts
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
* Fix test imports + nits
* Document RemoveAllSubstitutesAttr
* Fix some strict-null issues
* more strict-null fixes
* Fix baton pass test
* Reorganized Substitute translation keys
* Added checks for substitute in contact logic
* Clean up Unseen Fist contact logic
* Remove misleading comment in Download attr
* RIP phases.ts
* Fix imports post-phase migration
* Rewrite `move.canIgnoreSubstitute` to `move.hitsSubstitute`
* Also fixed interactions with Shell Trap and Beak Blast
* Removed some leftover `canIgnoreSubstitute`s
* fix issues after beta merge
* Status move effectiveness now accounts for substitute
* More edge case tests (Counter test failing)
* Fix Counter + Trap edge cases + add Fail messagesd
* Fix leftover nit
* Resolve leftover test issues
* Fix Sub offset carrying over to Trainer fights
* Hide substitute sprite during catch attempts
* Make substitutes baton-passable again
* Remove placeholder locale keys and SPLASH_ONLY
* Fix imports and other nits
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
* ESLint
* Fix imports
* Fix incorrect `resetSprite` timing
* Fix substitute disappearing on hit (maybe?)
* More animation fixes (mostly for Roar)
---------
Co-authored-by: Adrian T. <68144167+torranx@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-13 12:46:22 -04:00