Commit Graph

4231 Commits

Author SHA1 Message Date
ImperialSympathizer
fa55ab6d26
[Beta/Bug] Fix Breeders ME Dialogue Token Issue (#4411)
* revert styled dialogue

* revert styled dialogue

* revert styled dialogue

---------

Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-09-25 04:08:46 -04:00
flx-sta
9af89414b9
[Refactor][Localization] Better handling for StatusEffect.NONE with i18n (#4405)
* remove: `StatusEffect.NONE` from displaying any messages

even thougn this case will never occur, by code definition it should be covered

* remove: obsolete `statusEffect:none.` translation keys

* fix: status-effect test

* chore: undo overrides commit (whops)
2024-09-24 14:15:18 -07:00
ImperialSympathizer
254ffcf6d6
Merge pull request #4374 from ben-lear/mystery-encounter-fixes
[Beta][Bug/Balance] Mystery Encounter bug fixes and small balance adjustments (part 3)
2024-09-24 15:45:27 -04:00
flx-sta
969b0ea531
Merge branch 'beta' into mystery-encounter-fixes 2024-09-24 11:14:00 -07:00
ImperialSympathizer
d52f691d43 account for undefined egg moves 2024-09-24 14:06:59 -04:00
ImperialSympathizer
219215f54c fix getEggMoves() helper function 2024-09-24 13:51:02 -04:00
ImperialSympathizer
a1d1de2c0d more ME dialogue cleanup 2024-09-24 13:41:00 -04:00
ImperialSympathizer
24bbb0931c change return type of isNullOrUndefined 2024-09-24 13:15:18 -04:00
Tempoanon
baa806ec63
[Beta][P3 Bug] Fix typo in autotomize add message (#4404)
`pokemonNameWIthAffix` -> `pokemonNameWithAffix`
2024-09-24 11:45:29 -04:00
ImperialSympathizer
6dc1aedb8e more ME balance changes and bug fixes 2024-09-24 11:34:42 -04:00
ImperialSympathizer
0262635abb Merge branch 'beta' of https://github.com/ben-lear/pokerogue into mystery-encounter-fixes 2024-09-24 11:33:05 -04:00
ImperialSympathizer
c172fe1838 Merge branch 'mystery-encounter-fixes' of https://github.com/ben-lear/pokerogue into mystery-encounter-fixes 2024-09-24 11:32:49 -04:00
ImperialSympathizer
1513f2a57d more ME balance changes and bug fixes 2024-09-24 11:32:22 -04:00
Lugiad
22117115c8
[Localization] ME French Typos (#4399)
* Update a-trainers-test-dialogue.json

* Update absolute-avarice-dialogue.json

* Update an-offer-you-cant-refuse-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update clowning-around-dialogue.json

* Update dark-deal-dialogue.json

* Update field-trip-dialogue.json

* Update fiery-fallout-dialogue.json

* Update fun-and-games-dialogue.json

* Update lost-at-sea-dialogue.json

* Update mysterious-challengers-dialogue.json

* Update mysterious-chest-dialogue.json

* Update part-timer-dialogue.json

* Update slumbering-snorlax-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-strong-stuff-dialogue.json

* Update the-winstrate-challenge-dialogue.json

* Update training-session-dialogue.json

* Update uncommon-breed-dialogue.json

* Update weird-dream-dialogue.json

* Update berries-abound-dialogue.json
2024-09-24 10:03:11 -04:00
ImperialSympathizer
e77595ebb8
Update src/data/mystery-encounters/encounters/global-trade-system-encounter.ts
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-24 09:29:40 -04:00
ImperialSympathizer
b2b88c37cf fix Absolute Avarice test 2024-09-23 19:36:09 -04:00
ImperialSympathizer
ff256f78dd can no longer go above max rev seed stacks 2024-09-23 19:29:32 -04:00
ImperialSympathizer
4d8d605c02 merge from beta 2024-09-23 19:25:13 -04:00
ImperialSympathizer
05b9e74729 balance adjustments to certain ME battles 2024-09-23 19:23:46 -04:00
flx-sta
b2b314cd68
[Refactor][Tests] Remove manual test timeouts (#4385)
* remove: manual timeout setting

some more sneaked in after changing the default-timeout to 20s. Possibly older PRs.

* remove: manual test timeouts from chilly reception tests
2024-09-23 17:35:53 -04:00
ImperialSympathizer
23f006bc43
[Enhancement] Remove unnecessary loading of trainer sprites in loading scene (#4397)
* Remove unnecessary loading of trainer sprites in loading scene

* load trainer assets on demand for run history UI

---------

Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-09-23 17:34:47 -04:00
Tempoanon
eb264cffee
[Beta] Revert "[Enhancement] Set Appropriate Evil Team on Monogen Challenges (#4355)" (#4395)
This reverts commit 35cd615363.
2024-09-23 17:34:06 -04:00
Lugiad
f32e10d549
[Localization] ME translations (#4183)
* Update src/locales/es/mystery-encounters/department-store-sale-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/es/mystery-encounters/fight-or-flight-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/es/mystery-encounters/fiery-fallout-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/es/modifier-select-ui-handler.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/es/mystery-encounters/field-trip-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update a-trainers-test-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update bgm-name.json

* Added Korean missingthings at bug-type-superfan-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update shady-vitamin-dealer-dialogue.json

* Update slumbering-snorlax-dialogue.json

* Update teleporting-hijinks-dialogue.json

* Update the-pokemon-salesman-dialogue.json

* Update the-strong-stuff-dialogue.json

* Update the-winstrate-challenge-dialogue.json

* Update training-session-dialogue.json

* Update trash-to-treasure-dialogue.json

* Update trash-to-treasure-dialogue.json

* Update uncommon-breed-dialogue.json

* Update weird-dream-dialogue.json

* Update bgm-name.json

* Update src/locales/ko/mystery-encounters/bug-type-superfan-dialogue.json

Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>

* Update src/locales/ko/mystery-encounters/bug-type-superfan-dialogue.json

Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>

* Update src/locales/zh_CN/mystery-encounters/mysterious-chest-dialogue.json

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update src/locales/zh_CN/mystery-encounters/fight-or-flight-dialogue.json

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* one more typo fix

* Update slumbering-snorlax-dialogue.json

* Update absolute-avarice-dialogue.json

* Update an-offer-you-cant-refuse-dialogue.json

* Update berries-abound-dialogue.json

* Update the-pokemon-salesman-dialogue.json

* Update trash-to-treasure-dialogue.json

* Update uncommon-breed-dialogue.json

* Update weird-dream-dialogue.json

* Update weird-dream-dialogue.json

* Update slumbering-snorlax-dialogue.json

* translated a-trainers-test-dialogue.json

* Update src/locales/ja/modifier-select-ui-handler.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/mystery-encounter-messages.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Add files via upload

* Update the-expert-breeder-dialogue.json

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update src/locales/pt_BR/trainer-names.json

* Update src/locales/pt_BR/trainer-titles.json

* Update config.ts

* Update config.ts

* Update config.ts

* Delete src/locales/en/the-expert-breeder-dialogue.json

* Delete src/locales/ca_ES/the-expert-breeder-dialogue.json

* Delete src/locales/de/the-expert-breeder-dialogue.json

* Delete src/locales/es/the-expert-breeder-dialogue.json

* Delete src/locales/fr/the-expert-breeder-dialogue.json

* Delete src/locales/it/the-expert-breeder-dialogue.json

* Delete src/locales/ja/the-expert-breeder-dialogue.json

* Delete src/locales/ko/the-expert-breeder-dialogue.json

* Delete src/locales/pt_BR/the-expert-breeder-dialogue.json

* Delete src/locales/zh_CN/the-expert-breeder-dialogue.json

* Delete src/locales/zh_TW/the-expert-breeder-dialogue.json

* Add files via upload

* Update the-expert-breeder-dialogue.json

* Rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* updated name and conifg

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Update and rename the-expert-breeder-dialogue.json to the-expert-pokemon-breeder-dialogue.json

* Start of dialogue

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update config.ts

* Update absolute-avarice-dialogue.json

* Update absolute-avarice-dialogue.json

* Added the option to have the species name for all 3, made the name of the breeder localizable

* Revert changes that are in another pr

* She is apparently female so needs changes

* Update an-offer-you-cant-refuse-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* add translation for expert breeder

* Update src/locales/ja/mystery-encounter-messages.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/dialogue.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ko/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* Update src/locales/ko/trainer-names.json

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* Update src/locales/ko/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* Update src/locales/ko/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

* Update dialogue.json

* translated all MEs

* Update src/locales/zh_CN/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update src/locales/zh_CN/trainer-names.json

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update achv.json

* Update src/locales/ja/trainer-names.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/de/achv.json

* Update src/locales/de/achv.json

* Update an-offer-you-cant-refuse-dialogue.json

* Update berries-abound-dialogue.json

* Update bug-type-superfan-dialogue.json

* Update src/locales/pt_BR/achv.json

* Update translation for "breedersInSpace" in pt_BR splash-messages.json

* Update bug-type-superfan-dialogue.json

* Update src/locales/ko/achv.json

Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>

* Update src/locales/es/mystery-encounters/fun-and-games-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/ja/achv.json

Co-authored-by: protimita <protimitajp@gmail.com>

* Update src/locales/ko/mystery-encounter-messages.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update src/locales/ko/mystery-encounters/delibirdy-dialogue.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update src/locales/ko/mystery-encounters/delibirdy-dialogue.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update src/locales/ko/mystery-encounters/part-timer-dialogue.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update src/locales/ko/trainer-names.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update clowning-around-dialogue.json

* Update clowning-around-dialogue.json

* Update src/locales/es/mystery-encounters/global-trade-system-dialogue.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update src/locales/ja/mystery-encounters/bug-type-superfan-dialogue.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update global-trade-system-dialogue.json

* Update clowning-around-dialogue.json

* Update dancing-lessons-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update src/locales/de/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json

* Update src/locales/ko/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

* Update src/locales/zh_CN/mystery-encounters/the-expert-pokemon-breeder-dialogue.json

Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>

* Update bgm-name.json

* Update battle.json

* Update an-offer-you-cant-refuse-dialogue.json

* Update berries-abound-dialogue.json

* Update the-expert-pokemon-breeder-dialogue.json in pt_BR locale

* Update bug-type-superfan-dialogue.json

* Update src/locales/es/achv.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update bug-type-superfan-dialogue.json

* Update clowning-around-dialogue.json

* Update dancing-lessons-dialogue.json

* Update config.ts

* Update delibirdy-dialogue.json

* Update department-store-sale-dialogue.json

* Update weird-dream-dialogue.json

* Update battler-tags.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update mysterious-chest-dialogue.json

* Update weird-dream-dialogue.json

* Update uncommon-breed-dialogue.json

* Update field-trip-dialogue.json

* Update src/locales/ja/mystery-encounters/dark-deal-dialogue.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ko/mystery-encounters/berries-abound-dialogue.json

Co-authored-by: returntoice <171243264+returntoice@users.noreply.github.com>

* Update src/locales/ja/mystery-encounters/berries-abound-dialogue.json

Co-authored-by: returntoice <171243264+returntoice@users.noreply.github.com>

* Add files via upload

* Add files via upload

* Add files via upload

* Add files via upload

* Update mystery-encounter-messages.json

---------

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: Yonmaru40 <47717431+40chyan@users.noreply.github.com>
Co-authored-by: Leo Kim <47556641+KimJeongSun@users.noreply.github.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: KimJeongSun <leo@atlaslabs.ai>
Co-authored-by: protimita <protimitajp@gmail.com>
Co-authored-by: returntoice <171243264+returntoice@users.noreply.github.com>
2024-09-23 21:37:59 +02:00
PrabbyDD
3d4eadbc3e
[Bug] Flash Fire/etc now trigger even if the attack would miss (#4337)
* adding immunity check

* making tests

* modifying and adding tests

* making tests more rigorous

* changing hitcheck return to be what it was originally, no significant effect

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
2024-09-23 15:37:21 -04:00
chaosgrimmon
4557a73ecc
[Sprite] Standardise Sirfetch'd animation (#4393)
* [Sprite] Match Sirfetch'd animation

Taken from shiny counterpart

* [Sprite] Standardise Sirfetch'd animation

Colours taken from static sprite.
Spritesheet animation taken from shiny counterpart.

* [Sprite] Standardise Sirfetch'd animation

Colours taken from static sprite.
Spritesheet animation taken from shiny counterpart.
2024-09-23 15:36:17 -04:00
flx-sta
c4f81c55b0
[Tests][Mystery-Encounter] Fix The Strong Stuff flakyness (#4394)
* extend: log in encounter phase for better debugging

* fix: `the storng stuff` test flakiness

The enemy pokemon could get contrary or other abilities that cause the expected values to be ... not as expected

* remove accidental it.each

tests were being executed 30-100 times. This is a debugging tool but was never supposed to make it to merge.
2024-09-23 15:32:07 -04:00
Lugiad
3ef692227d
[Localization] Spanish Gitlocalize leftovers (#4390)
* Update battle.json

* Update move-trigger.json

* Update trainer-classes.json

* Update trainer-titles.json

* Update battle-info.json

* Update battle.json

* Update challenges.json

* Update common.json

* Update game-stats-ui-handler.json

* Update menu-ui-handler.json

* Update pokemon-info-container.json

* Update starter-select-ui-handler.json

* Update tutorial.json

* Update move.json

* Update battle.json
2024-09-23 13:10:02 -04:00
Tempoanon
342bd5c726
[Beta][Bug] Fix out of bounds Genesect form in Ghetsis_2 causing crash (#4389) 2024-09-23 12:05:49 -04:00
NightKev
554d4f0a95
[P2 Bug] Dragon Tail now properly respects abilities like Suction Cups (#4252)
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-23 11:50:42 -04:00
Tempoanon
b9b69ad834
[Move] Implement autotomization weight effects (#4228)
* Implement Autotomize

* Another linting

* Fix unit tests

* Add nonnull after checking for null

* Update autotomize test

---------

Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-23 11:42:17 -04:00
DanStevensonx
d2ba9751b5
[Localization] Fix Spanish Zippy Zap description (#4387)
* Update move.json

Translated the zippy move since it got lost in the gitlocalize disaster.

* Update move.json

---------

Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
2024-09-23 10:56:32 -04:00
NightKev
1d559f2194
[Test] Fix flaky Shell Side Arm test (#4383)
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-23 10:55:47 -04:00
flx-sta
8b6e55d5e9
[Test] flakyness in teleporting hijinks encounter test (#4386) 2024-09-23 10:55:01 -04:00
Opaque02
6626df27ba
[QoL] Adding challenge arrows (#4048)
Arrows allow for dynamic placement based on language

---------

Co-authored-by: MokaStitcher <54149968+MokaStitcher@users.noreply.github.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-22 23:34:41 -07:00
DustinLin
c387f498c8
[Bug] Fix move Chilly Reception (#3198)
Co-authored-by: Lugiad' <adrien.grivel@hotmail.fr>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: José Ricardo Fleury Oliveira <josefleury@discente.ufg.br>
Co-authored-by: mercurius-00 <80205689+mercurius-00@users.noreply.github.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: protimita <protimitajp@gmail.com>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
2024-09-22 20:09:51 -07:00
innerthunder
f2fe430f8a
[Balance] Ability-ignoring effects no longer ignore the source's own Abilities (#3556)
* Ability-ignoring effects no longer ignore the source's Abilities

* Update src/field/arena.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* RIP `phases.ts`

* `ignoreAbilitySource` --> `ignoringEffectSource`

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-22 19:54:19 -07:00
Yiling Kang
b9b2491f95
[Ability] (Partially) Implement synchronize ability with old psycho shift interaction (#2746)
* Initial changes for Synchronize ability

* Fix psycho shift interaction causing buggy behaviour

* Update to show ability even if opponent pokemon does not get statused

* Fix some spacing

* Update tests

* Formatting change

* Remove impossible `if` statement

* Add `simulated` support

* Apply suggestions from code review

Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>

* Don't need those comments

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
Co-authored-by: innerthunder <168692175+innerthunder@users.noreply.github.com>
2024-09-22 19:38:09 -07:00
Blitzy
107a7497a9
[Balance] Further Minor Adjustments to Evil Teams (#4376)
* Update trainer-config.ts

* Update Abilities on certain Mons

* Update trainer-config.ts
2024-09-22 21:34:27 -04:00
NightKev
59f28efa1d
Fix crash when using enemy move override (#4352)
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-22 18:06:53 -07:00
ImperialSympathizer
cf80abe33f small locales fixes 2024-09-22 19:04:56 -04:00
ImperialSympathizer
eb0e8ccca7 possible Pokemon Salesman shiny fix 2024-09-22 14:19:47 -04:00
AJ Fontaine
23b64b94b5
Function to adjust lure weights (#4354) 2024-09-22 20:07:45 +02:00
innerthunder
3ef02c9bbd
[Balance] Remove Species Locks from Aura Wheel and Poison Puppeteer (#4330)
* Remove non-form-change species locks

* Fix typo in localization

* Mark descriptions that need changes

* Update ability.json

* Update move.json

* Update ability.json

* Update src/locales/pt_BR/ability.json

* Update src/locales/pt_BR/move.json

* KO translations

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/de/ability.json

* Update src/locales/de/move.json

* Update src/locales/de/move.json

* Update ability.json

* Update move.json

* Update src/locales/it/move.json

* Update src/locales/it/ability.json

* Update src/locales/ja/move.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/ability.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/es/ability.json

Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>

* Update move.json

* Update src/locales/zh_CN/ability.json

Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>

---------

Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: DanStevensonx <114961842+DanStevensonx@users.noreply.github.com>
Co-authored-by: btsrkex <34084904+btsrkex@users.noreply.github.com>
2024-09-22 20:07:35 +02:00
ImperialSympathizer
32741835fd more Mystery Encounter bug fixes 2024-09-22 13:53:18 -04:00
Lugiad
2028848845
[Localization] BGM Changes in locales (+slight Spanish and French corrections) (#4302)
* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update src/locales/ja/bgm-name.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/bgm-name.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update src/locales/ja/bgm-name.json

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update src/locales/ko/bgm-name.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ko/bgm-name.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ko/bgm-name.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update ability-trigger.json

* Update battle.json

* Update ability.json

---------

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
2024-09-22 19:25:19 +02:00
Jannik Tappert
7046f854c1
[Feature] The Form Names in the Catching Summary are now localized (#3628)
* Form names are now localized when catching a pokemon (and probably hatching a egg since its the same dialogue)

* Update src/ui/pokemon-info-container.ts

* Update src/ui/pokemon-info-container.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update src/ui/pokemon-info-container.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

* Update pokemon-info-container.ts

* Update pokemon-info-container.ts

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update pokemon-form.json

* Update pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/ko/pokemon-form.json

Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>

* Add missed keys, make empty-key displayed, change EN to original formName

* add missed key, add korean translation (partial)

* Korean translation, refactor code

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Update src/locales/de/pokemon-form.json

* Apply suggestions from code review

* Update src/locales/de/pokemon-form.json

* Apply suggestions from code review

* Update pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update src/locales/pt_BR/pokemon-form.json

* Update pokemon-form.json

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ja/pokemon-form.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update src/locales/it/pokemon-form.json

* Update pokemon-form.json

deleted all of the remaining "form" snippets since it'll be shown as "Form: form name" so the form snippet was useless

* Apply suggestions from code review

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>

---------

Co-authored-by: Lugiad <adrien.grivel@hotmail.fr>
Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
Co-authored-by: Niccolò <123510358+NicusPulcis@users.noreply.github.com>
Co-authored-by: sodam <66295123+sodaMelon@users.noreply.github.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
2024-09-22 17:41:38 +02:00
gruxor
590758f616
[QoL] Show move description via info button (#4165)
* Show move desc via info button

* Update src/ui/move-info-overlay.ts

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>

---------

Co-authored-by: NightKev <34855794+DayKev@users.noreply.github.com>
Co-authored-by: flx-sta <50131232+flx-sta@users.noreply.github.com>
2024-09-22 17:31:53 +02:00
Lugiad
4475eec607
[Localization] Team Star Translations (#4356)
* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update bgm-name.json

* Update dialogue.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-classes.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update trainer-titles.json

* Update dialogue.json

* Update dialogue.json

* Update dialogue.json

* Update dialogue.json

* Update dialogue.json

* Update dialogue.json

* Update src/locales/de/bgm-name.json

* Update src/locales/de/bgm-name.json

* Update src/locales/de/bgm-name.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/bgm-name.json

* Update src/locales/ko/bgm-name.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/ko/trainer-classes.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update src/locales/de/dialogue.json

* Apply suggestions from code review

Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>

* Update src/locales/ko/bgm-name.json

Co-authored-by: Enoch <enoch.jwsong@gmail.com>

* Update trainer-titles.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/dialogue.json

* Update src/locales/de/bgm-name.json

* Update src/locales/de/trainer-classes.json

* Update src/locales/de/trainer-classes.json

* Update src/locales/de/trainer-titles.json

* Update src/locales/de/trainer-titles.json

* Update src/locales/de/trainer-names.json

* Update src/locales/de/trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update trainer-names.json

* Update dialogue.json

* Update dialogue.json

* Update dialogue.json

* Update src/locales/fr/dialogue.json

* Update src/locales/fr/dialogue.json

* Update trainer-classes.json

* Update bgm-name.json

* Update src/locales/de/dialogue.json

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Apply suggestions from code review

Co-authored-by: returntoice <dieandbecome@gmail.com>

* Update trainer-titles.json

---------

Co-authored-by: Jannik Tappert <38758606+CodeTappert@users.noreply.github.com>
Co-authored-by: Enoch <enoch.jwsong@gmail.com>
Co-authored-by: Chapybara-jp <charlie.beer@hotmail.com>
Co-authored-by: returntoice <dieandbecome@gmail.com>
Co-authored-by: José Ricardo <josefleury@discente.ufg.br>
2024-09-22 17:31:33 +02:00
ImperialSympathizer
1c87532e64
[Bugs/Balance] Fix various ME bugs and small balance adjustments (#4369)
* various bug fixes for MEs

* various bug fixes for MEs

* fix final isTransferable rename that was missed

* change Trainer's test vouchers for second option

* change unit test skips

* cut down excess ME track length and loop properly

* ME bug fix cleanup

* updating AI for Slumbering Snorlax ME, and small ME balance changes

* fix ts error

* fix bug type superfan dialogue discrepancy

* ME bug fixes PR feedback

* ME PR nits and fixes

* update naming convention of sprites

* ME balance changes and bug fixes

* fix tests

* fix An Offer You Can't Refuse ME requirements

* clean up post-battle logic for Breeder ME

* party size requirement cleanup

* clean up challenge requirements for disabling certain MEs

---------

Co-authored-by: ImperialSympathizer <imperialsympathizer@gmail.com>
2024-09-22 05:47:32 +02:00
Amani H.
612dcc5f27
[Balance] Adjust Relevant Abilities to Match Lures (#4231)
* [Balance] Adjust Relevant Abilities to Match Lures

* Add Relevant Unit Tests
2024-09-21 21:40:47 -04:00